Page MenuHomePhabricator
Create Task
Maniphest T144812

Deploy related pages to mobile web stable channel - part 1
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Jdlrobson
Authored By
ovasileva
Sep 6 2016, 2:00 PM
Tags
Referenced Files
F4587480: iOS 9 Safari (Hungarian).PNG
Oct 11 2016, 11:06 PM
F4587479: Samsung Galaxy SIII (Android 4.x) - Chrome, Hungarian.png
Oct 11 2016, 11:06 PM
F4587478: Samsung Galaxy SIII (Android 4.x) - Web Browser, Spanish.png
Oct 11 2016, 11:06 PM
Subscribers
Aklapper
BBlack
dr0ptp4kt
EBernhardson
elukey
gerritbot
Jdlrobson
View All 11 Subscribers

Description

Stories

  1. As a user, I want the ability to see related pages to the article I am reading on mobile
  2. As wikimedia, I want to deploy related pages to all wikipedias but the top 6, so that I can gauge the feature success before deploying everywhere.

Description
Deploy related pages to all wikipedias except: English, Japanese, Spanish, German, Russian, French week of 10/03/2016

Testing Criteria

  1. Go to any mobile wikipedia that is NOT English, Japanese, Spanish, German, Russian, French
  2. Ensure related pages section appears
  3. Ensure related pages section does not appear on English, Japanese, Spanish, German, Russian, and French wikipedias

Details

SubjectRepoBranchLines +/-
Merge config declarationsoperations/mediawiki-configmaster+3 -7
Enable RelatedArticles on Minerva skin for all but top 6 wikisoperations/mediawiki-configmaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.Sep 6 2016, 2:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2016, 2:00 PM
ovasileva triaged this task as High priority.Sep 6 2016, 4:27 PM
ovasileva added a subtask: T144047: Add support for enabling Related Articles on mobile web stable channel.
MBinder_WMF set the point value for this task to 1.Sep 6 2016, 4:31 PM
MBinder_WMF added a project: Reading-Web-Sprint-81-We-suck-at-coming-up-with-sprint-names.
MBinder_WMF moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-81-We-suck-at-coming-up-with-sprint-names board.
MBinder_WMF moved this task from Ready for Signoff to To Do on the Reading-Web-Sprint-81-We-suck-at-coming-up-with-sprint-names board.
ovasileva moved this task from Incoming to Product Owner Backlog on the Web-Team-Backlog board.Sep 6 2016, 4:40 PM
ovasileva moved this task from Product Owner Backlog to 2016-17 Q2 on the Web-Team-Backlog board.Sep 8 2016, 6:10 PM
ovasileva moved this task from 2016-17 Q2 to 2016-17 Q1 on the Web-Team-Backlog board.Sep 13 2016, 12:44 PM
ovasileva edited projects, added Reading-Web-Sprint-82-Xpect-Rspec; removed Reading-Web-Sprint-81-We-suck-at-coming-up-with-sprint-names.Sep 20 2016, 5:26 PM
ovasileva added a subscriber: dr0ptp4kt.Sep 21 2016, 4:24 PM

@dr0ptp4kt - we were discussing that we should probably inform ops of the change before moving to stable - what would be the best channel to do that?

ovasileva moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-82-Xpect-Rspec board.Sep 21 2016, 4:24 PM
dr0ptp4kt added subscribers: elukey, BBlack.Sep 21 2016, 5:04 PM

@ovasileva, giving @BBlack @elukey from TechOps a heads up here. @BBlack, @elukey: this is a follow up from T126455#2572077 - now we're close to putting it on the really highly visited wikis.

dr0ptp4kt added a subscriber: EBernhardson.Sep 21 2016, 5:05 PM

Additionally, looping in @EBernhardson from Discovery, as this uses the morelike query as I recall.

EBernhardson added a comment.Sep 21 2016, 5:07 PM

things should be fine from our end, but i will keep any eye on our load graphs and morelike qps. Is there a more specific time when i should expect to start seeing the increased load?

ovasileva added a comment.Sep 21 2016, 5:30 PM

@EBernhardson: We're expecting to move to stable on all but the top 6 wikipedias during the week of Oct 3. Will probably begin with the top 6 starting about two/three weeks later, most likely 1-2 per sprint.

ovasileva updated the task description. (Show Details)Sep 21 2016, 5:30 PM
ovasileva added a subtask: T145442: Move footer changes to stable.Sep 26 2016, 4:46 PM
Jdlrobson moved this task from To Do to Blocked Externally on the Reading-Web-Sprint-82-Xpect-Rspec board.Sep 26 2016, 4:47 PM
MBinder_WMF moved this task from 2016-17 Q1 to 2016-17 Q2 on the Web-Team-Backlog board.Sep 26 2016, 5:45 PM
ovasileva updated the task description. (Show Details)Sep 29 2016, 11:44 AM
ovasileva moved this task from Blocked Externally to To Do on the Reading-Web-Sprint-82-Xpect-Rspec board.Oct 3 2016, 11:03 AM
• Jhernandez closed subtask T144047: Add support for enabling Related Articles on mobile web stable channel as Resolved.Oct 3 2016, 11:37 AM
Jdlrobson moved this task from To Do to Blocked Externally on the Reading-Web-Sprint-82-Xpect-Rspec board.Oct 3 2016, 4:45 PM
Jdlrobson subscribed.

Dependencies still need resolving...

Jdlrobson mentioned this in T147217: Large gap left in footer on pages with no related articles.Oct 3 2016, 6:16 PM
Jdlrobson added a comment.Oct 3 2016, 7:20 PM

@ovasileva you may want to consider moving this to next sprint and pulling a new task in. T144579 is unlikely to get fixed before the next branch cut. Not sure if T147217 is a blocker but that could be fixed in its place.

Jdlrobson moved this task from Blocked Externally to Doing on the Reading-Web-Sprint-82-Xpect-Rspec board.Oct 3 2016, 9:04 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-82-Xpect-Rspec board.Oct 3 2016, 9:15 PM
gerritbot subscribed.Oct 3 2016, 9:16 PM

Change 313906 had a related patch set uploaded (by Jdlrobson):
Enable RelatedArticles on Minerva skin for all but top 6 wikis

https://gerrit.wikimedia.org/r/313906

gerritbot added a project: Patch-For-Review.Oct 3 2016, 9:16 PM
ovasileva added a comment.Oct 4 2016, 12:25 PM

I think it makes most sense to line up T147217: Large gap left in footer on pages with no related articles and T144579: Beta footer appears obscured on diff pages for next sprint and go as planned. Let's discuss further during standup

phuedx assigned this task to Jdlrobson.EditedOct 5 2016, 9:22 AM
phuedx subscribed.

Assigning to @Jdlrobson as he submitted rOMWCa5494bfe0aa9: Enable RelatedArticles on Minerva skin for all but top 6 wikis.

gerritbot added a comment.Oct 6 2016, 11:03 PM

Change 313906 merged by jenkins-bot:
Enable RelatedArticles on Minerva skin for all but top 6 wikis

https://gerrit.wikimedia.org/r/313906

gerritbot added a comment.Oct 6 2016, 11:13 PM

Change 314627 had a related patch set uploaded (by Jdlrobson):
Merge config declarations

https://gerrit.wikimedia.org/r/314627

gerritbot added a comment.Oct 6 2016, 11:16 PM

Change 314627 merged by jenkins-bot:
Merge config declarations

https://gerrit.wikimedia.org/r/314627

Stashbot subscribed.Oct 6 2016, 11:23 PM

Mentioned in SAL (#wikimedia-operations) [2016-10-06T23:23:15Z] <dereckson@tin> Synchronized wmf-config/InitialiseSettings.php: Enable RelatedArticles on Minerva skin for all but top 6 wikis (T144812) (duration: 00m 50s)

EBernhardson added a comment.Oct 6 2016, 11:32 PM

so far no big deal on the search api's, that deployment looks to have increased load by about 40qps,

Jdlrobson moved this task from Code Review to Needs QA on the Reading-Web-Sprint-82-Xpect-Rspec board.Oct 6 2016, 11:48 PM
ovasileva edited projects, added Reading-Web-Sprint-83-Y?; removed Reading-Web-Sprint-82-Xpect-Rspec.Oct 11 2016, 4:07 PM
ovasileva moved this task from Needs Analysis to Needs QA on the Reading-Web-Sprint-83-Y? board.Oct 11 2016, 4:36 PM
MBinder_WMF added a project: Reading-Web-Sprint-82-Xpect-Rspec.Oct 11 2016, 4:40 PM
Jdlrobson removed a project: Patch-For-Review.Oct 11 2016, 8:45 PM
Nicholas.tsg subscribed.EditedOct 11 2016, 11:06 PM

This appears to be working as expected, since I'm testing many QA credentials, I'll just attach a few below as example that this is fixed.

iOS 9 Safari (Hungarian) = Related Pages appears
Samsung Galaxy SIII (Android 4.x) - Chrome, Portuguese = Related Pages appears
Samsung Galaxy SIII (Android 4.x) - Web Browser, Spanish = NO Related Pages as expected on steps 1 and 3

iOS 9 Safari (Hungarian).PNG (2×1 px, 422 KB)

Samsung Galaxy SIII (Android 4.x) - Chrome, Hungarian.png (1×720 px, 155 KB)

Samsung Galaxy SIII (Android 4.x) - Web Browser, Spanish.png (1×720 px, 100 KB)

Nicholas.tsg moved this task from Needs QA to Ready for Signoff on the Reading-Web-Sprint-83-Y? board.Oct 11 2016, 11:08 PM
ovasileva closed this task as Resolved.Oct 12 2016, 9:09 AM

looks good!

ovasileva closed subtask T145442: Move footer changes to stable as Resolved.Oct 13 2016, 8:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL