"MediaWiki:Echo-email-html-footer-with-link" should support {{GENDER}}
Closed, ResolvedPublic
Actions

Description

MediaWiki:Echo-email-html-footer-with-link should have a parameter that indicates the username of the reader. This is important because in some languages the email should be written in accordance with the gender of the reader.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add GENDER support to a few Echo messages	mediawiki/extensions/Echo	master	+9 -8
	Add GENDER support to a few Echo messages	mediawiki/extensions/Echo	master	+9 -8

Customize query in gerrit

Related Objects

Mentioned In: T2582: Remind me of this article in X days

Event Timeline

Guycn2 created this task.Sep 12 2016, 7:04 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 12 2016, 7:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Aklapper added a parent task: T32443: [DO NOT USE] GENDER (tracking) [superseded by #Gender-Support].Sep 12 2016, 8:25 PM

Quiddity added projects: I18n, good first task.Sep 12 2016, 9:17 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptSep 12 2016, 9:17 PM

• jmatazzoni edited projects, added Collab-Team-Q1-July-Sep-2016; removed Collaboration-Team-Triage.Sep 12 2016, 10:15 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collab-Team-Q1-July-Sep-2016 board.

• Mattflaschen-WMF mentioned this in T2582: Remind me of this article in X days.Sep 22 2016, 2:24 AM

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed Collab-Team-Q1-July-Sep-2016.Oct 4 2016, 10:44 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Oct 4 2016, 10:51 PM

Change 314686 had a related patch set uploaded (by Mounicamergify):
Add GENDER support to echo-email-html-footer-with-link

https://gerrit.wikimedia.org/r/314686

gerritbot added a project: Patch-For-Review.Oct 7 2016, 1:20 PM

Looking at i18n/en.json:

"echo-email-footer-default-html": "To control which emails we send you, <a href=\"$2\" style=\"text-decoration:none; color: #3868B0;\">check your preferences</a>.<br />\n$1",
"echo-email-footer-default": "$2\n\nTo control which emails we send you, check your preferences:\n{{canonicalurl:{{#special:Preferences}}#mw-prefsection-echo}}\n\n$1",
"echo-email-plain-footer": "To control which emails we send you, check your preferences:",
"echo-email-html-footer-preference-link-text": "check your preferences",
"echo-email-html-footer-with-link": "To control which emails we send {{GENDER:$3|you}}, $1.",

there are even more messages which could benefit from the same changes. But I'm not sure whether all of them are used...

• jmatazzoni edited projects, added Collaboration-Team-Triage; removed Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016).Nov 1 2016, 8:08 PM

• jmatazzoni moved this task from Untriaged to Medium-Term Interest on the Collaboration-Team-Triage board.

In T145439#2702270, @matej_suchanek wrote:

Looking at i18n/en.json:

"echo-email-footer-default-html": "To control which emails we send you, <a href=\"$2\" style=\"text-decoration:none; color: #3868B0;\">check your preferences</a>.<br />\n$1",
"echo-email-footer-default": "$2\n\nTo control which emails we send you, check your preferences:\n{{canonicalurl:{{#special:Preferences}}#mw-prefsection-echo}}\n\n$1",
"echo-email-plain-footer": "To control which emails we send you, check your preferences:",
"echo-email-html-footer-preference-link-text": "check your preferences",
"echo-email-html-footer-with-link": "To control which emails we send {{GENDER:$3|you}}, $1.",

there are even more messages which could benefit from the same changes. But I'm not sure whether all of them are used...

Hmm... I'll go through to check for additional messages.
I will mentor this in Google-Code-In-2016
So, even if they aren't very used often. It's should lengthen the task a bit. It really easy, if you're acquainted with the workflow.

Nemo_bis triaged this task as Medium priority.Nov 6 2016, 12:18 PM

If someone picks up this task, note that a patch (that needs improvement) already exists. See https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29

In T145439#2775091, @Aklapper wrote:

If someone picks up this task, note that a patch (that needs improvement) already exists. See https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29

Okay, I'll keep that in mind.

Imported as https://codein.withgoogle.com/tasks/5639421642670080/

I amended the patch to support GENDER for the messages that I could. I think echo-email-footer-default and echo-email-footer-default-html are no longer being used. If so, could I remove them? @Catrope who did you say to ask to make sure the messages weren't being used?