⚓ T146257 Create objectcache/BagOStuff library

Status	Assigned	Task
Open	None	T146257 Create objectcache/BagOStuff library
Resolved	Legoktm	T146256 Move WaitConditionLoop to a separate library
Resolved	Legoktm	T146258 Create ScopedCallback library
Resolved	None	T147167 Create separate ObjectFactory library

Legoktm created this task.Sep 21 2016, 5:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2016, 5:55 AM

Legoktm added a subtask: T146256: Move WaitConditionLoop to a separate library.Sep 21 2016, 5:58 AM

I submitted https://gerrit.wikimedia.org/r/311921 to drop the Wikimedia\Assert dependency.

Legoktm created subtask T146258: Create ScopedCallback library.Sep 21 2016, 6:33 AM

Legoktm updated the task description. (Show Details)Sep 21 2016, 7:45 AM

Legoktm closed subtask T146258: Create ScopedCallback library as Resolved.Sep 29 2016, 10:39 PM

@aaron, do you think we're ready to start doing this? How do we want to handle the ObjectFactory dependency?

In T146257#2682140, @Legoktm wrote:

How do we want to handle the ObjectFactory dependency?

The easiest way would probably be to move ObjectFactory to a tiny library.

Legoktm mentioned this in T147167: Create separate ObjectFactory library.Oct 3 2016, 1:42 AM

Legoktm created subtask T147167: Create separate ObjectFactory library.

Huji reopened subtask T146258: Create ScopedCallback library as Open.Oct 3 2016, 7:12 PM

Legoktm closed subtask T146258: Create ScopedCallback library as Resolved.Oct 3 2016, 8:30 PM

bd808 mentioned this in T130528: RFC: PSR-6 Cache interface in Mediawiki core.Feb 7 2017, 4:36 PM

Krinkle triaged this task as Low priority.Apr 7 2017, 10:55 PM

Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.

Krinkle moved this task from Untriaged to To Do on the Librarization board.Jan 26 2018, 7:47 PM

Legoktm closed subtask T147167: Create separate ObjectFactory library as Resolved.Feb 10 2018, 6:54 AM

Krinkle updated the task description. (Show Details)Feb 10 2018, 6:57 AM

This would be great and would allow libraries such as https://github.com/addshore/psr-6-mediawiki-bagostuff-adapter to pull in the caching library for use during tests, rather than just missing the requirement entirely (as the only thing to require right now would be the whole of core)

Addshore added a subtask: T110022: Move HTTP-related code from MW to its own library.Jul 12 2018, 1:35 PM

Addshore added a project: User-Addshore.Jul 12 2018, 3:02 PM

Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.

We could move forward with this just excluding RESTBagOStuff for now

Krinkle removed a subtask: T110022: Move HTTP-related code from MW to its own library.Dec 10 2018, 4:35 PM

Removing the T110022 sub-task because creation a the library isn't blocked on having our HTTP abstraction published. Nothing in the relevant interfaces and utilities here uses HTTP functions. There's merely one BagOStuff implementation that MediaWiki has (RESTBagOStuff) that uses HTTP, which doesn't need to be in the library (and for many years, wasn't in core, either).

It's perfectly alright to leave that out of the initial publication library. Regardless of if and when we add it to the library, consumers of the library can and should be able at all times to make their own implementations and sub classes on top the library. This would effectively be an example of that within MediaWiki. (We did the same with includes/db/Oracle, which still remains to this date a MW-only implementation.)

Krinkle updated the task description. (Show Details)Dec 10 2018, 4:41 PM

So is anything other than EventRelayer blocking this?

Nope. What do you want to call it? ObjectCache or BagOStuff?

Change 490963 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] objectcache: remove EventRelayer dependency from WANObjectCache

https://gerrit.wikimedia.org/r/490963

gerritbot added a project: Patch-For-Review.Feb 16 2019, 7:19 AM