When Mapbox JS client lib supports it, we should migrate to leaflet 1.x.
This is different from T147361, which is about updating the Kartotherian service's static resources.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Upgrade mapbox.js to v3.0.1 (upgrade leaflet to 1.0.2) | mediawiki/extensions/Kartographer | master | +9 K -5 K |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Mooeypoo | T140209 Don't show "hand" mouse icon on unclickable objects | |||
| Resolved | TheDJ | T147347 Migrate Kartographer to Leaflet 1.x | |||
| Resolved | TheDJ | T162973 Add support for behavior: url(#default#behaviorName) |
Event Timeline
Comment Actions
Change 317546 had a related patch set uploaded (by JGirault):
WIP: Upgrade mapbox.js to v3.0 (upgrade leaflet to 1.0)
Comment Actions
@MaxSem any idea how to fix the failing phpunit tests?
https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-jessie/557/console
22:07:51 There was 1 failure:
22:07:51
22:07:51 1) ResourcesTest::testFileExistence with data set #602 ('/home/jenkins/workspace/mwext...lt#VML', 'mapbox', '/home/jenkins/workspace/mwext...lt#VML')
22:07:51 File '/home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/Kartographer/lib/mapbox/#default#VML' referenced by 'mapbox' must exist.
22:07:51 Failed asserting that file "/home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/Kartographer/lib/mapbox/#default#VML" exists.
22:07:51
22:07:51 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/tests/phpunit/structure/ResourcesTest.php:23
22:07:51 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:400
22:07:51 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/maintenance/doMaintenance.php:111I think it fails because of this line shape.style.behavior = 'url(#default#VML)'; in mapbox-lib.js ....
Help appreciated 😝
Comment Actions
I mean even if there's no bug with MB, we could still alter it to avoid triggering the failure. LMK if my help needed with core:)
Comment Actions
Tested after rebase, and it seems to me that all features work . We only need to make CI tests pass.
Comment Actions
Looks like there are only tests to fix - moving off the sprint board as the Discovery team won't be able to finish this work at this time.
Comment Actions
retested this and still seems to work. Testcases are now OK, I think we can merge this.
Checked with @debt before merging.
Comment Actions
Change 317546 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Upgrade mapbox.js to v3.0.1 (upgrade leaflet to 1.0.2)
Comment Actions
I recently implemented a leaflet+vega integration, which allows any vega graph to be drawn on top of a map. Once Vega 3 is reviewd (T172938), it can be added to Kartographer. This would solve many wikivoyage requests too - like having unlimited number of data points on a map.