Not Found Error
in /srv/mediawiki/php-1.28.0-wmf.23/extensions/MobileFrontend/includes/MobileFormatter.php
on line 229
View in logstash from start of wmf.23 going to production:
https://logstash.wikimedia.org/goto/50127b6b08cf347fe165c3763fe37143
1,339 warnings since the start of wmf.23 (until now, of course).
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T147641 [EPIC] Improve top of the article user experience - mobile | |||
| Resolved | None | T145216 MobileFormatter should relocate first paragraph ahead of infobox | |||
| Resolved | PRODUCTION ERROR | • bmansurov | T149389 Not Found Error in MobileFormatter |
See http://php.net/manual/en/domnode.insertbefore.php#refsect1-domnode.insertbefore-errors for more detail on the error.
The problematic line is:
$leadSectionBody->insertBefore( $firstP, $infoboxAndParagraphs->item( 0 ) );
This error is raised if "refnode is not a child of this node."
"ref node" is $infoboxAndParagraphs->item( 0 ) which should be an infobox according to the if statement above. So why would "refnode" not be a child of leadSectionBody?
I haven't been able to replicate it yet, but I discovered T149561 while debugging which may be related.
Change 318964 had a related patch set uploaded (by Phuedx):
WIP: Test case for T149389
Change 318978 had a related patch set uploaded (by Bmansurov):
MF Beta: Don't move first paragraph before infobox
Change 318978 merged by jenkins-bot:
MF Beta: Don't move first paragraph before infobox
Mentioned in SAL (#wikimedia-operations) [2016-10-31T23:46:51Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:318978|MF Beta: Do not move first paragraph before infobox (T145216) (T149389)]] (duration: 00m 46s)
Change 318964 merged by jenkins-bot:
Only consider immediate descendant infoboxes while moving first paragraph
The feature has been disabled and the error has since been fixed.
@bmansurov: I do think we should investigate those pages whose infoboxes are wrapped in one or more containers. Should we create a task for temporarily adding logging?
2 because of the SWAT deploy, understanding the error – "Not Found Error" is very descriptive… – creating a test case and making it pass /cc @bmansurov @MBinder_WMF
w
Yes, I think we should investigate. I am not sure about the best approach those. Do you think EL is the way to go? Or should we analyze the templates themselves as you suggested somewhere else? It's not clear to me if we can only record one event per page. I'd like to avoid a situation where we receive the same event multiple times for a given page.