Page MenuHomePhabricator

Notify a user if their edit to a wikidata description gets reverted
Closed, ResolvedPublic5 Estimated Story Points

Description

Send a system notification to the user if their wikidata description gets reverted.

The notification includes:

  • Icon - indicating the edit was reverted
  • Notification title - "Reverted edit"
  • Timestamp
  • Notification detail text - "The edit you made to <Article title> was reverted by <User name>"
  • Action - "View edit history"

(Initially, this will take the user to the edit history page in the browser)

Mock added to Invision:
https://wikimedia.invisionapp.com/share/W79AYFHTK#/screens/204505436

Event Timeline

Was this task originally slated for the MVP / quarterly goal? Should this have the Android-app-goals-2016-Oct-Dec-Q2 tag?

Change 325627 had a related patch set uploaded (by Dbrant):
Echo notifications for description edits.

https://gerrit.wikimedia.org/r/325627

Change 325627 merged by jenkins-bot:
Echo notifications for description edits.

https://gerrit.wikimedia.org/r/325627

@Dbrant – are there particular articles and descriptions that can be used to test revert notifications?

@RHo Wikidata has a sandbox-type page, but the corresponding Wikipedia article is outside the main namespace, so we don't allow editing its description from the app.
What you can do is:

  • Log in to the app
  • Log in to Wikidata on desktop (using the same account) and edit the description of the above sandbox page
  • Under a different account, revert the edit that you made
  • The app should receive a revert notification

hi @Dbrant – I just tried this twice and no notification message was shown... Is there another article I can try this on or perhaps a different method?

@Dbrant – nvmd, received the notification today.

A few visual polish comments:

  • Notification
    • Update the revert icon to use the "ic_restore_page" icon instead of current rotate left icon
    • Per mock, add 'MORE INFO' as another sub-action for users to see the dialog with info as to why their notification was reverted:

pasted_file (298×708 px, 28 KB)

  • Can we add incorporate styling to the message per mocks so that the article name has Medium font weight (and without quotation marks), and the user who reverted the edit in italics?
  • Dialog
    • The content text in the dialog should use the subhead style which is font-size 16sp and leading 24dp (slightly larger than is shown)
    • Content text also looks less indented than expected (should be 24dp from left of dialog, as per the title)
    • Bullet point text should be wholly indented from the bullet
    • Can we update the last link to be "edit history" rather than "history of edits"?

pasted_file (820×694 px, 112 KB)

Also, I was unable to confirm that the dialog appears over the corresponding article since the sandbox test page doesn't load in the app so I was only seeing the following when loaded:

Screenshot_1485952447.png (1×1 px, 55 KB)

  • Per mock, add 'MORE INFO' as another sub-action for users to see the dialog with info as to why their notification was reverted:

pasted_file (298×708 px, 28 KB)

The "view edit history" sub-action has since been removed. Do we want to Add "more info" back as a sub-action button, or just leave as it currently is since tapping the notification already leads to the dialog?

Change 337899 had a related patch set uploaded (by Mholloway):
Tweak design of description revert notification and help dialog

https://gerrit.wikimedia.org/r/337899

@Mholloway - let's just leave the notification as is without the redundant 'more info'. Thanks!

Change 338278 had a related patch set uploaded (by Mholloway):
Update revert help dialog styling

https://gerrit.wikimedia.org/r/338278

Change 337899 merged by jenkins-bot:
Update revert notification styling

https://gerrit.wikimedia.org/r/337899

Change 338278 merged by jenkins-bot:
Update revert help dialog styling

https://gerrit.wikimedia.org/r/338278