Page MenuHomePhabricator

Improve intersection of transcluded sections and protection
Open, MediumPublic

Description

On a protected page, no section edit links are shown, even for sections that are transcluded from (unprotected) templates. This is quite bad on "discussion overview" pages like commons' deletion page (see url in the summary): the overview page being protected causes non-admins to have a hard time to find a way to edit individual discussions.

This is probably caused by two rules interacting: If sections are transcluded from a template, the edit links on those sections point to the template. And if a page is protected, no section edit links are show. Each is sane enough, but the check if a section edit link is to be shown must be done for the actual target of the edit link for each section, instead for the entire page the linsk are shown on.

This is the reverse of Bug 6089 ("Section edit button shows up for transcluded protected page"), a fix should probably address both issues.


Version: 1.12.x
Severity: normal
URL: http://commons.wikimedia.org/wiki/COM:DEL

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:03 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz13079.
bzimport added a subscriber: Unknown Object (MLST).
daniel created this task.Feb 20 2008, 12:16 AM
IAlex added a comment.Jul 29 2008, 5:34 PM

fixed in r38196.

IAlex added a comment.Mar 30 2010, 3:37 PM
  • Bug 22917 has been marked as a duplicate of this bug. ***
IAlex added a comment.Mar 30 2010, 3:37 PM

Reopening, was reverted in r38208.

Izno added a comment.Nov 6 2018, 11:36 PM
This comment was removed by Izno.
Ammarpad renamed this task from no edit links for transcluded sections on protected pages to Improve intersection of transcluded sections and protection.Apr 28 2020, 7:46 AM
Ammarpad added a subscriber: bzimport.

Change 592932 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Improve interaction of transclusion, section editlink and protection

https://gerrit.wikimedia.org/r/592932

Ammarpad raised the priority of this task from Low to Medium.Apr 28 2020, 12:54 PM