The popup message when adding or removing pages from watchlists is no longer displaying the derived messages from MediaWiki:Addedwatchtext and MediaWiki:Removedwatchtext, but is instead entering plaintext.
Production impact seen on enwiki and dewiki. Able to reproduce on testwiki.
See enwiki discussion thread here: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Watchlist_star
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | Feature | None | T45512 Add wikitext bold and italic support to jqueryMsg | ||
| Declined | None | T153403 Watchlist toast no longer processing markup |
OK, the bug title confused me a little bit. The part that no longer works is the #ifeq parserfunction that you removed in https://en.wikipedia.org/w/index.php?title=MediaWiki:Addedwatchtext&diff=next&oldid=755098822 correct?
In rMW1f15d1d5828d: API: More i18n cleanup the message was split so there is now a separate -talk message, meaning that the parser function isn't needed. Plus the message formatting and parsing is now handled client side, so advanced wikitext constructs are no longer usable.
I think this task can/should be declined...if there's still a need to parse this message, we should integrate whatever functionality that is into MediaWiki itself.
@Legoktm it appears that both the use of #if statements, as well as wiki formatting like bold are no longer being processed.
It's intended that action=watch no longer returns UI messages, with the messages now being processed client-side using mediawiki.jqueryMsg.
It should be being loaded, mediawiki.page.watch.ajax now depends on it.
See T45512: Add wikitext bold and italic support to jqueryMsg for the wikitext bolding. #if and the like seem unlikely to be added to jqueryMsg, but if you want you could file a task requesting it.
Sounds good to me.
@Xaosflux what part of the message needs to be bolded? We can just implement that in MediaWiki itself.
I suppose whatever parts the local communities want. If devs are pushing that only plain text and the variable will be supported for this interface then this (and the parent) should just be moved to won't fix.
It's not devs pushing for plain text, the point is that I'm trying to understand your use cases for needing to use bold or whatever other markup, and then I can help determining the best possible way to implement it. In general if a message customization isn't enwp-specific like bolding, or changing a message to use a different word for talk namespaces, then it should be upstreamed back into MediaWiki so all wiki communities can take advantage of it, and there's less possibility it'll break in the future like this one did.
I'm not sure what dewiki is trying to do, but its a mess to readers right now who are seeing this:
Auf der [[Spezial:Beobachtungsliste|Beobachtungsliste]] werden dir ab sofort Änderungen an der Seite {{{„|„}}}{{{1|$1}}}{{{“|“}}} und der zugehörigen Diskussionsseite angezeigt. Die Seite wird zudem in der [[Spezial:Letzte Änderungen|Liste der letzten Änderungen]] durch Fettschrift hervorgehoben. Weitere Informationen zur Funktion {{{„|„}}}Beobachten{{{“|“}}} finden sich unter [[Hilfe:Beobachtungsliste]].
I see in the browser's console
mediawiki.jqueryMsg: addedwatchtext: Parse error at position 101 in input: Auf der [[Spezial:Beobachtungsliste|Beobachtungsliste]] werden dir ab sofort Änderungen an der Seite {{{„|„}}}{{{1|$1}}}{{{“|“}}} und der zugehörigen Diskussionsseite angezeigt. Die Seite wird zudem in der [[Spezial:Letzte Änderungen|Liste der letzten Änderungen]] durch Fettschrift hervorgehoben.
Weitere Informationen zur Funktion {{{„|„}}}Beobachten{{{“|“}}} finden sich unter [[Hilfe:Beobachtungsliste]].
Position 101 is at the first "{{{". I have no idea why they have those in there, but it seems to work fine if all the template parameters are removed from the message (replaced with their default values).
It looks like the same kind of problem that VisualEditor suffered from a while ago.
https://de.wikipedia.org/wiki/MediaWiki_Diskussion:Editing#Parse_issue
https://de.wikipedia.org/w/index.php?title=MediaWiki:Editing&diff=119991205&oldid=111079668