Steps to reproduce:
Expected:
There should be the external link icon after the link.
Actual:
The icon is missing, as the .mw-body class is missing (https://phabricator.wikimedia.org/diffusion/SVEC/browse/master/components/externalLinks.less), other skins might require other classes.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add external classes to mw:ExtLinks in NWE preview | mediawiki/extensions/VisualEditor | master | +2 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Esanders | T153413 NWE: Icons after external links missing in preview | |||
| Resolved | Esanders | T155863 MediaWiki has "content" styles applying only inside .mw-body, making them not reusable |
Note that this styling is under mw-body, because external links are not only present inside content, but inside other parts of the UI as well. Applying mw-body to the fullscreen overlay of OOUI, seems to change the font-size, so it requires a bit of care to get just just right I suspect.
Note that just resolving T155863 won't fix this, as Parsoid's rendering (which is used for the preview) uses different HTML markup for external links, which doesn't match the CSS we have.
I plan on using the $('[rel="mw:ExtLink]').addClass('external') hack because T58756 has been unresolved for three and a half years.
Change 341204 had a related patch set uploaded (by esanders):
[mediawiki/extensions/VisualEditor] Add external classes to mw:ExtLinks in NWE preview
Change 341204 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Add external classes to mw:ExtLinks in NWE preview