Page MenuHomePhabricator

NewsletterContent: Return type for doLinkCacheQuery to be changed
Closed, ResolvedPublic

Description

This task requires you to install Newsletter extension.

Currently doLinkCacheQuery returns nothing, but it is supposed to return a string. This inconsistency should be removed.

Event Timeline

Devirk created this task.Dec 28 2016, 11:32 AM

What should be the return value? Currently, the only usage of this function (the function is private) doesn't use the return value at all. So, probably this task should request the change of the doc block (remove the return type) and not adding a return statement at all (as it isn't used).

Change 329510 had a related patch set uploaded (by MtDu):
Remove unnecessary doc for doLinkCacheQuery and fix a small typo

https://gerrit.wikimedia.org/r/329510

Florian closed this task as Resolved.Dec 28 2016, 9:38 PM
Florian assigned this task to MtDu.

Change 329510 merged by jenkins-bot:
Remove unnecessary doc for doLinkCacheQuery and fix a small typo

https://gerrit.wikimedia.org/r/329510

Qgil awarded a token.Jan 3 2017, 10:20 PM