MWContentSerializationException in Konkani Wikipedia (gomwiki)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Talk pages of user accounts created between 21 March 2016 and 4 January 2017 give the following error: "Fatal exception of type MWContentSerializationException"

For example, see https://gom.wikipedia.org/wiki/वापरपी_चर्चा:STACEY_MESQUITA

I suspect that this is related to T154623 and the activity in T131957 around 4-6 January 2017.

Spotted in production:

#0 /srv/mediawiki/php-1.30.0-wmf.1/includes/Revision.php(1100): Flow\Content\BoardContentHandler->unserializeContent(string, string)
#1 /srv/mediawiki/php-1.30.0-wmf.1/includes/Revision.php(1063): Revision->getContentInternal()
#2 /srv/mediawiki/php-1.30.0-wmf.1/includes/page/WikiPage.php(666): Revision->getContent(integer, NULL)
#3 /srv/mediawiki/php-1.30.0-wmf.1/extensions/Flow/includes/WorkflowLoaderFactory.php(77): WikiPage->getContent()
#4 /srv/mediawiki/php-1.30.0-wmf.1/extensions/Flow/includes/Actions/Action.php(105): Flow\WorkflowLoaderFactory->createWorkflowLoader(Title)
#5 /srv/mediawiki/php-1.30.0-wmf.1/extensions/Flow/includes/Actions/ViewAction.php(20): Flow\Actions\FlowAction->showForAction(string, OutputPage)
#6 /srv/mediawiki/php-1.30.0-wmf.1/extensions/Flow/includes/Actions/Action.php(50): Flow\Actions\ViewAction->showForAction(string)
#7 /srv/mediawiki/php-1.30.0-wmf.1/includes/MediaWiki.php(499): Flow\Actions\FlowAction->show()
#8 /srv/mediawiki/php-1.30.0-wmf.1/includes/MediaWiki.php(293): MediaWiki->performAction(Article, Title)
#9 /srv/mediawiki/php-1.30.0-wmf.1/includes/MediaWiki.php(862): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.30.0-wmf.1/includes/MediaWiki.php(523): MediaWiki->main()
#11 /srv/mediawiki/php-1.30.0-wmf.1/index.php(43): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Details

Subject	Repo	Branch	Lines +/-
Revert "Throw when unserializing invalid Flow workflow metadata JSON"	mediawiki/extensions/Flow	wmf/1.30.0-wmf.2	+5 -2
Revert "Throw when unserializing invalid Flow workflow metadata JSON"	mediawiki/extensions/Flow	wmf/1.30.0-wmf.4	+5 -2
Revert "Throw when unserializing invalid Flow workflow metadata JSON"	mediawiki/extensions/Flow	master	+5 -2

Customize query in gerrit

Related Objects

Mentioned In: T166100: MWContentSerializationException: Failed to decode blob. It should be JSON representing valid Flow metadata.
Mentioned Here: T166100: MWContentSerializationException: Failed to decode blob. It should be JSON representing valid Flow metadata.
T167198: Put Flow anti-corruption defense back in place
T154623: Workflow ID null for some user talk pages on gomwiki
T131957: NewUserMessage should handle Flow properly; affects gomwiki/Konkani Wikipedia and kabwiki

Event Timeline

The_Discoverer created this task.Jan 31 2017, 3:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2017, 3:56 PM

Aklapper added projects: Wikimedia-production-error, WMF-General-or-Unknown.Jan 31 2017, 9:24 PM

The_Discoverer updated the task description. (Show Details)Feb 1 2017, 2:18 PM

The_Discoverer updated the task description. (Show Details)Feb 2 2017, 3:55 PM

The_Discoverer added a subscriber: • Mattflaschen-WMF.

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Feb 8 2017, 10:46 PM

Change 357445 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/Flow@master] Revert "Throw when unserializing invalid Flow workflow metadata JSON"

https://gerrit.wikimedia.org/r/357445

gerritbot added a project: Patch-For-Review.Jun 6 2017, 8:32 PM

I apologize for this. We were trying to prevent future corruption, but unintentionally worsened the situation for the existing pages.

Please file such bugs (major user impact, e.g. pages completely inaccessible with exceptions) as Unbreak Now, to make sure we see them.

Jdforrester-WMF triaged this task as Unbreak Now! priority.Jun 6 2017, 8:43 PM

Jdforrester-WMF added a project: Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJun 6 2017, 8:43 PM

• Mattflaschen-WMF merged a task: T166100: MWContentSerializationException: Failed to decode blob. It should be JSON representing valid Flow metadata..Jun 6 2017, 8:52 PM

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added subscribers: • demon, Catrope.

So basically the plan is:

Immediate issue is fixed by making these invalid (created incorrectly by NewUserMessage) boards working blank boards: https://gerrit.wikimedia.org/r/357445 .
T131957: NewUserMessage should handle Flow properly; affects gomwiki/Konkani Wikipedia and kabwiki
T154623: Workflow ID null for some user talk pages on gomwiki (clean up existing corrupt pages)
T167198: Put Flow anti-corruption defense back in place

Change 357445 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Revert "Throw when unserializing invalid Flow workflow metadata JSON"

https://gerrit.wikimedia.org/r/357445

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 6 2017, 9:00 PM

Change 357500 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/Flow@wmf/1.30.0-wmf.2] Revert "Throw when unserializing invalid Flow workflow metadata JSON"

https://gerrit.wikimedia.org/r/357500

Change 357501 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/Flow@wmf/1.30.0-wmf.4] Revert "Throw when unserializing invalid Flow workflow metadata JSON"

https://gerrit.wikimedia.org/r/357501

Change 357501 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.30.0-wmf.4] Revert "Throw when unserializing invalid Flow workflow metadata JSON"

https://gerrit.wikimedia.org/r/357501

Change 357500 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.30.0-wmf.2] Revert "Throw when unserializing invalid Flow workflow metadata JSON"

https://gerrit.wikimedia.org/r/357500

Mentioned in SAL (#wikimedia-operations) [2017-06-06T23:58:23Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.4/extensions/Flow/includes/Content/BoardContentHandler.php: SWAT: [[gerrit:357501|Revert "Throw when unserializing invalid Flow workflow metadata JSON"]] T166100 T156813 (duration: 00m 45s)

Mentioned in SAL (#wikimedia-operations) [2017-06-06T23:59:43Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.2/extensions/Flow/includes/Content/BoardContentHandler.php: SWAT: [[gerrit:357500|Revert "Throw when unserializing invalid Flow workflow metadata JSON"]] T166100 T156813 (duration: 00m 43s)

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 7 2017, 12:00 AM

This is deployed.

We still need to do the rest of the list above (including T154623: Workflow ID null for some user talk pages on gomwiki), but there should be no user impact at the time being.

Please reopen (leaving as UBN) if there is any user impact.

• Mattflaschen-WMF closed this task as Resolved.Jun 7 2017, 12:17 AM

• Mattflaschen-WMF claimed this task.

• Mattflaschen-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.

Reedy removed a project: Patch-For-Review.May 17 2019, 9:42 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM