⚓ T158309 Consolidate table collapsing JavaScript

Subject	Repo	Branch	Lines +/-
Consolidate collapse table CSS and JavaScript	apps/android/wikipedia	master	+475 -366
Consolidate collapse table CSS	mediawiki/extensions/MobileApp	master	+2 -59
Hygiene: move collapseTables.getTableHeader to applib	apps/android/wikipedia	master	+70 -77

Status	Assigned	Task
Open	None	T163839 Phase one: consolidate the JavaScript transforms and associated CSS
Resolved	• Fjalapeno	T152991 Audit iOS, Android and Mobile Web HTML, CSS, and JS
Resolved	Mhurd	T155693 Audit JS and CSS in iOS App
Resolved	• Niedzielski	T155695 Audit JS and CSS in Android App
Resolved	• Niedzielski	T158309 Consolidate table collapsing JavaScript
Resolved	Mhurd	T158686 Integrate shared table collapsing js into iOS app
Resolved	• Niedzielski	T158687 Integrate shared table collapsing js into Android app
Invalid	Mhurd	T159183 Consolidate image overflow logic in applib
Resolved	Mhurd	T159193 Integrate consolidated image overflow logic into iOS app
Resolved	• Niedzielski	T159194 Integrate consolidated image overflow logic into Android app

• Niedzielski created this task.Feb 16 2017, 2:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2017, 2:31 PM

• Niedzielski claimed this task.Feb 16 2017, 2:31 PM

• Niedzielski added a parent task: T152991: Audit iOS, Android and Mobile Web HTML, CSS, and JS.

• Niedzielski updated the task description. (Show Details)

• Fjalapeno created subtask T158686: Integrate shared table collapsing js into iOS app.Feb 21 2017, 6:52 PM

• Fjalapeno created subtask T158687: Integrate shared table collapsing js into Android app.

• Niedzielski updated the task description. (Show Details)Feb 21 2017, 6:53 PM

• Fjalapeno added a project: Reading Epics (Platform JS CSS and HTML consolidation).Feb 21 2017, 6:54 PM

Dbrant moved this task from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.Feb 22 2017, 5:46 PM

Dbrant moved this task from Tech Debt Backlog to Android-app-release-v2.6.19x-Bermuda🌴 on the Wikipedia-Android-App-Backlog board.Feb 23 2017, 7:16 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴); removed Wikipedia-Android-App-Backlog.

• Niedzielski moved this task from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Feb 24 2017, 3:06 AM

Change 339808 had a related patch set uploaded (by Niedzielski):
Hygiene: move collapseTables.getTableHeader to applib

https://gerrit.wikimedia.org/r/339808

gerritbot added a project: Patch-For-Review.Feb 25 2017, 4:10 AM

• Niedzielski updated the task description. (Show Details)Feb 25 2017, 4:21 AM

• Mholloway subscribed.Feb 27 2017, 2:56 PM

• Niedzielski updated the task description. (Show Details)Feb 27 2017, 9:41 PM

@Niedzielski Oh, was your recommendation to have...

a single consolidation ticket per feature (i.e. "Consolidate table collapsing js") - these result in pr against applib
one ticket per platform for integration ("Integrate consolidated table collapsing into iOS app" and "Integrate consolidated table collapsing into Android app") - these result in pr against respective platform repo

@Mhurd, that sounds good to me! I've updated this ticket to remove the platform integration piece since that's covered by children tickets.

@Niedzielski mind if i update the titles of all 3 to reference "table collapsing"?

( i think that's where i got confused on https://github.com/wikimedia/wikipedia-ios/pull/1210 - based on title i scoped it to just adding the reference to applib to the package.json )

That's fine with me. Either of the following make sense to me:

Fix preexisting JSHint breakage
Add applib
Integrate first applib function (getTableHeader)

OR

Fix preexisting JSHint breakage
Add applib and integrate first applib function (getTableHeader)

I chose the latter since the library has no functional effect if it's not used but it also makes a lot of sense to make a foundational PR first (I just wasn't thinking).

Mhurd renamed this task from Consolidate collapsible element JavaScript to Consolidate table collapsing JavaScript.Feb 28 2017, 12:28 AM

No worries! I updated the titles. (and my PR to match)

Change 339808 merged by jenkins-bot:
Hygiene: move collapseTables.getTableHeader to applib

https://gerrit.wikimedia.org/r/339808

• JMinor closed subtask T158686: Integrate shared table collapsing js into iOS app as Resolved.Apr 11 2017, 10:39 PM

Change 349371 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[mediawiki/extensions/MobileApp@master] Consolidate collapse table CSS

https://gerrit.wikimedia.org/r/349371

Change 349373 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[apps/android/wikipedia@master] Consolidate collapse table CSS and JavaScript

https://gerrit.wikimedia.org/r/349373

• Niedzielski moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Apr 21 2017, 2:45 AM

• Niedzielski raised the priority of this task from Medium to High.May 2 2017, 10:59 PM

• Niedzielski added a project: wikimedia-page-library.

• Niedzielski added a parent task: T163839: Phase one: consolidate the JavaScript transforms and associated CSS.

• Niedzielski moved this task from Open to Phase One on the wikimedia-page-library board.May 3 2017, 10:13 PM

• Niedzielski edited projects, added wikimedia-page-library-tshirt; removed wikimedia-page-library.May 11 2017, 9:29 PM

Change 349371 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Consolidate collapse table CSS

https://gerrit.wikimedia.org/r/349371

Change 349373 merged by jenkins-bot:
[apps/android/wikipedia@master] Consolidate collapse table CSS and JavaScript

https://gerrit.wikimedia.org/r/349373

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 15 2017, 8:00 PM