Page MenuHomePhabricator
Create Task
Maniphest T161095

Uninitialized string offset warnings with HHVM 3.18 in LanguageAz.php and LanguageKk.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Currently we're running HHVM 3.12 in production, but we're in the process of deploying 3.18 (currently deployed in deployment-prep, mwdebug* and mw1261.

I had a look at HHVM errors logged and with 3.18 these errors are logged for Kazakh and Azerbaijani (the errors are no found in other servers, so this seems caused by changes in HHVM 3.18):

Mar 22 10:18:53 mw1261 hhvm: #012Notice: Uninitialized string offset: 0 in /srv/mediawiki/php-1.29.0-wmf.16/languages/classes/LanguageKk.php on line 394
Mar 22 10:18:53 mw1261 hhvm[19736]: [Wed Mar 22 10:18:53 2017] [hphp] [19736:7f6fb8bff700:1501:000002] [] \nNotice: Uninitialized string offset: 0 in /srv/mediawiki/php-\1.29.0-wmf.16/languages/classes/LanguageKk.php on line 394
Mar 22 10:20:11 mw1261 hhvm: #012Notice: Uninitialized string offset: 0 in /srv/mediawiki/php-1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm[19736]: [Wed Mar 22 10:20:11 2017] [hphp] [19736:7f6f77fff700:1583:000001] [] \nNotice: Uninitialized string offset: 0 in /srv/mediawiki/php-\1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm: #012Notice: Uninitialized string offset: 0 in /srv/mediawiki/php-1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm[19736]: [Wed Mar 22 10:20:11 2017] [hphp] [19736:7f6f77fff700:1583:000002] [] \nNotice: Uninitialized string offset: 0 in /srv/mediawiki/php-\1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm: #012Notice: Uninitialized string offset: 0 in /srv/mediawiki/php-1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm[19736]: [Wed Mar 22 10:20:11 2017] [hphp] [19736:7f6f77fff700:1583:000003] [] \nNotice: Uninitialized string offset: 0 in /srv/mediawiki/php-\1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm: #012Notice: Uninitialized string offset: 0 in /srv/mediawiki/php-1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm[19736]: [Wed Mar 22 10:20:11 2017] [hphp] [19736:7f6f77fff700:1583:000004] [] \nNotice: Uninitialized string offset: 0 in /srv/mediawiki/php-\1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm: #012Notice: Uninitialized string offset: 0 in /srv/mediawiki/php-1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm[19736]: [Wed Mar 22 10:20:11 2017] [hphp] [19736:7f6f77fff700:1583:000005] [] \nNotice: Uninitialized string offset: 0 in /srv/mediawiki/php-\1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36
Mar 22 10:20:11 mw1261 hhvm: #012Notice: Uninitialized string offset: 0 in /srv/mediawiki/php-1.29.0-wmf.16/languages/classes/LanguageAz.php on line 36

I've depooled mw1261 for now since I'm not fully sure whether that causes disruption for Kazakh and Azerbaijani Wikipedia. If these are just logspam, let me know and I can repool mw1261.

Details

SubjectRepoBranchLines +/-
[cirrus] enable more accurate regex timeoutoperations/mediawiki-configmaster+1 -0
Check for string initialization in lcfirst() for HHVM 3.18mediawiki/corewmf/1.29.0-wmf.17+1 -1
Check for string initialization in lcfirst() for HHVM 3.18mediawiki/coremaster+1 -1
Check for string initialization in ucfirst() to make HHVM 3.18 happymediawiki/corewmf/1.29.0-wmf.17+2 -2
Check for string initialization in ucfirst() to make HHVM 3.18 happymediawiki/corewmf/1.29.0-wmf.16+2 -2
Check for string initialization in ucfirst() to make HHVM 3.18 happymediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

MoritzMuehlenhoff created this task.Mar 22 2017, 10:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2017, 10:35 AM
Aklapper triaged this task as High priority.Mar 22 2017, 10:53 AM
Aklapper added projects: HHVM, MediaWiki-Internationalization.

https://phabricator.wikimedia.org/source/mediawiki/browse/wmf%252F1.29.0-wmf.16/languages/classes/LanguageAz.php;c6da77928c98fadad03ce505436f31cbb5e36a3c$36
https://phabricator.wikimedia.org/source/mediawiki/browse/wmf%252F1.29.0-wmf.16/languages/classes/LanguageKk.php;c6da77928c98fadad03ce505436f31cbb5e36a3c$394

In both cases it barks about:

public function ucfirst( $string ) {
    if ( $string[0] == 'i' ) {
        ...
    }
}

It does not bark about Tr, because https://phabricator.wikimedia.org/source/mediawiki/browse/wmf%252F1.29.0-wmf.16/languages/classes/LanguageTr.php;c6da77928c98fadad03ce505436f31cbb5e36a3c$40 actually has an additional check:

public function ucfirst( $string ) {
    if ( strlen( $string ) && $string[0] == 'i' ) {
        ...
    }
 }

And Kaa, for completeness, from https://phabricator.wikimedia.org/source/mediawiki/browse/wmf%252F1.29.0-wmf.16/languages/classes/LanguageKaa.php;c6da77928c98fadad03ce505436f31cbb5e36a3c$58 :

public function ucfirst( $string ) {
    if ( substr( $string, 0, 1 ) === 'i' ) {
        ...
    }
}
MoritzMuehlenhoff added a parent task: T158176: Build / migrate to HHVM 3.18.Mar 22 2017, 11:00 AM
MoritzMuehlenhoff mentioned this in T158176: Build / migrate to HHVM 3.18.
gerritbot subscribed.Mar 22 2017, 12:17 PM

Change 344120 had a related patch set uploaded (by Aklapper):
[mediawiki/core] Check for string initialization in ucfirst() to make HHVM 3.18 happy

https://gerrit.wikimedia.org/r/344120

gerritbot added a project: Patch-For-Review.Mar 22 2017, 12:17 PM
gerritbot added a comment.Mar 22 2017, 12:33 PM

Change 344120 merged by jenkins-bot:
[mediawiki/core] Check for string initialization in ucfirst() to make HHVM 3.18 happy

https://gerrit.wikimedia.org/r/344120

Nikerabbit removed a project: Patch-For-Review.Mar 22 2017, 12:57 PM
Nikerabbit subscribed.

I'm leaving this open in case someone is expected to do backports.

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MW-1.29-release-notes.Mar 22 2017, 1:00 PM
gerritbot added a comment.Mar 22 2017, 1:47 PM

Change 344141 had a related patch set uploaded (by Hashar; owner: Aklapper):
[mediawiki/core] Check for string initialization in ucfirst() to make HHVM 3.18 happy

https://gerrit.wikimedia.org/r/344141

gerritbot added a project: Patch-For-Review.Mar 22 2017, 1:47 PM

Change 344142 had a related patch set uploaded (by Hashar; owner: Aklapper):
[mediawiki/core] Check for string initialization in ucfirst() to make HHVM 3.18 happy

https://gerrit.wikimedia.org/r/344142

hashar added a parent task: T160549: MW-1.29.0-wmf.17 deployment blockers.Mar 22 2017, 1:49 PM
hashar added a project: Wikimedia-production-error.
hashar subscribed.

I am handling the backports to wmf.16 / wmf.17

hashar mentioned this in T160549: MW-1.29.0-wmf.17 deployment blockers.Mar 22 2017, 1:50 PM
gerritbot added a comment.Mar 22 2017, 3:30 PM

Change 344141 merged by jenkins-bot:
[mediawiki/core] Check for string initialization in ucfirst() to make HHVM 3.18 happy

https://gerrit.wikimedia.org/r/344141

gerritbot added a comment.Mar 22 2017, 3:30 PM

Change 344142 merged by jenkins-bot:
[mediawiki/core] Check for string initialization in ucfirst() to make HHVM 3.18 happy

https://gerrit.wikimedia.org/r/344142

Stashbot subscribed.Mar 22 2017, 3:33 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-22T15:33:45Z] <hashar@tin> Synchronized php-1.29.0-wmf.17/languages/classes/LanguageAz.php: Check for string initialization in ucfirst() to make HHVM 3.18 happy - T161095 (duration: 00m 59s)

Stashbot added a comment.Mar 22 2017, 3:34 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-22T15:34:47Z] <hashar@tin> Synchronized php-1.29.0-wmf.17/languages/classes/LanguageKk.php: Check for string initialization in ucfirst() to make HHVM 3.18 happy - T161095 (duration: 00m 54s)

Stashbot added a comment.Mar 22 2017, 3:36 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-22T15:36:29Z] <hashar> Deploying LanguageAz.php and LanguageKk.php hotfix for HHVM 3.18 on mwdebug* and mw1261 - T161095

Stashbot added a comment.Mar 22 2017, 3:40 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-22T15:40:34Z] <hashar@tin> Synchronized php-1.29.0-wmf.16/languages/classes/LanguageAz.php: Check for string initialization in ucfirst() to make HHVM 3.18 happy - T161095 (duration: 00m 48s)

Stashbot added a comment.Mar 22 2017, 3:41 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-22T15:41:32Z] <hashar@tin> Synchronized php-1.29.0-wmf.16/languages/classes/LanguageKk.php: Check for string initialization in ucfirst() to make HHVM 3.18 happy - T161095 (duration: 00m 44s)

hashar added a comment.Mar 22 2017, 3:47 PM

I have deployed the hotfix on both wmf versions. There is most probably some useless call to ucfirst('') somewhere in the code.

As for the sudden notices, I would guess that HHVM 3.12 was shallowing the notice. Zend throw the notice when the variable passed is an empty string as does HHVM 3.18.

https://3v4l.org/stcgS

<?php
// https://phabricator.wikimedia.org/T161095

$string = '';
$string[0];

Output for 5.6.15 - 5.6.30, hhvm-3.15.4 - 3.18.1, 7.0.0 - 7.1.3:

Notice: Uninitialized string offset: 0 in /in/stcgS on line 5

Output for hhvm-3.12.14




So yeah hhvm got aligned to match Zend behavior.



I am leaving the task open in case one want to investigate why we have ucfirst('') called.
hashar moved this task from Backlog to New features on the HHVM board.Mar 22 2017, 3:47 PM
ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)); removed MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)).Mar 22 2017, 4:00 PM
Stashbot added a comment.Mar 23 2017, 8:47 AM
Mentioned in SAL (#wikimedia-operations) [2017-03-23T08:47:46Z] <moritzm> repooled mw1261 now that T161095 is deployed
MoritzMuehlenhoff added a comment.Mar 23 2017, 2:06 PM
The ucfirst error is fixed, but when reviewing the error logs of mw1261 I noticed a very similar error also applying to Kazakh, it's essentially the same error, but for lcfirst() instead of ucfirst():



Mar 23 13:30:44 mw1261 hhvm: #012Notice: Uninitialized string offset: 0 in /srv/mediawiki/php-1.29.0-wmf.16/languages/classes/LanguageKk.php on line 411

Mar 23 13:30:44 mw1261 hhvm[19736]: [Thu Mar 23 13:30:44 2017] [hphp] [19736:7f6f81fff700:51142:000001] [] \nNotice: Uninitialized string offset: 0 in /srv/mediawiki/php-1.29.0-wmf.16/languages/classes/LanguageKk.php on line 411
gerritbot added a comment.Mar 24 2017, 2:21 PM
Change 344617 had a related patch set uploaded (by Hashar):

[mediawiki/core@master] Check for string initialization in lcfirst() for HHVM 3.18



https://gerrit.wikimedia.org/r/344617
gerritbot added a comment.Mar 24 2017, 2:23 PM
Change 344618 had a related patch set uploaded (by Hashar):

[mediawiki/core@wmf/1.29.0-wmf.17] Check for string initialization in lcfirst() for HHVM 3.18



https://gerrit.wikimedia.org/r/344618
gerritbot added a comment.Mar 25 2017, 1:03 AM
Change 344617 merged by jenkins-bot:

[mediawiki/core@master] Check for string initialization in lcfirst() for HHVM 3.18



https://gerrit.wikimedia.org/r/344617
ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)); removed MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)).Mar 25 2017, 2:00 AM
gerritbot added a comment.Mar 27 2017, 8:35 AM
Change 344618 merged by jenkins-bot:

[mediawiki/core@wmf/1.29.0-wmf.17] Check for string initialization in lcfirst() for HHVM 3.18



https://gerrit.wikimedia.org/r/344618
Stashbot added a comment.Mar 27 2017, 8:38 AM
Mentioned in SAL (#wikimedia-operations) [2017-03-27T08:38:16Z] <hashar@tin> Synchronized php-1.29.0-wmf.17/languages/classes/LanguageKk.php: Check for string initialization in lcfirst() for HHVM 3.18 - T161095 (duration: 00m 52s)
hashar added a comment.Mar 27 2017, 8:40 AM
LanguageKk:lcfirst() should be fine on mw1261 now.
ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)); removed MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)).Mar 27 2017, 9:00 AM
gerritbot added a comment.Mar 27 2017, 9:48 AM
Change 344922 had a related patch set uploaded (by DCausse):

[operations/mediawiki-config@master] [cirrus] enable more accurate regex timeout



https://gerrit.wikimedia.org/r/344922
Stashbot added a comment.Mar 27 2017, 1:22 PM
Mentioned in SAL (#wikimedia-operations) [2017-03-27T13:22:07Z] <moritzm> repooled mw1261 (now that fix for lcfirst() issue from T161095 is deployed)
gerritbot added a comment.Mar 27 2017, 1:22 PM
Change 344922 merged by jenkins-bot:

[operations/mediawiki-config@master] [cirrus] enable more accurate regex timeout



https://gerrit.wikimedia.org/r/344922
Stashbot added a comment.Mar 27 2017, 1:26 PM
Mentioned in SAL (#wikimedia-operations) [2017-03-27T13:26:44Z] <dereckson@tin> Synchronized wmf-config/CirrusSearch-common.php: [cirrus] enable more accurate regex timeout (T161095) (duration: 00m 44s)
MoritzMuehlenhoff mentioned this in T161520: HHVM 3.18 crashes when Cirrus tries to fetch another wiki config via maint script .Mar 27 2017, 2:49 PM
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Apr 6 2017, 7:02 PM
Krinkle closed this task as Resolved.Apr 10 2017, 11:36 PM
Krinkle claimed this task.
Reedy removed a project: Patch-For-Review.May 17 2019, 9:45 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL