Page MenuHomePhabricator
Create Task
Maniphest T164742

[Story] Add Form to list of Forms (persistent)
Closed, ResolvedPublic
Actions

Description

In T160524 we added support for adding Forms to a Lexeme. We now need to actually store the added Forms and keep them persistently.

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Allow empty FormSets with empty constructormediawiki/extensions/WikibaseLexememaster+18 -14
Make Lexeme constructor accept FormSet onlymediawiki/extensions/WikibaseLexememaster+44 -28
Reload page to test persistence in browser test.mediawiki/extensions/WikibaseLexememaster+3 -2
Add FormChanger to make "add form" feature actually workmediawiki/extensions/WikibaseLexememaster+329 -17
Add form API modulemediawiki/extensions/WikibaseLexememaster+466 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
daniel edited parent tasks, added: T160052: [Epic] Support for Forms; removed: T164743: [Story] Add Form to list of Forms (UI).Aug 21 2017, 4:45 PM
daniel removed subtasks: T165336: Make Lexeme implement EntityContainer, T165328: Allow entity sub-structures to be treated like entities (so called sub-entities)..Aug 21 2017, 5:08 PM
gerritbot subscribed.Sep 19 2017, 12:32 PM

Change 376704 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Add form API module

https://gerrit.wikimedia.org/r/376704

gerritbot added a project: Patch-For-Review.Sep 19 2017, 12:32 PM
thiemowmde mentioned this in rEWLEa379ad014627: [WIP] Add form API module.Sep 19 2017, 12:33 PM
gerritbot added a comment.Sep 19 2017, 12:33 PM

Change 378889 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Add FormChanger to make "add form" feature actually work

https://gerrit.wikimedia.org/r/378889

thiemowmde mentioned this in rEWLE12e4ed20e9a8: [WIP] Add FormChanger to make "add form" feature actually work.Sep 19 2017, 12:34 PM
• Aleksey_WMDE mentioned this in rEWLEbe55849e6561: [WIP] Add form API module.Sep 19 2017, 2:48 PM
• Aleksey_WMDE mentioned this in rEWLE1fad1b025ea9: [WIP] Add FormChanger to make "add form" feature actually work.
• Aleksey_WMDE mentioned this in rEWLE6b79cb931d9f: [WIP] Add FormChanger to make "add form" feature actually work.
• Aleksey_WMDE mentioned this in rEWLEd4df02cb86f4: [WIP] Add FormChanger to make "add form" feature actually work.Sep 19 2017, 2:55 PM
• Jonas mentioned this in rEWLE16267920a50c: [WIP] Add FormChanger to make "add form" feature actually work.Sep 19 2017, 3:33 PM
• Aleksey_WMDE mentioned this in rEWLE8662dd6b31f5: [WIP] Add form API module.Sep 19 2017, 4:03 PM
• Aleksey_WMDE mentioned this in rEWLEc270afe5b80e: [WIP] Add form API module.Sep 19 2017, 4:07 PM
• Jonas mentioned this in rEWLE1cdae8f6e1e2: Add form API module.Sep 20 2017, 11:07 AM
gerritbot added a comment.Sep 20 2017, 2:08 PM

Change 379233 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Reload page to test persistence in browser test.

https://gerrit.wikimedia.org/r/379233

Jakob_WMDE mentioned this in rEWLEce82c41b3103: Reload page to test persistence in browser test..Sep 20 2017, 2:09 PM
• Aleksey_WMDE mentioned this in rEWLEde4112988e43: Add form API module.Sep 21 2017, 11:15 AM
• Aleksey_WMDE mentioned this in rEWLEdee3e243624d: [WIP] Add FormChanger to make "add form" feature actually work.
• Aleksey_WMDE mentioned this in rEWLEf020b8edacd2: [WIP] Add FormChanger to make "add form" feature actually work.Sep 21 2017, 11:35 AM
• Aleksey_WMDE mentioned this in rEWLE7d80bb9cc5e4: Add form API module.Sep 21 2017, 11:41 AM
• Jonas mentioned this in rEWLE409ea6770bf9: Add FormChanger to make "add form" feature actually work.Sep 21 2017, 11:54 AM
• Aleksey_WMDE mentioned this in rEWLE61fdae14ffae: Add form API module.Sep 21 2017, 11:59 AM
• Aleksey_WMDE mentioned this in rEWLE5c4c59328e1d: Add form API module.Sep 21 2017, 3:27 PM
• Aleksey_WMDE mentioned this in rEWLEe03532b5f5d0: Add form API module.Sep 21 2017, 3:42 PM
• Aleksey_WMDE mentioned this in rEWLE070a2eccdfe9: Add FormChanger to make "add form" feature actually work.Sep 21 2017, 3:57 PM
• Aleksey_WMDE mentioned this in rEWLE59810248ae33: Reload page to test persistence in browser test..
• Jonas mentioned this in rEWLEb877d4e07dd2: Add FormChanger to make "add form" feature actually work.Sep 21 2017, 5:41 PM
• Aleksey_WMDE mentioned this in rEWLEf254a54b1c4a: Add form API module.Sep 22 2017, 11:44 AM
• Aleksey_WMDE mentioned this in rEWLEf72f176ef9ac: Add form API module.Sep 22 2017, 12:14 PM
• Aleksey_WMDE mentioned this in rEWLE1df83849a00f: Add form API module.
Jakob_WMDE mentioned this in rEWLEdc2302fa5645: Reload page to test persistence in browser test..Sep 26 2017, 11:17 AM
Jakob_WMDE mentioned this in rEWLE682b8c0cc756: Reload page to test persistence in browser test..Sep 26 2017, 11:19 AM
Jakob_WMDE mentioned this in rEWLEbb9c429148c2: Add FormChanger to make "add form" feature actually work.Sep 26 2017, 11:30 AM
Jakob_WMDE mentioned this in rEWLEdc812e6c4ae8: Add form API module.Sep 26 2017, 11:52 AM
Jakob_WMDE mentioned this in rEWLE55c544728e6b: Add FormChanger to make "add form" feature actually work.
Jakob_WMDE mentioned this in rEWLEeaf591623c19: Reload page to test persistence in browser test..Sep 26 2017, 11:57 AM
Jakob_WMDE mentioned this in rEWLEa79015c69e6f: Reload page to test persistence in browser test..Sep 26 2017, 12:50 PM
• Aleksey_WMDE mentioned this in rEWLE26bc0ac61bc8: Add form API module.Sep 27 2017, 3:12 PM
• Aleksey_WMDE mentioned this in rEWLE2b9f9278dbfa: Add form API module.Sep 27 2017, 3:21 PM
• Aleksey_WMDE mentioned this in rEWLE8747dd48ded4: Add form API module.Sep 28 2017, 12:03 PM
• Aleksey_WMDE mentioned this in rEWLE992960a1b8d1: Add form API module.Sep 28 2017, 12:11 PM
• Aleksey_WMDE mentioned this in rEWLEb01de8a82a9c: Add form API module.Sep 28 2017, 12:15 PM
gerritbot added a comment.Sep 28 2017, 3:59 PM

Change 376704 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add form API module

https://gerrit.wikimedia.org/r/376704

WMDE-leszek mentioned this in rEWLE0ddbf7890958: Add FormChanger to make "add form" feature actually work.Sep 29 2017, 7:30 AM
• Aleksey_WMDE mentioned this in rEWLEa50a1b8d5743: Add FormChanger to make "add form" feature actually work.Oct 1 2017, 4:26 PM
• Aleksey_WMDE mentioned this in rEWLE2cead71baaa5: Add FormChanger to make "add form" feature actually work.Oct 1 2017, 4:34 PM
WMDE-leszek mentioned this in rEWLE2ff377116737: Add FormChanger to make "add form" feature actually work.Oct 2 2017, 9:57 AM
• Aleksey_WMDE mentioned this in rEWLEecd4faf4d840: Add FormChanger to make "add form" feature actually work.Oct 2 2017, 10:42 AM
gerritbot added a comment.Oct 2 2017, 11:37 AM

Change 378889 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add FormChanger to make "add form" feature actually work

https://gerrit.wikimedia.org/r/378889

WMDE-leszek mentioned this in rEWLEf55d20b6a935: Reload page to test persistence in browser test..Oct 4 2017, 6:57 AM
gerritbot added a comment.Oct 5 2017, 1:57 PM

Change 379233 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Reload page to test persistence in browser test.

https://gerrit.wikimedia.org/r/379233

gerritbot added a comment.Oct 12 2017, 7:56 AM

Change 383790 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Relax Lexeme deserialization to not fail with $nextFormId = 1

https://gerrit.wikimedia.org/r/383790

thiemowmde mentioned this in rEWLE64ca9ce0d32b: Relax Lexeme deserialization to not fail with $nextFormId = 1.Oct 12 2017, 7:57 AM
thiemowmde assigned this task to • Aleksey_WMDE.Oct 12 2017, 8:10 AM
thiemowmde added a project: Wikidata-Former-Sprint-Board.
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
thiemowmde moved this task from consider for next sprint to in progress on the Wikidata board.
thiemowmde added subscribers: WMDE-leszek, • Jonas, Jakob_WMDE, Ladsgroup.
gerritbot added a comment.Oct 12 2017, 8:35 AM

Change 383793 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make Lexeme constructor accept FormSet only

https://gerrit.wikimedia.org/r/383793

thiemowmde mentioned this in rEWLE6ba6ca7169ae: Make Lexeme constructor accept FormSet only.Oct 12 2017, 8:36 AM
thiemowmde updated the task description. (Show Details)Oct 12 2017, 8:38 AM
thiemowmde mentioned this in rEWLE76d4c0960faa: Relax Lexeme deserialization to not fail with $nextFormId = 1.Oct 12 2017, 8:40 AM
gerritbot added a comment.Oct 12 2017, 9:15 AM

Change 383799 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make all getForms methods return FormSet instead of array

https://gerrit.wikimedia.org/r/383799

thiemowmde mentioned this in rEWLEb58c8806f9e0: Make all getForms methods return FormSet instead of array.Oct 12 2017, 9:17 AM
thiemowmde mentioned this in rEWLEe577eac2a88a: Make Lexeme constructor accept FormSet only.Oct 12 2017, 9:32 AM
thiemowmde mentioned this in rEWLE98aa39e2ffe9: Relax Lexeme deserialization to not fail with $nextFormId = 1.Oct 12 2017, 9:42 AM
thiemowmde mentioned this in rEWLE4e260c2b13f2: Make all getForms methods return FormSet instead of array.
thiemowmde mentioned this in rEWLEe7e60998e59f: Relax Lexeme deserialization to not fail with $nextFormId = 1.Oct 12 2017, 10:00 AM
thiemowmde mentioned this in rEWLEd9c24c62b606: Make Lexeme constructor accept FormSet only.Oct 12 2017, 10:29 AM
thiemowmde mentioned this in rEWLEdf619406c6c0: Relax Lexeme deserialization to not fail with $nextFormId = 1.
WMDE-leszek removed • Aleksey_WMDE as the assignee of this task.Oct 12 2017, 5:14 PM
WMDE-leszek added a subscriber: • Aleksey_WMDE.
thiemowmde mentioned this in rEWLEded045a6d00b: Make all getForms methods return FormSet instead of array.Oct 13 2017, 8:39 AM
thiemowmde mentioned this in rEWLEb0d907820740: Make all getForms methods return FormSet instead of array.Oct 13 2017, 12:34 PM
thiemowmde mentioned this in rEWLE16aa51f3b2f3: Make all getForms methods return FormSet instead of array.Oct 13 2017, 12:44 PM
thiemowmde mentioned this in rEWLEa9c64cb49176: Make all getForms methods return FormSet instead of array.Oct 13 2017, 1:49 PM
thiemowmde mentioned this in rEWLE1e3fe28dddf4: Make Lexeme constructor accept FormSet only.Oct 13 2017, 3:09 PM
thiemowmde mentioned this in rEWLEfe1248416fa5: Make Lexeme constructor accept FormSet only.Oct 16 2017, 12:11 PM
thiemowmde mentioned this in rEWLE035be060bb61: Make Lexeme constructor accept FormSet only.Oct 16 2017, 12:52 PM
gerritbot added a comment.Oct 16 2017, 12:56 PM

Change 384506 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Allow empty FormSets with empty constructor

https://gerrit.wikimedia.org/r/384506

thiemowmde mentioned this in rEWLE675b7effdf0f: Allow empty FormSets with empty constructor.Oct 16 2017, 12:57 PM
thiemowmde mentioned this in rEWLEffe060c40ac8: Relax Lexeme deserialization to not fail with $nextFormId = 1.
gerritbot added a comment.Oct 17 2017, 11:37 AM

Change 383793 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make Lexeme constructor accept FormSet only

https://gerrit.wikimedia.org/r/383793

thiemowmde mentioned this in rEWLEa6006aa80a08: Make all getForms methods return FormSet instead of array.Oct 17 2017, 11:41 AM
gerritbot added a comment.Oct 17 2017, 11:45 AM

Change 384506 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Allow empty FormSets with empty constructor

https://gerrit.wikimedia.org/r/384506

• Jonas updated the task description. (Show Details)Oct 19 2017, 10:04 AM
thiemowmde mentioned this in rEWLE99c8c0e3a3e1: Make all getForms methods return FormSet instead of array.Oct 19 2017, 4:50 PM
thiemowmde updated the task description. (Show Details)Oct 19 2017, 4:52 PM
thiemowmde mentioned this in rEWLEd926f3600418: Make all getForms methods return FormSet instead of array.Oct 20 2017, 10:03 AM
thiemowmde mentioned this in rEWLEc65d2e8e972b: Relax Lexeme deserialization to not fail with $nextFormId = 1.Oct 20 2017, 11:33 AM
thiemowmde mentioned this in rEWLEa843fe1afcd1: Make all getForms methods return FormSet instead of array.Oct 23 2017, 6:17 AM
thiemowmde updated the task description. (Show Details)Oct 23 2017, 9:29 AM
thiemowmde closed this task as Resolved.Oct 25 2017, 12:28 PM
thiemowmde removed a project: Patch-For-Review.
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
thiemowmde mentioned this in rEWLE839e5c249744: Update patch set 1.Jun 9 2018, 12:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL