Page MenuHomePhabricator
Create Task
Maniphest T165489

Make RevisionSlider usable for screenreader users
Open, LowPublic
Actions

Description

Issue
The RevisionSlider is not currently usable for screenreader or keyboard only users.

TODO:

  • The (un)collapsed status of the widget is not reflected in the dom (screenreader)
  • The pinning button has no label (screenreader)
  • The pinning button does not reflect it's state (it has an aria-checked attribute (on the wrong element ?) and it's always false (screenreader)
  • The prev/next pagers do not have labels. (Screenreader)
  • The help button does not listen to keyboard selection (enter/spacebar) (keyboard navigation)
  • There is no way to interact with the timeline (keyboard navigation)
  • The popups are not transparently read out
  • Structure and meaning of the timeline is not transparent to a screenreader

@Tobi_WMDE_SW and @WMDE-Fisch will work on this during the Vienna Hackathon. More people are welcome!

Helpful links:
mediawiki's accessibility guide for developers

Links to the aria standard for reader annotations:
https://www.w3.org/TR/wai-aria-practices/
https://www.w3.org/TR/wai-aria/states_and_properties
https://www.w3.org/TR/wai-aria/roles#childrenArePresentational

Background:
The RevisionSlider is an extension that adds a slider view to the diff page so that you can easily move between revisions.

Details

SubjectRepoBranchLines +/-
Improve support for screenreadersmediawiki/extensions/RevisionSlidermaster+37 -7
Disable the RevisionSlider for screenreadersmediawiki/extensions/RevisionSlidermaster+5 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheDJ created this task.May 16 2017, 12:48 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMay 16 2017, 12:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TheDJ updated the task description. (Show Details)May 16 2017, 3:35 PM
• Lea_WMDE triaged this task as High priority.May 16 2017, 3:35 PM
• Lea_WMDE subscribed.

Thanks for creating the ticket! We will definitely look into how to make this compatible this week.

• Lea_WMDE renamed this task from RevisionSlider is not usable for screenreader users to Make RevisionSlider usable for screenreader users.May 17 2017, 11:40 AM
• Lea_WMDE added a project: Wikimedia-Hackathon-2017.
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE moved this task from Backlog to Featured Projects on the Wikimedia-Hackathon-2017 board.
• Lea_WMDE added subscribers: WMDE-Fisch, Tobi_WMDE_SW.
TheDJ added a subscriber: Volker_E.May 17 2017, 11:49 AM

pinging @Volker_E as someone who also might be interested in this.

Tobi_WMDE_SW added a project: User-Tobi_WMDE_SW.May 17 2017, 12:07 PM
Tobi_WMDE_SW moved this task from Incoming to Backlog on the Revision-Slider board.May 17 2017, 1:05 PM
Volker_E added a comment.May 17 2017, 3:14 PM

Yup, I'm watching the Accessibility Phab board and just wanted to add, that I'm interested to help where possible at the Hackathon. :)

• Lea_WMDE awarded a token.May 17 2017, 3:16 PM
cmadeo subscribed.May 19 2017, 10:03 AM

Hi! I'd be happy to help with usability, testing and design.

WMDE-Fisch claimed this task.May 19 2017, 1:56 PM
WMDE-Fisch added a comment.May 19 2017, 2:02 PM

@TheDJ do you think that adding aria-label attributes to the relevant tags should be sufficient from your experience?

WMDE-Fisch added a subtask: T162119: Add keyboard shortcuts to move between revisions.May 19 2017, 3:14 PM
TheDJ added a comment.May 19 2017, 5:00 PM

@WMDE-Fisch actually, i'm not entirely sure how OOjs UI currently deals with this. In my personal view, a ButtonWidget should always have a label, and having an Icon only button is a styling problem that should be solved with a trait or something.

I doubt that's how it works atm however. @Volker_E ?

WMDE-Fisch added a comment.May 20 2017, 9:46 AM

@TheDJ yeah addressing that in OOjs UI is definitely needed here. But for the implementation it sill would be good to know what attribute is the best to choose here. That's the direction where my question was pointing at :-)

But looking at https://www.w3.org/TR/wai-aria-practices/#button I guess the answer is clearly "Yes to aria-label".

gerritbot subscribed.May 20 2017, 9:59 AM

Change 354649 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/RevisionSlider@master] Improve support for screenreaders

https://gerrit.wikimedia.org/r/354649

gerritbot added a project: Patch-For-Review.May 20 2017, 9:59 AM
WMDE-Fisch mentioned this in rERSL3aa5233d0d08: Improve support for screenreaders.May 20 2017, 10:00 AM
WMDE-Fisch mentioned this in rERSL6fbd43ce68ad: Improve support for screenreaders.May 20 2017, 3:37 PM
gerritbot added a comment.May 20 2017, 3:55 PM

Change 354722 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/RevisionSlider@master] Disable the RevisionSlider for screenreaders

https://gerrit.wikimedia.org/r/354722

WMDE-Fisch mentioned this in rERSLd5078b138e59: Disable the RevisionSlider for screenreaders.May 20 2017, 3:56 PM
WMDE-Fisch mentioned this in rERSL04e57eeb70c1: Improve support for screenreaders.May 20 2017, 3:58 PM
WMDE-Fisch mentioned this in rERSL2c730373df25: Disable the RevisionSlider for screenreaders.May 20 2017, 5:04 PM
WMDE-Fisch added a project: WMDE-TechWish.May 23 2017, 11:09 AM
WMDE-Fisch moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.
TheDJ moved this task from Unsorted to Aural / Screen readers on the Accessibility board.May 23 2017, 2:09 PM
WMDE-Fisch mentioned this in rERSL809db3b95dd3: Improve support for screenreaders.May 24 2017, 5:30 PM
WMDE-Fisch mentioned this in rERSL76196a880741: Improve support for screenreaders.May 24 2017, 5:46 PM
WMDE-Fisch mentioned this in rERSL3eab0e4648ca: Improve support for screenreaders.May 29 2017, 8:07 AM
WMDE-Fisch mentioned this in rERSLae96989d0ba9: Disable the RevisionSlider for screenreaders.Jun 6 2017, 8:28 AM
gerritbot added a comment.Jun 6 2017, 8:53 AM

Change 354722 merged by VolkerE:
[mediawiki/extensions/RevisionSlider@master] Disable the RevisionSlider for screenreaders

https://gerrit.wikimedia.org/r/354722

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 6 2017, 9:00 AM
Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Jun 6 2017, 10:10 AM
WMDE-Fisch mentioned this in rERSL5f8bf838497e: Improve support for screenreaders.Jun 12 2017, 9:16 AM
WMDE-Fisch created subtask T167768: Make RevisionSlider popups usable for screenreader users.Jun 13 2017, 8:44 AM
Tobi_WMDE_SW moved this task from Backlog to Doing on the Revision-Slider board.Jun 19 2017, 3:31 PM
gerritbot added a comment.Jun 27 2017, 11:23 AM

Change 354649 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Improve support for screenreaders

https://gerrit.wikimedia.org/r/354649

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)); removed MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 27 2017, 12:00 PM
WMDE-Fisch updated the task description. (Show Details)Jun 28 2017, 12:46 PM
WMDE-Fisch moved this task from Doing to Maintenance on the Revision-Slider board.Jun 28 2017, 1:02 PM
WMDE-Fisch removed projects: MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), WMDE-TechWish, Patch-For-Review.

Small update here:

The above patch addresses most of the mentioned minor problems. Some more work is needed to make the timeline and popups usable, see T167768.

For now we will keep the feature deactivated for screenreader users and use this ticket as overall tracking ticket for the topic.

• Lea_WMDE moved this task from Maintenance to Watching on the Revision-Slider board.Jul 4 2017, 1:50 PM
WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Aug 30 2017, 12:37 PM
TheDJ lowered the priority of this task from High to Low.Feb 5 2018, 4:19 PM

adjusting prio per work done and future work expected.

Gopavasanth closed subtask T162119: Add keyboard shortcuts to move between revisions as Resolved.Feb 9 2019, 3:20 PM
Tobi_WMDE_SW moved this task from Incoming to Next on the User-Tobi_WMDE_SW board.Jul 9 2019, 11:45 AM
Tobi_WMDE_SW moved this task from Next to Incoming on the User-Tobi_WMDE_SW board.
Tobi_WMDE_SW removed a project: User-Tobi_WMDE_SW.Apr 6 2020, 2:18 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:16 PM
lilients_WMDE mentioned this in T338318: Evaluate & improve accessibility of TechWish products.Jun 13 2023, 3:22 PM
WMDE-Fisch updated the task description. (Show Details)Aug 29 2023, 9:56 AM
WMDE-Fisch added a parent task: T339254: Improve accessibility of Revision Slider.
WMDE-Fisch added a subtask: T342970: Add helpful screenreader output to a focused revision.Aug 29 2023, 2:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits