Page MenuHomePhabricator

Provide a keyboard shortcut for adding signature
Open, Needs TriagePublic1 Estimated Story Points

Description

As an alternative to T153255.
https://www.mediawiki.org/w/index.php?title=Topic:Trdi58p0nwdv94c9 is where this was suggested.

Description found in suggestion
The current wikitext editor seems to be missing an option to easily add signature to talk page discussions. It would be nice if it was enabled in some way. Two possibilities are:

  1. Keyboard shortcut
  2. Option in menu bar

Expecting one soon!

Note : Adding to the above description, implementing both would be even better!

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Maybe this should also be suggested to OWE

I don't think this should be considered as alternative to T153255. One reason (among others) why a more visible button is wanted, is to make it obvious to unexperienced users that they should sign. This is something a keyboard shortcut just cannot do.
Nevertheless, a keyboard shortcut as such is still a good idea.

This comment was removed by Dvorapa.
Jdforrester-WMF renamed this task from Shortcut keyboard for adding signature to Provide a keyboard shortcut for adding signature.May 30 2017, 7:08 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF subscribed.

Which shortcut should we use?

Yes. So the S looks taken for so many other purposes. H for Handwriting? X as it's both used to mark the place where a signature goes and for a signature replacement? A autograph, N name, M mark. (Dunno about the combination of keys themselves.)

It's generally helpful to consider other editors similar to ours that might've set a standard we can reuse. I can't think of any that have similar functionality to what we're intending; "add signature" in other WYSIWYG editors such as Google Docs is for adding a hand-drawn signature for legal purposes, which is not applicable here. So, not helpful in this case. :-)

Keyboard shortcuts in VisualEditor and the 2017 Wikitext Editor follow either a <X pattern (e.g. <math) or a Ctrl-Shift-X pattern (e.g. Ctrl-Shift-K for a reference). Perhaps <sig or <signature would be best?

Keyboard shortcuts in VisualEditor and the 2017 Wikitext Editor follow either a <X pattern (e.g. <math) or a Ctrl-Shift-X pattern (e.g. Ctrl-Shift-K for a reference).

Actually, the former is a 'sequence', and the latter is a 'shortcut'. Yay terminology. :-) The idea is that the former helps wikitext experts by auto-doing things they're clearly trying to do, but the latter is the 'real' shortcut.

Perhaps <sig or <signature would be best?

So far we've never added a sequence that isn't the beginning of the wikitext equivalent. Also given that the users complaining are those without a Latin keyboard (and so have difficulty writing ~), I'm not sure that'd make them happy. :-)

Jdforrester-WMF changed the task status from Open to Stalled.Jun 1 2017, 3:25 PM

Declaring this 'stalled' waiting for a good idea for a shortcut to use.

Actually, the former is a 'sequence', and the latter is a 'shortcut'. Yay terminology. :-) The idea is that the former helps wikitext experts by auto-doing things they're clearly trying to do, but the latter is the 'real' shortcut.

Today I learnt!

So far we've never added a sequence that isn't the beginning of the wikitext equivalent. Also given that the users complaining are those without a Latin keyboard (and so have difficulty writing ~), I'm not sure that'd make them happy. :-)

The Ctrl-Shift-X shortcut pattern would work too. So, yeah, which letter? Don't say X, you'll ruin my example. ;-)

Perhaps <sig or <signature would be best?

So far we've never added a sequence that isn't the beginning of the wikitext equivalent. Also given that the users complaining are those without a Latin keyboard (and so have difficulty writing ~), I'm not sure that'd make them happy. :-)

Actually, in visual mode ~~~~ already is the sequence for signature, and currently no sequences are active in source code mode.

Atleast a shortcut for adding signature is a high requirement. It is much easier to press two keys 6 tiems than press two or three key once .

How about Ctrl+Shift+- ? (suggesting this in reminiscence of the signature [- -~~~~] added by the non-visual wikitext editor)

nshahquinn subscribed.

This might be worth doing as part of the on-wiki communication improvements.

Most likely we will be auto-signing comments so won't need this in OWC.

Most likely we will be auto-signing comments so won't need this in OWC.

If that is the case (is there a ticket?) then OWC2020 could be removed from this ticket.

Aklapper changed the task status from Stalled to Open.May 22 2020, 4:00 PM

What T166494#3358135 says.
I don't see what this task is stalled on (apart from anyone finding the time to look at existing shortcuts and agreeing on one), hence resetting task status.

With OWC we are building tools specifically for posting comments on talk pages, including using a VE interface. If the project is successful this task would be closed as declined, as we don't intend to officially support for the full page editor in visual mode on talk pages.

@Esanders If there no full page editor support on talk pages then that is very disappointing. Because talk pages are way more complex than articles. It contains templates, tables, images, galleries, polls, discussions, quoted parts from articles, categories etc. So the VE based tool is not supporting this kind of editing then it is simply not fullfill the requirement for talk pages. Hope we get our old wikieditor as optional. Because for experienced users wikitext is a lifesaver to remove all kind of problems in talk pages. Hope the development team will study about real discussions on talk pages in various wikis before building their toolset.