This task should assume that we already have a mechanism that allows us to check whether a page comes from an offline compilation.

Change 365085 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Advise users when they are reading an article from an offline compilation

https://gerrit.wikimedia.org/r/365085

Change 365085 merged by jenkins-bot:
[apps/android/wikipedia@master] Advise users when they are reading an article from an offline compilation

https://gerrit.wikimedia.org/r/365085

A couple of unexpected differences...

Actual toast:	Actual footer section

• Notification toast upon opening an article from an offline compilation shows the version date of the compilation, rather than the date the compilation was downloaded.
• Footer section should replace the "Last updated" section with the version date of compilation rather than downloaded date

Also, there is a duplicate section being added to articles from offline compilations showing the same info about Creative commons. Both the dotted line and the paragraph of text "This article is issued from Wikipedia...media files" should be removed.

In T166652#3518402, @RHo wrote:

A couple of unexpected differences...

Both of these are blocked unless/until we start creating our own ZIM files that surface the creation date and don't inject unwanted page content. As things stand, the download date is the best information we have, and mwoffliner injects that footer you pointed out. New ticket for these design follow-ups? It could be a subtask of T172738 and T172764.

Change 373549 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Remove hard-coded footer from ZIM articles.

https://gerrit.wikimedia.org/r/373549

Change 373549 merged by jenkins-bot:
[apps/android/wikipedia@master] Remove hard-coded footer from ZIM articles.

https://gerrit.wikimedia.org/r/373549

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 on 2.6.202-alpha-2017-08-28

Looks good to me. Toast version date is correct and I don't see the duplicate section.

My fault, sorry about that. Should have looked at Zeplin. Is this urgent? Have the testers received their APK or are you waiting on this?

hi @Mholloway - no worries and not urgent! Dbrant linked to build from yesterday that is good for testing purposes.

@RHo One question before I do this:

The intended footer string is almost but not quite identical to the current string used in the notification toast when loading from an article pack:

Toast: You're reading the version of this article from Wikipedia English • Aug. 10, 2017.
Footer (expected): You're reading the version of this article from Wikipedia English on Aug. 10, 2017.

Is this difference intentional or did you mean for this to be the same string, used in both places?

hi @Mholloway - hmm let's use the same string from the toast for consistency, I've updated the Zeplin.

Thanks! In progress now. One thing I should also note here is that the formatting of the date portion is handled at the platform level based on the device locale, so might vary slightly by device (e.g., "Aug. 1, 2017" vs. "1 Aug 2017").

Change 374836 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Fix footer date string for articles loaded from offline article packs

https://gerrit.wikimedia.org/r/374836

^ makes sense regarding date format based on device location settings, thanks for the heads up.

Change 374836 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix footer date string for articles loaded from offline article packs

https://gerrit.wikimedia.org/r/374836

A few things I noted in the current design,

1. View article in browser : That's surprising, shouldn't that be a View online version of article or something similar that allows user to open the current version of the article in the app itself rather than in the browser.
   
   BTW, the presence of the word article in the mock reminds me of T116841 :-) The actual version seems to be using page, though.

2. Browsing offline : I don't see that notice in the current alpha (02 Sep 2017). If that's shown I guess that would be enough to distinguish online version from offline ones. Though, I'm not sure whether that would be shown for articles from reading lists and zim files.

Hi @Kaartic -
(1) the footer is meant to be same as the standard footer but with the additional note in place of the 'last updated' link, so the option to view article in browser which opens the article in browser is still there as an unrelated item to this workflow. The t is there similar to the Talk page link still being there if users go back online and want to see the Talk page for that article.
(2) the extra status bar is still to be implemented but is not part of this task.

That was a quick reply : ]

In T166652#3575768, @RHo wrote:

Hi @Kaartic -
(1) the footer is meant to be same as the standard footer but with the additional note in place of the 'last updated' link, so the option to view article in browser which opens the article in browser is still there as an unrelated item to this workflow. The t is there similar to the Talk page link still being there if users go back online and want to see the Talk page for that article.

Just to be sure I get that. So, I would be seeing the same footer and in case I need the updated version of the article. I could just refresh the page after I go online!

(2) the extra status bar is still to be implemented but is not part of this task.

I suspected that but wanted to know as there wasn't any mention about the separation here.

! In T166652#3575891, @Kaartic wrote:
Just to be sure I get that. So, I would be seeing the same footer and in case I need the updated version of the article. I could just refresh the page after I go online!

– Yes, exactly :)

In T166652#3579731, @RHo wrote:

In T166652#3575891, @Kaartic wrote:

Just to be sure I get that. So, I would be seeing the same footer and in case I need the updated version of the article. I could just refresh the page after I go online!

– Yes, exactly :)

I noticed an issue while browsing an article from a compilation of different language. When I try to refresh a page when I'm online I get the page from the offline library rather than the online version of the page. A generic version of the steps to reproduce could be found below (I guess it works!).

Steps to reproduce (Generic)

1. Ensure Wikipedia language of app is English (or some language of your choice)
2. Download an article pack of some other language
3. Go offline
4. Load a page from that article pack
5. Go online
6. Refresh the page

Is this a bug?

Hi @Kaartic – Yes the issue would be a bug if it deviates from the 'Expected behavior' after step 6 for the article to update to its most recent online version. However I'm unable to reproduce it on my device with version v2.6.203-alpha-2017-09-05 when downloading the Spanish medical pack and looking up the article on "Aids". It is behvaing as expected in that it shows the 6-Aug-2017 version of the article from that pack in step 4, and upon going online and pulling down to refresh, the footer shows the most recent version as "Last updated 8hrs ago".

Let me know if it is still occurring for you in the latest Alpha build for other language packs, and if so we can file a separate bug.

At any rate, checking that the latest version of an article appears on refresh will be good to include in QA steps in the task description, so will add that now.

In T166652#3583233, @Kaartic wrote:

I noticed an issue while browsing an article from a compilation of different language. When I try to refresh a page when I'm online I get the page from the offline library rather than the online version of the page. A generic version of the steps to reproduce could be found below (I guess it works!).

Steps to reproduce (Generic)

1. Ensure Wikipedia language of app is English (or some language of your choice)
2. Download an article pack of some other language
3. Go offline
4. Load a page from that article pack
5. Go online
6. Refresh the page

Is this a bug?

Still a couple of discrepancies between Expected and Actual footer.

Expected	Actual:

• Missing wordmark
• Text should all be left aligned
• The links "View page in browser", Edit history" and "Talk" should appear together below the "You're reading..." offline text
• Missing "Edit history" link

This may be related to footer updates that are still tbd on T143400: Improve the reading experience of footer sections of articles

Toast looks good:

In T166652#3583886, @RHo wrote:

Let me know if it is still occurring for you in the latest Alpha build for other language packs, and if so we can file a separate bug.

With the alpha version date that I downloaded on 28 Oct 2017 this issue still seems to be happening.

What I did

1. I downloaded the "Medicalwiki/TA தமிழ்" pack
2. Went offline
3. Looked up for "தசை"
4. Went online
5. Refreshed the page

What happened
The version of page from the article pack was still shown even when Prefer offline content was turned off (i'm not sure whether it works, but just in case)

What I expected
Online version of the page I had open would show up when refreshing ( but it didn't until I opened a new tab and searched for the artcile when I was online :-( )

How are you sure?
Screen shot of the pop-up shown after trying to refresh the page after I went online (as indicated by the LTE symbol)

Screen shot of the footer of the refreshed page

Screen shot of the footer of online version of article which I obtained by searching for it in a new tab

thanks @Kaartic – I've created a separate new bug task T179283 based on your report.