Update usage of deprecated wgUseTidy
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Ronseal.

$wgUseTidy used in Extension:TextExtracts and MobileFrontend is deprecated. Use $wgTidyConfig instead.

This was extracted from T166272: HTML version of text extracts is not balanced/well formed and naive.

Details

Subject	Repo	Branch	Lines +/-
Hygiene: Remove wgMFTidyMobileViewSections	mediawiki/extensions/MobileFrontend	master	+2 -28
Stop disabling MFTidyMobileViewSections	operations/mediawiki-config	master	+0 -1
Remove deprecated $wgUseTidy in favour of $wgTidyConfig	mediawiki/extensions/MobileFrontend	master	+8 -6
Remove deprecated $wgUseTidy in favour of $wgTidyConfig	mediawiki/extensions/TextExtracts	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T165896: Logo for sr.m.wikipedia.org
T166272: HTML version of text extracts is not balanced/well formed and naive
Mentioned Here: T165896: Logo for sr.m.wikipedia.org
rOMWC373f59332533: Experiment: disable mobileview tidying
T166272: HTML version of text extracts is not balanced/well formed and naive

Event Timeline

phuedx created this task.Jun 22 2017, 5:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2017, 5:43 PM

phuedx updated the task description. (Show Details)Jun 22 2017, 5:43 PM

phuedx mentioned this in T166272: HTML version of text extracts is not balanced/well formed and naive.

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Jun 22 2017, 5:44 PM

Jdlrobson triaged this task as Medium priority.Jun 22 2017, 9:46 PM

Jdlrobson added projects: good first task, Technical-Debt.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 22 2017, 9:46 PM

Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.Jun 27 2017, 5:25 PM

ovasileva moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.Jun 27 2017, 5:25 PM

Jdlrobson set the point value for this task to 2.Jun 28 2017, 5:24 PM

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jun 28 2017, 5:36 PM

There seems to be a move away from Tidy in the organization [1]. Do we still want to do this?

[1] https://lists.wikimedia.org/pipermail/wikitech-l/2017-July/088428.html

I'll work on it today

@bmansurov the change is pretty trivial, Parser team wants to switch to RemexHTML by June 2018, so it might take a year. I vote to do it.

pmiazga claimed this task.Jul 6 2017, 6:20 PM

pmiazga moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.

Per today stand-up discussion - RemexHTML instrumentation should be backward compatible. If we do it right now it should work properly after RemexHTML replaces current Tidy.

Change 363860 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/TextExtracts@master] Remove deprected $wgUseTidy in favour of TidyConfig

https://gerrit.wikimedia.org/r/363860

pmiazga added a project: MobileFrontend.Jul 7 2017, 6:28 PM

gerritbot added a project: Patch-For-Review.Jul 7 2017, 6:28 PM

pmiazga updated the task description. (Show Details)Jul 7 2017, 6:28 PM

Change 363863 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Remove deprected $wgUseTidy in favour of $wgTidyConfig

https://gerrit.wikimedia.org/r/363863

pmiazga moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 7 2017, 6:35 PM

In T168671#3412072, @bmansurov wrote:

There seems to be a move away from Tidy in the organization [1]. Do we still want to do this?

[1] https://lists.wikimedia.org/pipermail/wikitech-l/2017-July/088428.html

Note that the Tidy naming is not to be confused with the specific library/tool -- the tidier itself will be different tools (nothing, Remex, "Tidy" (html4), tidy-htm5), etc.

While merging this I noticed that $wgMFTidyMobileViewSections is set to false in production and true in MobileFrontend. I found this interesting and wondered if we might want to look into the history of that as part of this task. It appears to only impact the mobile view API. Do we really need this global or can we remove more tech debt?

(if we don't want to fix this now we can move this to sign off, creating a new task if necessary so we revisit this later.. but now seems like a good time!)

Change 363860 merged by jenkins-bot:
[mediawiki/extensions/TextExtracts@master] Remove deprecated $wgUseTidy in favour of $wgTidyConfig

https://gerrit.wikimedia.org/r/363860

Change 363863 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove deprecated $wgUseTidy in favour of $wgTidyConfig

https://gerrit.wikimedia.org/r/363863

pmiazga removed a project: Patch-For-Review.Jul 7 2017, 11:05 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 8 2017, 5:01 AM

In T168671#3417131, @Jdlrobson wrote:

While merging this I noticed that $wgMFTidyMobileViewSections is set to false in production and true in MobileFrontend. I found this interesting and wondered if we might want to look into the history of that as part of this task. It appears to only impact the mobile view API. Do we really need this global or can we remove more tech debt?

Since it's unconditionally set to false in production, I don't see the harm in briefly investigating it here (it is related, after all).

rOMWC373f59332533: Experiment: disable mobileview tidying added the $wgMFTidyMobileViewSections = false line to the config. There's no why in the commit message but there's a little discussion around how the apps might behave. Given that this change has been in production for over three years with no recent complaint, I don't see why we can't tidy – get it?! – it up.

Change 364230 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/extensions/MobileFrontend@master] Hygiene: Remove wgMFTidyMobileViewSections

https://gerrit.wikimedia.org/r/364230

gerritbot added a project: Patch-For-Review.Jul 10 2017, 3:37 PM

^ I was bold.

phuedx moved this task from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 10 2017, 3:40 PM

Change 364264 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Stop disabling MFTidyMobileViewSections

https://gerrit.wikimedia.org/r/364264

Change 364264 merged by jenkins-bot:
[operations/mediawiki-config@master] Stop disabling MFTidyMobileViewSections

https://gerrit.wikimedia.org/r/364264

Mentioned in SAL (#wikimedia-operations) [2017-07-10T19:09:39Z] <niharika29@tin> Synchronized wmf-config/: Stop disabling MFTidyMobileViewSections (T168671) and Logo changes for various wiki projects (T165896) (duration: 00m 21s)