Page MenuHomePhabricator

Don't make the advanced filters to float at the bottom of the filters panel
Closed, ResolvedPublic


As part of T167384, an "advanced filters" section was added at the bottom of the regular filter panel. Currently it is available as part of the floating bottom bar where the link to provide feedback is also present.

In order to avoid the advanced filters to take too much prominence over the regular ones, these should be provided at the end of the list. The mockups below capture how these appear in different situations:

Not visible initially at the beginning of the listVisible when scrolling to the end of the listShown after the indicator of no results when filters cannot be found
Screen Shot 2017-06-26 at 13.58.06.png (585×673 px, 105 KB)
Screen Shot 2017-06-26 at 13.58.17.png (595×671 px, 90 KB)
Screen Shot 2017-06-26 at 13.57.25.png (337×667 px, 38 KB)

This gif captures the scrolling interaction:

advanced-filters-nosticky.gif (426×680 px, 2 MB)

(The screenshots reflect a local modification where the active filters element was moved right after the "no results found" message in the HTML).

Event Timeline

Change 361605 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Make extra filters footer non-sticky

Change 361605 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Make extra filters footer non-sticky

Checked the fix in betalabs - the implementation is according to the specs.

Screen Shot 2017-07-03 at 1.54.39 PM.png (390×702 px, 59 KB)

Screen Shot 2017-07-03 at 1.54.03 PM.png (501×697 px, 82 KB)

QA Recommendation: Resolve