Page MenuHomePhabricator

Special:Preferences design broken in desktop MinervaNeue - not using OOUI
Closed, ResolvedPublic

Description

Visit https://en.wikipedia.org/wiki/Special:Preferences?useskin=minerva when logged in

When filed

Notice how the tabs are unstyled:

Screen Shot 2017-07-20 at 3.36.32 PM.png (634×909 px, 71 KB)

Also note the save button:

Screen Shot 2017-07-20 at 3.37.47 PM.png (289×506 px, 40 KB)

and input widgets:
Screen Shot 2017-07-20 at 3.37.50 PM.png (346×684 px, 67 KB)

This is expected as Minerva specifically avoids loading unnecessary CSS and enforcing UI standards and I guess blocked on T117781 but I wonder if there is a way to improve rendering for Minerva... maybe enabling OOUI widgets just for that skin?

Now

en.wikipedia.org-wiki-Special-Preferences-useskin=minerva(Laptop with MDPI screen).png (1×1 px, 93 KB)

Event Timeline

Looks like some work on this has already been done, here's how it looks like now:

https://en.wikipedia.org/wiki/Special:Preferences?useskin=minerva#mw-prefsection-editing

en.wikipedia.org-wiki-Special-Preferences-useskin=minerva(Laptop with MDPI screen).png (1×1 px, 93 KB)

I've been working on the subtask T117781 recently, and here's how it looks like for me locally with the patch https://gerrit.wikimedia.org/r/352071 (note that the preferences are a bit different since I have different extensions that production; also, the cut-off tabs are a known issue):

localhost-3080-wiki-Special-Preferences-useskin=minerva(Laptop with MDPI screen).png (1×1 px, 106 KB)

Volker_E renamed this task from Special:Preferences design broken - not using OOjs UI or MediaWiki UI to Special:Preferences design broken - not using OOUI.Dec 4 2017, 9:45 PM
Jdforrester-WMF renamed this task from Special:Preferences design broken - not using OOUI to Special:Preferences design broken in desktop MinervaNeue - not using OOUI.Jan 18 2018, 7:53 PM
Esanders claimed this task.
Esanders subscribed.

The OOUI rewrite was reverted. Looks fine in the latest WIP patch though. We can re-open this if there is a problem when it eventually gets merged again.