Page MenuHomePhabricator

Apply new print styles for books
Closed, InvalidPublic

Description

Acceptance criteria

Event Timeline

ovasileva changed the task status from Open to Stalled.Jul 27 2017, 10:58 AM
ovasileva created this task.
ovasileva moved this task from Triage to Needs Analysis on the Proton board.Aug 30 2017, 5:20 PM
ovasileva moved this task from Needs Analysis to Backlog on the Proton board.Sep 6 2017, 6:58 PM
Jdlrobson added a subscriber: Jdlrobson.

Do you mean "new Vector print styles" e.g. the ones we've been working on in T154965?

Restricted Application added a subscriber: Dereckson. · View Herald TranscriptSep 7 2017, 6:41 PM
Jdlrobson changed the task status from Stalled to Open.Sep 7 2017, 7:23 PM

I assume this is a precursor to T169732 (ie. the same but only for beta cluster)? If so this doesn't seem stalled. There should be no reason not to enable them on beta cluster... although I'm not sure how useful this is. There are very few articles on the beta cluster which render nicely and we're testing on live data on https://reading-web-staging.wmflabs.org.

@Jdlrobson - books will have separate styles than single articles, tracked in this task's subtask, T167955: Create PDF styles for books

Nirzar added subscribers: bmansurov, Nirzar.

@bmansurov can we add the custom serif font on the backend as a requirement to this card?

I have added T169828 as subtask.

cc @ovasileva

@Nirzar it has to be done on the Electron side. We don't maintain it. You're better off creating a ticket and pinging services.

@bmansurov - sorry, I know I asked this already, but wanted to make sure it still makes sense given the new post-processing service plans. We will first implement post-processing and then continue with the new styles on top, right?

I think we can go ahead with new styles before post-processing. Everything except adding new fonts can be done in Extension:Collection.

ovasileva updated the task description. (Show Details)Sep 13 2017, 1:36 PM

That is wonderful news :)

Even adding new fonts can be done there. Electron just will have to download those fonts to render the content correctly.

yeah can we change the font stack in default print styles and if the renderer (a server or a person's computer) has a Charis as a font, it will use it?

then I can create a ticket to have Charis inside Electron?

Yes, if the server has it it will use it. We can also do something like this:

@font-face {
      font-family: "Bitstream Vera Serif Bold";
      src: url("https://mdn.mozillademos.org/files/2468/VeraSeBd.ttf");
    }

More at https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face

ovasileva changed the status of subtask T167955: Create PDF styles for books from Open to Stalled.
Jdlrobson changed the task status from Open to Stalled.Oct 17 2017, 9:06 PM

This depends on T167955 which is stalled so this is also stalled.

ovasileva closed this task as Invalid.Apr 9 2018, 2:46 PM

Closing as per T184772#4116906. Pediapress will be taking on rendering of PDF books.