Acceptance criteria
- Apply new book print styles from T167955: Create PDF styles for books and deploy to the staging server for testing
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | • JKatzWMF | T150871 [EPIC] (Proposal) Replicate core OCG features and sunset OCG service | |||
Invalid | None | T186740 [EPIC] It should be possible to print a book using the Proton service | |||
Invalid | None | T171832 Deploy new book renderer to all projects | |||
Duplicate | None | T171833 Deploy new book renderer to all projects side by side with OCG | |||
Invalid | None | T171836 Apply new print styles for books | |||
Invalid | None | T167955 Create PDF styles for books | |||
Resolved | • dpatrick | T173014 Security review of pdfrw |
Do you mean "new Vector print styles" e.g. the ones we've been working on in T154965?
I assume this is a precursor to T169732 (ie. the same but only for beta cluster)? If so this doesn't seem stalled. There should be no reason not to enable them on beta cluster... although I'm not sure how useful this is. There are very few articles on the beta cluster which render nicely and we're testing on live data on https://reading-web-staging.wmflabs.org.
@Jdlrobson - books will have separate styles than single articles, tracked in this task's subtask, T167955: Create PDF styles for books
@bmansurov can we add the custom serif font on the backend as a requirement to this card?
I have added T169828 as subtask.
cc @ovasileva
@Nirzar it has to be done on the Electron side. We don't maintain it. You're better off creating a ticket and pinging services.
@bmansurov - sorry, I know I asked this already, but wanted to make sure it still makes sense given the new post-processing service plans. We will first implement post-processing and then continue with the new styles on top, right?
I think we can go ahead with new styles before post-processing. Everything except adding new fonts can be done in Extension:Collection.
Even adding new fonts can be done there. Electron just will have to download those fonts to render the content correctly.
yeah can we change the font stack in default print styles and if the renderer (a server or a person's computer) has a Charis as a font, it will use it?
then I can create a ticket to have Charis inside Electron?
Yes, if the server has it it will use it. We can also do something like this:
@font-face { font-family: "Bitstream Vera Serif Bold"; src: url("https://mdn.mozillademos.org/files/2468/VeraSeBd.ttf"); }
More at https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face