| matmarex | |
| Aug 6 2017, 11:51 AM |
| F12390910: Screen Shot 2018-01-10 at 11.35.56 AM.png | |
| Jan 10 2018, 7:42 PM |
| F12390915: Screen Shot 2018-01-10 at 11.40.29 AM.png | |
| Jan 10 2018, 7:42 PM |
| F8999946: original_msg (1).txt | |
| Aug 9 2017, 6:58 PM |
| F8968646: image.png | |
| Aug 6 2017, 11:51 AM |
| F8968633: image.png | |
| Aug 6 2017, 11:51 AM |
| F8968652: original_msg.txt | |
| Aug 6 2017, 11:51 AM |
I've just received an user rights change notification email from Echo, and the main link in it points to a relative URL /wiki/%D8%AE%D8%A7%D8%B5:%D9%88%D8%B5%D9%84%D8%A9_%D8%AF%D8%A7%D8%A6%D9%85%D8%A9/23718221 rather than an absolute one. The email is in Arabic (from ar.wikipedia.org).
The message on Special:Notifications and in the flyout also seems to have a broken link, in English as well as Arabic:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Format user-rights reason as plain text | mediawiki/extensions/Echo | master | +6 -4 |
Could it be the case of custom email formatting ? In betalabs there is no additional link such as in the message text:
<a href=3D"/wiki/%D8%AE%D8%A7%D8%B5:%D9%88%D8%B5%D9%84%D8%A9_%D8%AF= %D8%A7%D8%A6%D9%85%D8%A9/23718221" title=3D"=D8=AE=D8=A7=D8=B5:=D9=88=D8=B5= =D9=84=D8=A9 =D8=AF=D8=A7=D8=A6=D9=85=D8=A9/23718221">=D8=AE=D8=A7=D8=B5:= =D8=B1=D8=A7=D8=A8=D8=B7 =D8=AF=D8=A7=D8=A6=D9=85/23718221</a>
I attached the sample of the user rights change email from beta hewiki :
This is a link provided by the user via wikitext (the wikitext is a reason for the group change). See dupe I'm about to merge in.
We could (it would be better if we do parse it):
When overhauling the notification system in 2015 we decided that links in notification text were not going to be supported. I think we should not parse them consistently in emails as well as in the web UI.
Change 403150 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Echo@master] Format user-rights reason as plain text
Change 403150 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Format user-rights reason as plain text
Checked in betalabs - the Reason on Special:UserRights is not displayed as a link anymore - not in email and not in Alerts:
From the email source:
Your user rights were changed. You have been added to: =E2=80=AAPatrollers= =E2=80=AC. checking email and Notifications format when user rights are changed Learn more: <https://en.wikipedia.beta.wmflabs.org/wiki/Special:ListGroupR= ights?markasread=3D768746#patroller> =E2=80=AAEtonkovidova=E2=80=AC: <https://en.wikipedia.beta.wmflabs.org/wik= i/User:Etonkovidova> Public log: <https://en.wikipedia.beta.wmflabs.org/w/index.php?title=3DSpe= cial:Log&type=3Drights&page=3DUser%3AET70&user=3DEtonkovidova>