Page MenuHomePhabricator

Minerva should use skinStyles to customise special pages
Closed, ResolvedPublic

Description

Currently Minerva uses hooks to add modules to specific pages (Special:userlogin, Special:Search, Special:MobileWatchlist). It should not do this.

Instead it should apply skin styles to:

  • mediawiki.special
  • mediawiki.special.userlogin.common.styles
  • mediawiki.special.search.styles
  • mobile.special.styles (added by all MobileFrontend managed special pages)

We'll also need to ensure modules have the right targets before they can be used.

Event Timeline

Change 372561 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Enable mediawiki.special.userlogin.common.styles on mobile and allow skins to style it

https://gerrit.wikimedia.org/r/372561

Jdlrobson renamed this task from Minerva should use skinStyles to customise pages to Minerva should use skinStyles to customise special pages.Aug 18 2017, 7:36 PM

Change 372559 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] MobileFrontend should not add Minerva modules for its special pages

https://gerrit.wikimedia.org/r/372559

Change 372560 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Remove special page resource module handling

https://gerrit.wikimedia.org/r/372560

Change 373688 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/Popups@master] Use canonical name for NS_SPECIAL titles when checking the blacklist

https://gerrit.wikimedia.org/r/373688

sorry for the patch above, I pasted wrong phabricator ticket number.

Change 372559 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] MobileFrontend should not add Minerva modules for its special pages

https://gerrit.wikimedia.org/r/372559

Change 372560 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove special page resource module handling

https://gerrit.wikimedia.org/r/372560

Change 372561 merged by jenkins-bot:
[mediawiki/core@master] Enable mediawiki.special.userlogin.common.styles on mobile and allow skins to style it

https://gerrit.wikimedia.org/r/372561

Jdlrobson closed this task as Resolved.Oct 5 2017, 12:45 AM
Jdlrobson claimed this task.