Page MenuHomePhabricator
Create Task
Maniphest T175769

ULS personal bar menu item needs to feature style guide compliant icon
Closed, ResolvedPublic
Actions

Assigned To
• Petar.petkovic
Authored By
Volker_E
Sep 13 2017, 12:17 AM
Tags
Referenced Files
F13723681: Screen Shot 2018-02-13 at 3.52.10 PM.png
Feb 14 2018, 12:01 AM
F13723671: Screen Shot 2018-02-13 at 3.52.22 PM.png
Feb 14 2018, 12:01 AM
F13327771: Screen Shot 2018-02-08 at 2.55.36 PM.png
Feb 8 2018, 10:57 PM
F13327844: Screen Shot 2018-02-08 at 2.50.55 PM.png
Feb 8 2018, 10:57 PM
F12587066: image.png
Jan 16 2018, 4:29 AM
F12587093: image.png
Jan 16 2018, 4:29 AM
F11027771: language.svg
Nov 27 2017, 10:51 PM
F11027351: Screen Shot 2017-11-27 at 13.08.38.png
Nov 27 2017, 10:51 PM
View All 13 Files
Subscribers
Aklapper
Amire80
Etonkovidova
gerritbot
Nikerabbit
• Petar.petkovic
Pginer-WMF
View All 9 Subscribers

Description

The personal bar ULS item needs to feature WikimediaUI style guide compliant icon similar to “language” icon of 'editing-advanced'.

image.png (71×81 px, 3 KB)

On multilingual wikis, such as mediawiki.org or Wikimedia Commons, the language selection is shown in the user personal bar on top.

Screen Shot 2017-11-27 at 13.08.38.png (202×1 px, 83 KB)

The current language selection icon has become outdated with respect the general icon style (where monochrome icons are used) and the language icon used in newer products such as the mobile view:

Screen Shot 2017-11-27 at 13.15.23.png (203×533 px, 20 KB)

The mockup below shows the new language icon in the personal toolbar:

personal-header-monochrome.png (202×1 px, 83 KB)

The language icon is available in the icon repo, and their graphic assets are provided below as SVG for black and grey versions:

language.svg1 KBDownload

language-grey.svg1 KBDownload

Details

SubjectRepoBranchLines +/-
Reduce the padding for ULS trigger icon in personal toolbar positionmediawiki/extensions/UniversalLanguageSelectormaster+1 -1
Update jquery.uls to 54a466emediawiki/extensions/UniversalLanguageSelectormaster+12 -52
Update jquery.uls to d122f37mediawiki/extensions/UniversalLanguageSelectormaster+421 -349
Update jquery.uls to fd41bbe5e16amediawiki/extensions/UniversalLanguageSelectormaster+288 -278
Update jquery.uls to fd41bbe5e16amediawiki/extensions/UniversalLanguageSelectormaster+288 -278
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Sep 13 2017, 12:17 AM
Restricted Application added projects: UniversalLanguageSelector, UI-Standardization. · View Herald TranscriptSep 13 2017, 12:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 moved this task from Backlog to Appearance and design on the ULS-CompactLinks board.Oct 10 2017, 1:26 PM
Nikerabbit moved this task from Backlog to Performance and stability on the UniversalLanguageSelector board.Oct 13 2017, 9:29 AM
Amire80 moved this task from Performance and stability to Appearance and design on the UniversalLanguageSelector board.Nov 3 2017, 2:55 PM
Volker_E merged a task: T181395: Update language selection icon.Nov 27 2017, 10:49 PM
Volker_E added subscribers: • santhosh, • Petar.petkovic.
Volker_E updated the task description. (Show Details)Nov 27 2017, 10:51 PM
Amire80 added a project: Language-2018-Jan-Mar.Jan 2 2018, 1:58 PM
Amire80 triaged this task as Low priority.Jan 2 2018, 2:04 PM
gerritbot subscribed.Jan 13 2018, 3:49 AM

Change 404065 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls to fd41bbe5e16a

https://gerrit.wikimedia.org/r/404065

gerritbot added a project: Patch-For-Review.Jan 13 2018, 3:49 AM

Change 404065 abandoned by Petar.petkovic:
Update jquery.uls to fd41bbe5e16a

Reason:
Mistake

https://gerrit.wikimedia.org/r/404065

gerritbot added a comment.Jan 13 2018, 4:07 AM

Change 404066 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls to fd41bbe5e16a

https://gerrit.wikimedia.org/r/404066

• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-Jan-Mar board.Jan 13 2018, 4:08 AM
• Petar.petkovic moved this task from Unsorted to Wikimedia Design Style Guide on the UI-Standardization board.
• Petar.petkovic moved this task from Backlog to Review on the UI-Standardization-Kanban board.
• santhosh added a comment.Jan 15 2018, 6:41 AM

+cc @Pginer-WMF FYI.

Arrbee assigned this task to • Petar.petkovic.Jan 15 2018, 7:10 AM
Volker_E added a comment.Jan 16 2018, 4:29 AM

@Petar.petkovic As @Amire80 pointed out in M229#3936 a misconception has probably been lead to the RTL version of the language icon in https://gerrit.wikimedia.org/r/#/c/263410/
From current point of information we should update jquery.uls once more to reflect that. OOUI is targeted to feature uni-directional 'language' icon in v0.26.0 via https://gerrit.wikimedia.org/r/#/c/400091/

As preview, LTR would end up with such treatment (padding-left reduced to 24px and no special SVG fill)

image.png (190×1 px, 48 KB)

RTL would be resembled closely to this:
image.png (200×1 px, 42 KB)

Does this make sense, @Amire80?

gerritbot added a comment.Jan 16 2018, 12:06 PM

Change 404066 abandoned by Petar.petkovic:
Update jquery.uls to fd41bbe5e16a

Reason:
Conflicting patch I7341064cd0 has more info in commit message.

https://gerrit.wikimedia.org/r/404066

gerritbot added a comment.Jan 17 2018, 5:13 AM

Change 404234 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls to d122f37

https://gerrit.wikimedia.org/r/404234

gerritbot added a comment.Jan 30 2018, 11:45 AM

Change 404234 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls to d122f37

https://gerrit.wikimedia.org/r/404234

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 30 2018, 12:00 PM
Nikerabbit moved this task from In Review to QA on the Language-2018-Jan-Mar board.Feb 1 2018, 8:11 AM
Nikerabbit moved this task from QA to In Review on the Language-2018-Jan-Mar board.Feb 1 2018, 8:13 AM

Follow-up https://github.com/wikimedia/jquery.uls/pull/294/files

• Petar.petkovic removed a project: Patch-For-Review.Feb 6 2018, 8:12 AM

Pull request #294 is now merged.

gerritbot added a comment.Feb 6 2018, 10:34 AM

Change 408517 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls to 54a466e

https://gerrit.wikimedia.org/r/408517

gerritbot added a project: Patch-For-Review.Feb 6 2018, 10:34 AM
gerritbot added a comment.Feb 6 2018, 2:05 PM

Change 408517 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls to 54a466e

https://gerrit.wikimedia.org/r/408517

• Petar.petkovic removed a project: Patch-For-Review.Feb 6 2018, 2:07 PM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-Jan-Mar board.
Etonkovidova subscribed.Feb 8 2018, 10:57 PM

@Pginer-WMF In mediawiki (wmf.20) the icon looks somewhat smaller than in the mockup and with a less contrast(?). Please confirm that the look of the icon is fine.

The new icon:

Screen Shot 2018-02-08 at 2.55.36 PM.png (328×1 px, 117 KB)

The old icon (wmf.17):

Screen Shot 2018-02-08 at 2.50.55 PM.png (120×1 px, 39 KB)

gerritbot added a comment.Feb 12 2018, 7:29 AM

Change 409739 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/UniversalLanguageSelector@master] Reduce the padding for ULS trigger icon in personal toolbar position

https://gerrit.wikimedia.org/r/409739

gerritbot added a project: Patch-For-Review.Feb 12 2018, 7:29 AM
• Petar.petkovic removed a project: Patch-For-Review.Feb 12 2018, 8:06 AM
gerritbot added a comment.Feb 12 2018, 8:13 AM

Change 409739 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Reduce the padding for ULS trigger icon in personal toolbar position

https://gerrit.wikimedia.org/r/409739

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)); removed MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 12 2018, 9:00 AM
Etonkovidova closed this task as Resolved.Feb 14 2018, 12:01 AM

Checked in mediawiki (wmf.21) - the icon moved closer.

Screen Shot 2018-02-13 at 3.52.22 PM.png (85×562 px, 19 KB)

Compare with wmf.20

Screen Shot 2018-02-13 at 3.52.10 PM.png (82×512 px, 18 KB)

KartikMistry moved this task from QA to Done on the Language-2018-Jan-Mar board.Feb 14 2018, 4:52 AM
Volker_E raised the priority of this task from Low to Needs Triage.Mar 17 2018, 8:05 PM
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL