Page MenuHomePhabricator

Unwatch/watch links are not displayed for grouped Move log entries
Open, Needs TriagePublic

Description

  1. Make sure that a page is on a test user Watchlist and an associated Talk page exists.
  2. As a different user, move the page from the above step. The page will be moved along with the Talk page. Make sure that Move associated talk page box is checked on Special:MovePage.
  3. Go to the Watchlist of the user from the step 1. Enable 'Groups by page' option - the two actions for Move page will be grouped.

The X - direct watch/unwatch links are not displayed.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2017, 11:48 PM
Etonkovidova renamed this task from Unwatch/watch links are not displayed for Move log entires in Grouped by change mode to Unwatch/watch links are not displayed for grouped Move log entires .Sep 26 2017, 12:03 AM
Etonkovidova renamed this task from Unwatch/watch links are not displayed for grouped Move log entires to Unwatch/watch links are not displayed for grouped Move log entries .Sep 26 2017, 6:07 PM

This was actually done on purpose. The patch by @Sn1per, merged for T2424: Add a direct unwatch link to entries on Special:Watchlist, explains in the code comments the reason behind this choice:

// Don't show unwatch link if the line is a grouped log entry using EnhancedChangesList,
// since EnhancedChangesList groups log entries by performer rather than by target article

Also, the author wrote this comment - T2424#3019594, which provides the similar insight.

@Petar.petkovic - yes, the following makes sense.

Don't show unwatch link if the line is a grouped log entry using EnhancedChangesList,
since EnhancedChangesList groups log entries by performer rather than by target article

However, in the scenario I described in the ticket, ungrouped entries (they are log entries) show unwatch links.

When the group option is enabled, which, btw, is called "Group results by page" (not as the comment above suggests: "EnhancedChangesList groups log entries by performer rather than by target article"), the grouped entries do no have the direct unwatch link:

So, to summarize - there should not be discrepancy in displaying unwatch links for the same entries with and without Grouped mode. If we will make such diffierence that that the comment you cited suggest (grouped by performer not by target article) , that fact should be somehow reflected in the name of the option.

Two things I don't understand:

  • Why does it make sense to group log entries on Watchlist by actor instead of by page? The only log entries on a Watchlist are log entries that are about a PAGE that I'm watching. So I would think they should be grouped with the other changes that are about that page. What am I missing?
  • Why are we working on this if the Watch/Unwatch links were added by Community Tech. @DannyH or @kaldari, can we just sign this over to you?

Would like to get @Sn1per's take on this before deciding whether or not it's worth changing.

Sn1per added a comment.Jan 9 2018, 5:50 PM

I don't know why log entries were grouped by performer, but it required more logic to deal with when implementing unwatch links. To enforce consistency, I would prefer the log grouping behavior to be page-based rather than removing unwatch links from the ungrouped log entries.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 3:40 PM