There is a typography scale in the visual style guide, and there is a different one in zeplin specs.
This task tracks upstreaming the variables for the sizes to the common wikimedia-ui-base library.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add typograpy scale variables | wikimedia-ui-base | master | +18 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | egardner | T287532 [Epic] Resolve key questions for design of shared component library | |||
| Resolved | None | T287538 Identify Design System hurdles & blockers and resolve open questions | |||
| Declined | None | T176963 Upstream typography scale variables to WikimediaUI Base |
Event Timeline
Comment Actions
Change 378041 had a related patch set uploaded (by Jhernandez; owner: Jhernandez):
[wikimedia-ui-base@master] Add typograpy scale variables
Comment Actions
The associated patch is not for the Marvin codebase but wikimedia-ui-base so I assume that's Wikimedia Design Style Guide
Comment Actions
In the current way, it doesn't work for our interface needs. We have to provide relative font-size equivalents to fulfill Accessibility needs and principles. px based font-sizes disallow users to set their font-size and overrule our sizes if they don't want to rely on zooming only.
Putting on 'stalled' for now until we have resources to revisit this and find an appropriate cross-product solution, that works for wikimedia-ui-base and for use cases like embedding in MW core.
Comment Actions
Change 378041 abandoned by VolkerE:
Add typograpy scale variables
Reason:
- Px values are not accessible
- As long as we support different base font-sizes in Wikimedia themes (looking at you Vector and MinervaNeue) this has no value
Abandoning here until front-end architecture allows for something like this.
Comment Actions
@Volker_E: Two years later, is that still the plan? Or should this task be declined? Asking as tasks shouldn't linger as "stalled" forever...
Comment Actions
This is superseded by T296998: [Epic] Define the system's typographic styles and scale as part of Codex and its design tokens system.