Page MenuHomePhabricator

Upstream typography scale variables to WikimediaUI Base
Open, Stalled, Needs TriagePublic

Description

There is a typography scale in the visual style guide, and there is a different one in zeplin specs.

This task tracks upstreaming the variables for the sizes to the common wikimedia-ui-base library.

Patch: https://gerrit.wikimedia.org/r/#/c/378041/

Event Timeline

Change 378041 had a related patch set uploaded (by Jhernandez; owner: Jhernandez):
[wikimedia-ui-base@master] Add typograpy scale variables

https://gerrit.wikimedia.org/r/378041

Aklapper added a subscriber: Aklapper.

The associated patch is not for the Marvin codebase but wikimedia-ui-base so I assume that's Wikimedia Design Style Guide

Volker_E changed the task status from Open to Stalled.Jun 4 2019, 4:09 AM

In the current way, it doesn't work for our interface needs. We have to provide relative font-size equivalents to fulfill Accessibility needs and principles. px based font-sizes disallow users to set their font-size and overrule our sizes if they don't want to rely on zooming only.
Putting on 'stalled' for now until we have resources to revisit this and find an appropriate cross-product solution, that works for wikimedia-ui-base and for use cases like embedding in MW core.

Change 378041 abandoned by VolkerE:
Add typograpy scale variables

Reason:

  1. Px values are not accessible
  2. As long as we support different base font-sizes in Wikimedia themes (looking at you Vector and MinervaNeue) this has no value

Abandoning here until front-end architecture allows for something like this.

https://gerrit.wikimedia.org/r/378041

Jhernandez removed a subscriber: Jhernandez.

Putting on 'stalled' for now until we have resources to revisit this and find an appropriate cross-product solution, that works for wikimedia-ui-base and for use cases like embedding in MW core.

@Volker_E: Two years later, is that still the plan? Or should this task be declined? Asking as tasks shouldn't linger as "stalled" forever...

Volker_E renamed this task from Upstream typography scale variables to wikimedia-ui-base to Upstream typography scale variables to WikimediaUI Base.Aug 4 2021, 6:32 AM
Volker_E added a project: WikimediaUI-Base.
Volker_E removed a parent task: T176962: Upstreaming efforts.
Volker_E removed a subscriber: Nirzar.