Page MenuHomePhabricator
Create Task
Maniphest T179774

Fix undefined index in SVGFileTest::testSwitchTranslationSetRoundtrip in TranslateSvg
Closed, DeclinedPublic
Actions

Description

1) SVGFileTest::testSwitchTranslationSetRoundtrip
Undefined index: 1

/home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/TranslateSvg/SVGFile.php:675
/home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/TranslateSvg/SVGFile.php:494
/home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/TranslateSvg/tests/phpunit/SVGFileTest.php:451
/home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:416
/home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/maintenance/doMaintenance.php:95

See also T196555

Details

SubjectRepoBranchLines +/-
SVGFileTest::testSwitchTranslationSetRoundtrip is brokenmediawiki/extensions/TranslateSvgREL1_31+4 -0
Revert "SVGFileTest::testSwitchTranslationSetRoundtrip is broken"mediawiki/extensions/TranslateSvgmaster+0 -4
SVGFileTest::testSwitchTranslationSetRoundtrip is brokenmediawiki/extensions/TranslateSvgmaster+4 -0
Migrate TranslateSvg to Quibbleintegration/configmaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Nov 4 2017, 10:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2017, 10:11 PM
Umherirrender added a parent task: T134090: fix or mark as inactive extensions currently failing CI.Nov 4 2017, 10:11 PM
MarcoAurelio merged a task: T189695: TranslateSvg broken on master with: SVGFileTest::testSwitchTranslationSetRoundtrip.Mar 14 2018, 4:14 PM
MarcoAurelio subscribed.
MarcoAurelio triaged this task as High priority.Mar 14 2018, 4:16 PM
MarcoAurelio added subscribers: Jarry1250, MarkTraceur, kaldari.

Triaging high as this error is blocking any development on the extension. Also adding some contributors to the extension to see if they can help here.

MarcoAurelio added a subscriber: Mainframe98.Mar 21 2018, 1:55 PM
On https://gerrit.wikimedia.org/r/#/c/419419/, @Mainframe98 wrote:

Seems to me that this statement could just be replaced with $newNodeToProcess = $node;
It might be that the indexes get shuffled around somehow? I'm not sure how PHP handles unsetting items in a list it is iterating on.

@Umherirrender what do you think?

Umherirrender added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 13 2018, 7:14 PM
Umherirrender removed a parent task: T134090: fix or mark as inactive extensions currently failing CI.Apr 13 2018, 7:21 PM
Krinkle removed a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 13 2018, 8:15 PM
gerritbot subscribed.Jun 6 2018, 1:49 PM

Change 437758 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/TranslateSvg@master] SVGFileTest::testSwitchTranslationSetRoundtrip is broken

https://gerrit.wikimedia.org/r/437758

gerritbot added a project: Patch-For-Review.Jun 6 2018, 1:49 PM
hashar mentioned this in T196555: [TranslateSVG] SVGMessageGroupTest::testGetOnWikiLanguagesAfterImport.Jun 6 2018, 1:50 PM
hashar updated the task description. (Show Details)
gerritbot added a comment.Jun 6 2018, 2:06 PM

Change 437763 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate TranslateSvg to Quibble

https://gerrit.wikimedia.org/r/437763

gerritbot added a comment.Jun 6 2018, 2:08 PM

Change 437758 merged by jenkins-bot:
[mediawiki/extensions/TranslateSvg@master] SVGFileTest::testSwitchTranslationSetRoundtrip is broken

https://gerrit.wikimedia.org/r/437758

gerritbot added a comment.Jun 6 2018, 2:09 PM

Change 437763 merged by jenkins-bot:
[integration/config@master] Migrate TranslateSvg to Quibble

https://gerrit.wikimedia.org/r/437763

gerritbot added a comment.Jun 7 2018, 8:02 AM

Change 437923 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/TranslateSvg@master] Revert "SVGFileTest::testSwitchTranslationSetRoundtrip is broken"

https://gerrit.wikimedia.org/r/437923

• Phabricator_maintenance added a project: Community-Tech.Jul 20 2018, 5:13 PM
Niharika removed a project: Community-Tech.Jul 20 2018, 7:55 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptJul 20 2018, 7:55 PM
Niharika removed a project: Community-Tech.Jul 20 2018, 7:55 PM
MaxSem mentioned this in T206896: Fix and reenable SvgFileTest::testSwitchTranslationSetRoundtrip().Oct 13 2018, 1:52 AM
gerritbot added a comment.Oct 31 2018, 2:25 PM

Change 437923 abandoned by Hashar:
Revert "SVGFileTest::testSwitchTranslationSetRoundtrip is broken"

https://gerrit.wikimedia.org/r/437923

Umherirrender added a project: ci-test-error.Aug 4 2019, 6:11 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 4 2019, 7:10 PM
gerritbot added a comment.Jan 3 2021, 12:31 PM

Change 653737 had a related patch set uploaded (by Umherirrender; owner: Hashar):
[mediawiki/extensions/TranslateSvg@REL1_31] SVGFileTest::testSwitchTranslationSetRoundtrip is broken

https://gerrit.wikimedia.org/r/653737

gerritbot added a project: Patch-For-Review.Jan 3 2021, 12:31 PM
gerritbot added a comment.Jan 3 2021, 1:15 PM

Change 653737 merged by Umherirrender:
[mediawiki/extensions/TranslateSvg@REL1_31] SVGFileTest::testSwitchTranslationSetRoundtrip is broken

https://gerrit.wikimedia.org/r/653737

Umherirrender unsubscribed.Nov 24 2021, 7:43 PM
Aklapper closed this task as Declined.Sep 16 2023, 3:36 PM
Aklapper removed a project: Patch-For-Review.

Declining per T331817: Archive the TranslateSvg extension

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits