Page MenuHomePhabricator
Create Task
Maniphest T184409

Create the API module allowing editing the representation, and the grammatical features of a Form (days: 4)
Closed, ResolvedPublic
Actions

Description

The API module should allow changing the list of representations of a form, and/or changing its grammatical features.

The API module is intended for the Lexeme page UI only.

API specification:

  • input:
    • formId
    • data: JSON array, containing representations and grammatical features after the edit, e.g.
{
  "representations": {
    "en-gb": "colours",
    "en-us": "colors",
  },
  "grammaticalFeatures: ["Q666"]
}
  • action-specific fields in the response:
    • form: JSON representation of the saved form
    • lastrevid: revision ID
  • edit summary format: TBC

Details

SubjectRepoBranchLines +/-
Add API action for editing elements of a formmediawiki/extensions/WikibaseLexememaster+1 K -0
Added tests for classes related to EditFormElements APImediawiki/extensions/WikibaseLexememaster+482 -0
Add revision ID to the response of edit form elements APImediawiki/extensions/WikibaseLexememaster+39 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek triaged this task as High priority.EditedJan 8 2018, 9:52 AM
WMDE-leszek created this task.

The API input and response format should be specified here, so that the task for using the API in the UI (T184411) could be tackled independently!

WMDE-leszek mentioned this in T184411: UI: Use the API to save edits of grammatical features of the form (days: 1).Jan 8 2018, 9:54 AM
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek claimed this task.Jan 8 2018, 3:30 PM
WMDE-leszek moved this task from Backlog to In Progress on the Wikidata-Sprint-2018-01-03 board.

Will update the task description in a bit. Experimenting here and there, to get the possibly full specs.

WMDE-leszek updated the task description. (Show Details)Jan 8 2018, 4:17 PM
WMDE-leszek updated the task description. (Show Details)
gerritbot added a comment.Jan 10 2018, 12:13 PM

Change 402868 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Add API action for editing elements of a form

https://gerrit.wikimedia.org/r/402868

gerritbot added a project: Patch-For-Review.Jan 10 2018, 12:13 PM
WMDE-leszek mentioned this in rEWLE7bb0f8f186b9: [WIP] Add API action for editing elements of a form.Jan 10 2018, 12:14 PM
Ladsgroup mentioned this in rEWLEb9a7375d8521: [WIP] Add API action for editing elements of a form.Jan 10 2018, 2:22 PM
WMDE-leszek added subscribers: • Jonas, Ladsgroup.EditedJan 10 2018, 2:43 PM

@Lydia_Pintscher: re what the edit summary should look like, please find below the cases I believe are possible

Represetations

Before: EN color
After: EN colour

Summary: ?

Before: EN-GB colour, EN-US color
After: EN-GB-colour

Summary: ?

Before: EN-GB colour
After: EN-GB colour, EN-US color

Summary: ?

Grammatical features

Before: Q666 (dative)
After: Q777 (accusative)

Summary: ?

Before: Q666 (dative), Q888 (singular)
After: Q666 (dative)

Summary: ?

Before: Q666 (dative)
After: Q666 (dative), Q888 (singular)

Summary: ?

Bonus question: It's been decided once that when the user changes both representation(s) and grammatical feature(s), and then clicks save, the changes she made are stored as a single edit, thus there is a single edit summary to consider. Question then: How would the summary look in such a case?
Hint: one couldn't refer to item/property changes AFAIK, as when e.g. changing the label, and the description, and then saving, there are two edits saved on the item/property, and each has an edit summary about the respective field.

Ladsgroup mentioned this in rEWLEdeb4e755db32: Add API action for editing elements of a form.Jan 10 2018, 3:32 PM
Ladsgroup mentioned this in rEWLE83c91fb16122: Add API action for editing elements of a form.Jan 10 2018, 3:35 PM
gerritbot added a comment.Jan 10 2018, 5:58 PM

Change 403449 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Added tests for classes related to EditFormElements API

https://gerrit.wikimedia.org/r/403449

WMDE-leszek mentioned this in rEWLE0159ccc3c710: Added tests for classes related to EditFormElements API.Jan 10 2018, 6:01 PM
WMDE-leszek mentioned this in rEWLEf4adeed13bd5: Added tests for classes related to EditFormElements API.Jan 10 2018, 6:04 PM
WMDE-leszek mentioned this in rEWLE8dbd7033ab73: Add API action for editing elements of a form.
Ladsgroup mentioned this in rEWLEa9ac7ba4b57d: Add API action for editing elements of a form.Jan 11 2018, 5:47 AM
Ladsgroup mentioned this in rEWLEfa782f13b1a0: Added tests for classes related to EditFormElements API.Jan 11 2018, 6:01 AM
Ladsgroup moved this task from In Progress to Review on the Wikidata-Sprint-2018-01-03 board.Jan 11 2018, 6:02 AM
WMDE-leszek renamed this task from Create the API module allowing editing the representation, and the grammatical features of a Form to Create the API module allowing editing the representation, and the grammatical features of a Form (days: 1).Jan 11 2018, 9:36 AM
WMDE-leszek added a comment.Jan 11 2018, 11:25 AM

The summary part has been moved to the separate task: T184702.

WMDE-leszek mentioned this in rEWLE5d3a5c439925: Add API action for editing elements of a form.Jan 11 2018, 5:37 PM
WMDE-leszek mentioned this in rEWLEc80779f2fbff: Added tests for classes related to EditFormElements API.
WMDE-leszek mentioned this in rEWLE4eea5fd844b5: Add API action for editing elements of a form.Jan 11 2018, 5:40 PM
WMDE-leszek mentioned this in rEWLE2bb58eaee772: Add API action for editing elements of a form.Jan 11 2018, 5:43 PM
WMDE-leszek mentioned this in rEWLE1f99022e4cb0: Added tests for classes related to EditFormElements API.
gerritbot added a comment.Jan 11 2018, 5:50 PM

Change 403716 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Add revision ID to the response of edit form elements API

https://gerrit.wikimedia.org/r/403716

WMDE-leszek mentioned this in rEWLEe7be12278e48: Add revision ID to the response of edit form elements API.Jan 11 2018, 5:53 PM
gerritbot added a comment.Jan 12 2018, 10:17 AM

Change 403716 abandoned by WMDE-leszek:
Add revision ID to the response of edit form elements API

Reason:
Having thought about it for more than 3 minutes, I have realized this is not needed, and could even lead to bugs, so ditching this before anyone notices!

https://gerrit.wikimedia.org/r/403716

WMDE-leszek renamed this task from Create the API module allowing editing the representation, and the grammatical features of a Form (days: 1) to Create the API module allowing editing the representation, and the grammatical features of a Form (days: 2).Jan 13 2018, 11:39 AM
WMDE-leszek renamed this task from Create the API module allowing editing the representation, and the grammatical features of a Form (days: 2) to Create the API module allowing editing the representation, and the grammatical features of a Form (days: 3).Jan 15 2018, 5:23 PM
WMDE-leszek added a project: Wikidata-Sprint-2018-01-17.Jan 16 2018, 1:49 PM
Lydia_Pintscher moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-17 board.Jan 16 2018, 1:50 PM
WMDE-leszek renamed this task from Create the API module allowing editing the representation, and the grammatical features of a Form (days: 3) to Create the API module allowing editing the representation, and the grammatical features of a Form (days: 4).Jan 16 2018, 3:33 PM
gerritbot added a comment.Jan 17 2018, 8:06 AM

Change 402868 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add API action for editing elements of a form

https://gerrit.wikimedia.org/r/402868

gerritbot added a comment.Jan 17 2018, 8:06 AM

Change 403449 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Added tests for classes related to EditFormElements API

https://gerrit.wikimedia.org/r/403449

WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint-2018-01-03 board.Jan 17 2018, 8:26 AM
WMDE-leszek closed this task as Resolved.Jan 17 2018, 11:08 AM
WMDE-leszek removed a project: Wikidata-Sprint-2018-01-17.
thiemowmde mentioned this in T185486: [Bug] wblexemeeditformelements API requires to resubmit unrelated values.Jan 22 2018, 1:04 PM
thiemowmde added a parent task: T185486: [Bug] wblexemeeditformelements API requires to resubmit unrelated values.
• 238482n375 removed WMDE-leszek as the assignee of this task.Jun 15 2018, 8:02 AM
• 238482n375 lowered the priority of this task from High to Lowest.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

• 238482n375 set Security to Software security bug.Jun 15 2018, 8:05 AM
• 238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper assigned this task to WMDE-leszek.Jun 15 2018, 1:49 PM
Aklapper raised the priority of this task from Lowest to High.Jun 15 2018, 1:49 PM
Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.
Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.
Restricted Application added a project: acl*security. · View Herald TranscriptJun 15 2018, 1:49 PM
Aklapper removed a project: acl*security.Jun 15 2018, 1:51 PM
Aklapper changed the visibility from "Custom Policy" to "Public (No Login Required)".
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits