Page MenuHomePhabricator
Create Task
Maniphest T184689

SpecialMobileContributions - Fatal exception of type "MediaWiki\Storage\RevisionAccessException"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Visible @ https://meta.m.wikimedia.org/wiki/Special:Contributions/SolidBlock.
( also at https://he.m.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%AA%D7%A8%D7%95%D7%9E%D7%95%D7%AA/%D7%9E%D7%99%D7%9C%D7%90%D7%92%D7%A8%D7%95 and I imagine other places)

The non mobile contributions page works just fine.

Logstash: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.01.10/mediawiki/?id=AWDiHalkhTduSC7pBdmH

[{exception_id}] {exception_url}   MediaWiki\Storage\RevisionAccessException from line 248 of /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php: Could not determine title for page ID 10005922 and revision ID 15512228
#0 /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php(1110): MediaWiki\Storage\RevisionStore->getTitle(string, string, integer)
#1 /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php(1144): MediaWiki\Storage\RevisionStore->newRevisionFromRow_1_29(stdClass, integer, NULL)
#2 /srv/mediawiki/php-1.31.0-wmf.16/includes/Revision.php(505): MediaWiki\Storage\RevisionStore->newRevisionFromRow(stdClass, integer, NULL)
#3 /srv/mediawiki/php-1.31.0-wmf.16/extensions/MobileFrontend/includes/specials/SpecialMobileContributions.php(93): Revision->__construct(stdClass)
#4 /srv/mediawiki/php-1.31.0-wmf.16/extensions/MobileFrontend/includes/specials/SpecialMobileContributions.php(74): SpecialMobileContributions->showContributions(Wikimedia\Rdbms\ResultWrapper)
#5 /srv/mediawiki/php-1.31.0-wmf.16/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php(57): SpecialMobileContributions->executeWhenAvailable(string)
#6 /srv/mediawiki/php-1.31.0-wmf.16/extensions/MobileFrontend/includes/specials/MobileSpecialPageFeed.php(23): MobileSpecialPage->execute(string)
#7 /srv/mediawiki/php-1.31.0-wmf.16/includes/specialpage/SpecialPage.php(522): MobileSpecialPageFeed->execute(string)
#8 /srv/mediawiki/php-1.31.0-wmf.16/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(string)
#9 /srv/mediawiki/php-1.31.0-wmf.16/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#10 /srv/mediawiki/php-1.31.0-wmf.16/includes/MediaWiki.php(854): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.31.0-wmf.16/includes/MediaWiki.php(524): MediaWiki->main()
#12 /srv/mediawiki/php-1.31.0-wmf.16/index.php(42): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): include(string)
#14 {main}

Details

SubjectRepoBranchLines +/-
Make Revision::__construct work with bad page IDmediawiki/corewmf/1.31.0-wmf.16+72 -3
Make Revision::__construct work with bad page IDmediawiki/coremaster+72 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jan 11 2018, 9:40 AM
Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 11 2018, 9:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore updated the task description. (Show Details)Jan 11 2018, 9:41 AM
Addshore updated the task description. (Show Details)Jan 11 2018, 9:44 AM

It looks like the pageid doesn't exist, but the revid does exist.

mysql:wikiadmin@db1086 [metawiki]> select count(*) from page where page_id = 10005922;
+----------+
| count(*) |
+----------+
|        0 |
+----------+
1 row in set (0.00 sec)

mysql:wikiadmin@db1086 [metawiki]> select count(*) from revision where rev_id = 15512228;
+----------+
| count(*) |
+----------+
|        1 |
+----------+
1 row in set (0.00 sec)
Addshore updated the task description. (Show Details)Jan 11 2018, 9:49 AM
phuedx subscribed.Jan 11 2018, 10:46 AM
daniel added a comment.Jan 11 2018, 12:05 PM

Is this a new revision? Is the implication that this inconsistency is caused by the new RevisionStore code? Or is the issue just that this inconsistency now triggers an unhandled exception?

daniel added a comment.Jan 11 2018, 12:13 PM

Ah, no, it's an old revision - rev_timestamp = 20140528135706.

So, the new code is less forgiving. That's OK as such, as long as the compat code in Revision emulates the old, more forgiving behavior.

The question is - how should the compat code in the Revision constructor behave when the page referenced by the revision row does not exist? To be compatible, it seems to me it should construct a dummy title with page_id = 0.

daniel moved this task from Inbox to Done on the Multi-Content-Revisions board.Jan 11 2018, 1:02 PM
daniel moved this task from Done to Next on the Multi-Content-Revisions board.EditedJan 11 2018, 1:12 PM

I don't see a good way to handle this without making RevisionStore::getTitle public and calling it in Revision::__construct. Thoughts?

daniel triaged this task as High priority.Jan 11 2018, 1:14 PM
Addshore added a parent task: T180749: 1.31.0-wmf.16 deployment blockers.Jan 11 2018, 2:50 PM
Addshore reassigned this task from Addshore to daniel.Jan 11 2018, 3:00 PM
Addshore moved this task from Next to Done on the Multi-Content-Revisions board.
gerritbot subscribed.Jan 11 2018, 3:44 PM

Change 403682 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make Revision::__construct work with bad page ID

https://gerrit.wikimedia.org/r/403682

gerritbot added a project: Patch-For-Review.Jan 11 2018, 3:44 PM
gerritbot added a comment.Jan 11 2018, 4:25 PM

Change 403693 had a related patch set uploaded (by Addshore; owner: Daniel Kinzler):
[mediawiki/core@wmf/1.31.0-wmf.16] Make Revision::__construct work with bad page ID

https://gerrit.wikimedia.org/r/403693

gerritbot added a comment.Jan 11 2018, 4:33 PM

Change 403682 merged by jenkins-bot:
[mediawiki/core@master] Make Revision::__construct work with bad page ID

https://gerrit.wikimedia.org/r/403682

gerritbot added a comment.Jan 11 2018, 7:29 PM

Change 403693 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.16] Make Revision::__construct work with bad page ID

https://gerrit.wikimedia.org/r/403693

Addshore closed this task as Resolved.Jan 11 2018, 8:15 PM
Addshore moved this task from Unsorted 💣 to Closing ✔️ on the User-Addshore board.Jan 12 2018, 11:59 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 13 2018, 7:22 PM
CCicalese_WMF moved this task from Done to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 10 2018, 4:49 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.
CCicalese_WMF moved this task from Backlog to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 10 2018, 5:06 PM
• 238482n375 removed daniel as the assignee of this task.Jun 15 2018, 8:03 AM
• 238482n375 lowered the priority of this task from High to Lowest.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper assigned this task to daniel.Jun 15 2018, 1:06 PM
Aklapper raised the priority of this task from Lowest to High.Jun 15 2018, 1:07 PM
Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.
Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.
CCicalese_WMF removed a project: Patch-For-Review.Jul 10 2018, 3:26 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL