Page MenuHomePhabricator
Create Task
Maniphest T184882

Scap: TypeError: error: (not all arguments converted during string formatting); format string: (Passed unrecognized git_binary_manager {}); arguments: ((u'fat',))
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Scap: git_fat -> git_binary_manageroperations/software/logstash-logback-encodermaster+1 -1
Scap: git_fat -> git_binary_manageroperations/software/cassandra-metrics-collectormaster+1 -1
Scap: git_fat -> git_binary_manageroperations/software/cassandra-twcsmaster+1 -1
Scap: git_fat -> git_binary_manageroperations/software/logstash/pluginsmaster+1 -1
Scap: git_fat -> git_binary_manageroperations/software/prometheus_jmx_exportermaster+1 -1
Fix gerrit support for latest scap versionoperations/software/gerritmaster+1 -1
Scap: git_fat -> git_binary_managerwikidata/query/deploymaster+1 -1
Scap: git_fat -> git_binary_managersearch/MjoLniR/deploymaster+1 -1
Customize query in gerrit

Revisions and Commits

Restricted Differential Revision

Related Objects

Event Timeline

thcipriani created this task.Jan 14 2018, 9:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2018, 9:41 PM
thcipriani added a revision: Restricted Differential Revision.Jan 14 2018, 9:42 PM
thcipriani mentioned this in rMSCAc95c5c8282a4: Fix unrecognized git_binary_manager compatibility.Jan 14 2018, 9:55 PM
thcipriani mentioned this in T127762: Update Debian Package for Scap3.Jan 14 2018, 10:04 PM
thcipriani triaged this task as Unbreak Now! priority.Jan 14 2018, 10:11 PM

This error is currently in scap version 3.7.5-1 that was released to production on Friday and that means that any repo currently using the:

git_fat: True

Line in its scap.cfg will find that git-fat does not rehydrate files. The work-around for individual repos is to change the git_fat: True line to:

git_binary_manager: git-fat

Patches for all affected repos incoming, also D945 fixes this inside scap and I have pushed tags for a new scap release for version 3.7.6-1 (T127762#3899642) whenever scap 3.7.6-1 is released this should no longer be an issue. The configuration change above is a new method of specifying git binary file managers (in future it will also support git-lfs) and should be a valid workaround in the mean-time.

Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptJan 14 2018, 10:11 PM
gerritbot subscribed.Jan 14 2018, 10:15 PM

Change 404221 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/software/gerrit@master] Fix gerrit support for latest scap version

https://gerrit.wikimedia.org/r/404221

gerritbot added a project: Patch-For-Review.Jan 14 2018, 10:15 PM
Paladox subscribed.Jan 14 2018, 10:17 PM
Paladox mentioned this in rGERRITDEPLOY70a20b45c9e2: Fix gerrit support for latest scap version.Jan 14 2018, 10:20 PM
gerritbot added a comment.Jan 14 2018, 11:03 PM

Change 404222 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/software/logstash/plugins@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404222

gerritbot added a comment.Jan 14 2018, 11:04 PM

Change 404223 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[wikidata/query/deploy@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404223

gerritbot added a comment.Jan 14 2018, 11:05 PM

Change 404224 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/software/prometheus_jmx_exporter@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404224

gerritbot added a comment.Jan 14 2018, 11:05 PM

Change 404225 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[search/MjoLniR/deploy@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404225

gerritbot added a comment.Jan 14 2018, 11:05 PM

Change 404226 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/software/cassandra-metrics-collector@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404226

gerritbot added a comment.Jan 14 2018, 11:06 PM

Change 404227 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/software/logstash-logback-encoder@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404227

gerritbot added a comment.Jan 14 2018, 11:07 PM

Change 404228 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/software/cassandra-twcs@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404228

thcipriani lowered the priority of this task from Unbreak Now! to High.Jan 14 2018, 11:52 PM

Current status is that repo owners depending on git_fat either have to wait for scap 3.7.6-1 to be released, or merge the patch I made against their repository from this ticket in order to deploy.

Lowering from UBN to High as this no longer prevents deployments, but is still a serious issue.

thcipriani mentioned this in rOSPJc04052e63b6a: Scap: git_fat -> git_binary_manager.Jan 15 2018, 3:50 AM
thcipriani mentioned this in rOSCW39dcc6e54014: Scap: git_fat -> git_binary_manager.Jan 15 2018, 4:45 AM
• demon added a comment.Jan 15 2018, 6:25 PM

This kinda sucks because we'll need to follow-up with another fix when D921 lands. D917 shouldn't have gone out without the follow-up :(

gerritbot added a comment.Jan 16 2018, 3:28 PM

Change 404225 merged by DCausse:
[search/MjoLniR/deploy@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404225

gerritbot added a comment.Jan 17 2018, 4:27 PM

Change 404223 merged by Smalyshev:
[wikidata/query/deploy@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404223

thcipriani lowered the priority of this task from High to Low.Jan 17 2018, 4:36 PM

Leaving this task open for all the git_fat -> git_binary_manager changes I made, but since the new version of scap was released yesterday, that doesn't need to happen as desperately anymore.

gerritbot added a comment.Feb 9 2018, 4:29 PM

Change 404221 merged by Chad:
[operations/software/gerrit@master] Fix gerrit support for latest scap version

https://gerrit.wikimedia.org/r/404221

• demon mentioned this in rGERRITDEPLOY7ca3b026ef00: Fix gerrit support for latest scap version.Feb 9 2018, 4:31 PM
• mmodell added a comment.Feb 15 2018, 7:49 AM

can this be closed, then?

thcipriani closed this task as Resolved.Jul 11 2018, 4:51 PM
thcipriani claimed this task.
In T184882#3974762, @mmodell wrote:

can this be closed, then?

yep

Liuxinyu970226 unsubscribed.Jul 12 2018, 8:31 AM
• Razyfouad mentioned this in rOSPJ503daa1213a9: Scap: git_fat -> git_binary_manager.Apr 6 2019, 2:03 AM
• Razyfouad mentioned this in rOSCW9f53343eb3c2: Scap: git_fat -> git_binary_manager.
gerritbot added a comment.Aug 11 2020, 8:05 AM

Change 404224 abandoned by Hashar:
[operations/software/prometheus_jmx_exporter@master] Scap: git_fat -> git_binary_manager

Reason:
Actually yes from T181728 which is titled: "Stop using jmx_exporter deployed via scap in favour of Debian package". And the puppet patch actually drops the scap config entirely from puppet.

https://gerrit.wikimedia.org/r/404224

gerritbot added a comment.Aug 18 2020, 1:09 PM

Change 404222 abandoned by Hashar:
[operations/software/logstash/plugins@master] Scap: git_fat -> git_binary_manager

Reason:
We are going to use Debian packages instead of scap for deployment: https://gerrit.wikimedia.org/r/c/operations/software/logstash/plugins/ /552486

https://gerrit.wikimedia.org/r/404222

gerritbot added a comment.Aug 25 2020, 8:21 AM

Change 404228 merged by Elukey:
[operations/software/cassandra-twcs@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404228

gerritbot added a comment.Aug 25 2020, 8:22 AM

Change 404226 merged by Elukey:
[operations/software/cassandra-metrics-collector@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404226

gerritbot added a comment.Aug 25 2020, 8:22 AM

Change 404227 merged by Elukey:
[operations/software/logstash-logback-encoder@master] Scap: git_fat -> git_binary_manager

https://gerrit.wikimedia.org/r/404227

hashar added subscribers: elukey, hashar.Aug 25 2020, 8:22 AM

@elukey has kindly merged in the left over patches. Tentatively all repositories have now been updated \o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits