Page MenuHomePhabricator
Create Task
Maniphest T184938

Special:RecentChanges broken on Jenkins slaves
Closed, ResolvedPublic
Actions

Assigned To
Ladsgroup
Authored By
zeljkofilipin
Jan 15 2018, 5:34 PM
Tags
Referenced Files
F12577776: filters-are-present.png
Jan 15 2018, 5:34 PM
Subscribers
Aklapper
awight
Etonkovidova
gerritbot
Halfak
hashar
Ladsgroup
zeljkofilipin
Tokens
"Meh!" token, awarded by zeljkofilipin.

Description

While running the first Selenium test for ORES (Gerrit, Jenkins, screenshot, mw-exception.log) @Etonkovidova and I have noticed that Special:RecentChanges is completely broken in CI.

filters-are-present.png (899×1 px, 146 KB)

2018-01-15 17:17:35 ci-jessie-wikimedia-940640 jenkins_u0_mw: [a69f5628272ccfee31582e49] /jenkins-mediawiki-core-qunit-selenium-jessie-13106/index.php?title=Special:RecentChanges   InvalidArgumentException from line 58 of /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/extensions/ORES/includes/Storage/SqlModelLookup.php: No model available for [damaging]
#0 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/extensions/ORES/includes/ThresholdLookup.php(103): ORES\Storage\SqlModelLookup->getModelVersion(string)
#1 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/extensions/ORES/includes/ThresholdLookup.php(94): ORES\ThresholdLookup->fetchThresholdsFromCache(string)
#2 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/extensions/ORES/includes/ThresholdLookup.php(84): ORES\ThresholdLookup->fetchThresholds(string, boolean)
#3 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php(65): ORES\ThresholdLookup->getThresholds(string)
#4 [internal function]: ORES\Hooks\ChangesListHooksHandler::onChangesListSpecialPageStructuredFilters(SpecialRecentChanges)
#5 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/Hooks.php(177): call_user_func_array(string, array)
#6 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/Hooks.php(205): Hooks::callHook(string, string, array, NULL)
#7 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/specialpage/ChangesListSpecialPage.php(911): Hooks::run(string, array)
#8 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/specials/SpecialRecentchanges.php(184): ChangesListSpecialPage->registerFilters()
#9 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/specialpage/ChangesListSpecialPage.php(1052): SpecialRecentChanges->registerFilters()
#10 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/specialpage/ChangesListSpecialPage.php(872): ChangesListSpecialPage->setup(NULL)
#11 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/specialpage/ChangesListSpecialPage.php(558): ChangesListSpecialPage->getOptions()
#12 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/specials/SpecialRecentchanges.php(166): ChangesListSpecialPage->execute(NULL)
#13 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/specialpage/SpecialPage.php(522): SpecialRecentChanges->execute(NULL)
#14 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
#15 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#16 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/MediaWiki.php(858): MediaWiki->performRequest()
#17 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/includes/MediaWiki.php(524): MediaWiki->main()
#18 /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/index.php(42): MediaWiki->run()
#19 {main}

@hashar do you think the problem is in CI, or in ORES?

Details

SubjectRepoBranchLines +/-
SqlModelLookup.php: Document that empty cache bypasses is intentionalmediawiki/extensions/ORESmaster+1 -0
Decorator to populate the model table if it's not theremediawiki/extensions/ORESmaster+120 -4
Don't cache when sql model lookup returns emptymediawiki/extensions/ORESmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Jan 15 2018, 5:34 PM
Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptJan 15 2018, 5:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
zeljkofilipin updated the task description. (Show Details)Jan 15 2018, 5:37 PM
Ladsgroup subscribed.Jan 15 2018, 5:42 PM

I think I know what's going on here, When you install ORES extension the ores_model needs to be initialized, this process is rather automatic: Someone needs to make an edit, so the system can look up model name and versions from ores service. This won't be an issue in prod as when we enable it, immediately, someone somewhere makes an edit and the tables are filled (this automatic process is needed for updating the model version, not just initializing it, one stone, several birds). For this case, I'm pretty sure you need to make an edit before testing recent changes but I'm not sure if the service is properly set up for that, etc.

Etonkovidova added a subtask: T183606: [betalabs-ruwiki] Internal error - No model available for [goodfaith].Jan 15 2018, 6:39 PM
Etonkovidova added a subtask: T181191: Make ORES-consuming pages more robust to ORES errors.
Etonkovidova closed subtask T183606: [betalabs-ruwiki] Internal error - No model available for [goodfaith] as Resolved.Jan 15 2018, 6:43 PM
zeljkofilipin claimed this task.Jan 16 2018, 9:51 AM
zeljkofilipin triaged this task as Low priority.
zeljkofilipin added a project: User-zeljkofilipin.
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJan 16 2018, 9:51 AM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.Jan 16 2018, 9:51 AM
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin added a comment.Jan 17 2018, 3:58 PM

Special:RecentChanges is broken on a clean mediawiki-vagrant VM with the same error message. I'll test locally if creating an edit fixes the problem.

awight subscribed.Jan 17 2018, 4:00 PM

I think E:ORES should handle the corner case more gracefully. Anyway, this is something we can log, then quietly disable the thresholds in S:RecentChanges.

zeljkofilipin added a comment.Jan 17 2018, 4:17 PM

Creating a page (via API) did not fix the problem (402863/5..6): log, screenshot.

zeljkofilipin removed zeljkofilipin as the assignee of this task.Jan 18 2018, 1:12 PM
Ladsgroup claimed this task.Jan 22 2018, 10:12 PM
Ladsgroup edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.

I give this a try.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 22 2018, 10:12 PM
zeljkofilipin awarded a token.Jan 23 2018, 1:35 PM
gerritbot subscribed.Jan 24 2018, 2:37 PM

Change 406039 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Don't cache when sql model lookup returns empty

https://gerrit.wikimedia.org/r/406039

gerritbot added a project: Patch-For-Review.Jan 24 2018, 2:37 PM
gerritbot added a comment.Jan 24 2018, 4:21 PM

Change 406046 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Decorator to populate the model table if it's not there

https://gerrit.wikimedia.org/r/406046

gerritbot added a comment.Jan 24 2018, 4:25 PM

Change 406039 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Don't cache when sql model lookup returns empty

https://gerrit.wikimedia.org/r/406039

Ladsgroup added a comment.Jan 24 2018, 4:46 PM

With the patches I made this now way more understandable now: https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/13604/artifact/log/filters-are-present.png
I think fixing this should be that hard. Will take another look tomorrow.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 24 2018, 5:00 PM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Jan 24 2018, 9:44 PM
Ladsgroup added a comment.Jan 24 2018, 10:43 PM

See T184451#3922533

Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.Jan 27 2018, 11:50 AM
gerritbot added a comment.Jan 30 2018, 2:44 PM

Change 406046 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Decorator to populate the model table if it's not there

https://gerrit.wikimedia.org/r/406046

awight moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Jan 30 2018, 5:40 PM
Halfak closed subtask T181191: Make ORES-consuming pages more robust to ORES errors as Resolved.Jan 30 2018, 8:31 PM
greg moved this task from In-progress to Blocked (externally) on the Release-Engineering-Team (Kanban) board.Feb 8 2018, 5:05 PM
zeljkofilipin added a comment.Feb 19 2018, 3:56 PM

@Ladsgroup this is resolved, right? Is there anything left to do here, or can this task be resolved?

Ladsgroup closed this task as Resolved.Feb 19 2018, 4:13 PM

yup

Halfak moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Feb 20 2018, 3:32 PM
awight mentioned this in Unknown Object (Phame Post).May 2 2018, 6:42 PM
awight mentioned this in Unknown Object (Phame Post).
awight mentioned this in Unknown Object (Phame Post).
awight mentioned this in Blog Post: Status Update (May 2, 2018).
awight mentioned this in T197647: Gracefully handle edge case where wiki is not receiving edits.Jun 19 2018, 8:02 AM
gerritbot added a comment.Mar 11 2024, 4:36 PM

Change 1010236 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/ORES@master] SqlModelLookup.php: Document that empty cache bypasses is intentional

https://gerrit.wikimedia.org/r/1010236

gerritbot added a comment.Mar 12 2024, 7:02 AM

Change 1010236 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] SqlModelLookup.php: Document that empty cache bypasses is intentional

https://gerrit.wikimedia.org/r/1010236

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2024, 7:30 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 12 2024, 8:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits