TODO seen here: https://gerrit.wikimedia.org/r/#/c/406416/1/modules/ve-mw/ui/ve.ui.MWWikitextSurface.js
We have methods on the surface for converting between source and nwe offsets so should be a case of re-implementing the method form jquery.textSelection.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T132023 VisualEditor support for editing inside CollaborationKit | |||
| Open | Feature | None | T138636 Allow using VisualEditor on Special:MassMessage | ||
| Open | None | T138642 VisualEditor should provide a clean integrated VE/WT editor widget that can be integrated into any context | |||
| Open | None | T130400 (Actually) Add wikitext support for citoid for automatic reference insertion | |||
| Open | None | T90864 Help VisualEditor users find the wikitext "Save" button | |||
| Open | None | T171974 Improve and consolidate our unified editing platform so that it's great on all devices | |||
| Open | None | T104479 Provide a modern wikitext editor | |||
| Open | None | T142523 Provide a second version of a beta modern wikitext editor integrated into the visual editor | |||
| Resolved | Esanders | T185992 NWE: Provide API supporting majority of calls and integrations Gadgets make with wikitext editor | |||
| Resolved | matmarex | T185917 Implement $.textSelection's replaceSelection and encapsulateSelection in NWE |
I've started working on this, and then realized that we should be able to implement $.textSelection's encapsulateSelection in terms of the other $.textSelection functions. This way we won't have to duplicate this 100-line monster in every custom wikitext editor.
Change 408465 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] jquery.textSelection: Implement 'encapsulateSelection' in terms of the other commands
Change 408466 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWWikitextSurface: Remove unnecessary textSelection 'encapsulateSelection' override
On second thought, I'm not sure if that was the best idea… This now essentially works by replacing the entire contents of the editor, which a) sometimes causes the scroll position to jump and b) generates inefficient transactions. I might have to come back to this, and do it the boring way.
Alternatively you could add some more arguments to setContents ( e.g. start, [end] ) such that you could use it for replacements.
(NB there is another textSelection implementation in CodeMirror that is 90% encapsulateSelection that could be replaced with a single line codeMirror.doc.replaceSelection( insertText );)
Change 409110 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] jquery.textSelection: Add 'replaceSelection' method
Change 408465 merged by jenkins-bot:
[mediawiki/core@master] jquery.textSelection: Implement 'encapsulateSelection' in terms of the other commands
Change 409110 merged by jenkins-bot:
[mediawiki/core@master] jquery.textSelection: Add 'replaceSelection' method
Change 408466 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection'
This change seems to have broken Page: pages editing interface used by Wikisource: T187454
Hmm, that's unfortunate, but I think we can work around it in ProofreadPage. I'll reply on that task.