Page MenuHomePhabricator
Create Task
Maniphest T186302

Promote LuaSandbox as its own project, separate from Scribunto
Closed, ResolvedPublic
Actions

Description

I'm tagging this as in the spirit of Librarization even though it's already technically separate.

We should treat LuaSandbox as its own project, and not just a component of Scribunto.

This would include having a separate Phab project to track bugs, a wiki page with documentation to begin with. I'm not sure whether it makes sense to also submit it to PECL / how that all works, but that's another thing to consider.

My motivation is that I keep seeing people mention https://github.com/phpv8/v8js but it seems barely anyone knows about luasandbox, and the rationale of why we decided running lua is better than JS.

Details

SubjectRepoBranchLines +/-
doc: Add more luasandbox linksintegration/docrootmaster+14 -12
Enable 'publish' pipeline job for luasandboxintegration/configmaster+2 -0
PECL packagingmediawiki/php/luasandboxmaster+99 -22
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Feb 2 2018, 6:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2018, 6:44 AM
Legoktm mentioned this in T186303: Librarize LuaSandbox/LuaStandalone.Feb 2 2018, 6:49 AM
Anomie awarded a token.Feb 2 2018, 3:17 PM
Legoktm added a project: LuaSandbox.Feb 3 2018, 10:53 PM
Legoktm added a comment.Feb 23 2018, 10:33 PM

We now have:

:D

The only other thing I was thinking of was whether we could get LuaSandbox listed on https://secure.php.net/manual/en/refs.basic.other.php along with it's documentation.

Anomie added a comment.Feb 24 2018, 12:10 AM
In T186302#3997895, @Legoktm wrote:

The only other thing I was thinking of was whether we could get LuaSandbox listed on https://secure.php.net/manual/en/refs.basic.other.php along with it's documentation.

I see that page has an edit link in the upper right. It'll even let you log in anonymously. It's not clear what to do from there, so I'll probably leave it to someone else to figure out. I don't know whether they have any requirements like having to have it in pecl first.

Tgr added a parent task: T171073: Promote FLOSS libraries developed by the Foundation/movement.Feb 24 2018, 7:25 PM
• bd808 subscribed.Feb 26 2018, 3:43 PM
alex-mashin subscribed.Mar 15 2018, 9:17 AM
Legoktm moved this task from Untriaged to To Do on the Librarization board.Jun 1 2018, 4:18 AM
• tstarling subscribed.Sep 24 2018, 5:26 AM

I started the process of adding LuaSandbox to PECL: https://marc.info/?l=pecl-dev&m=153776610925078&w=2

I believe an extension is supposed to be in PECL before it is added to the manual.

gerritbot subscribed.Oct 5 2018, 6:06 AM

Change 464758 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/php/luasandbox@master] PECL packaging

https://gerrit.wikimedia.org/r/464758

gerritbot added a project: Patch-For-Review.Oct 5 2018, 6:06 AM
Krinkle subscribed.Oct 5 2018, 7:00 AM
gerritbot added a comment.Oct 8 2018, 10:18 PM

Change 464758 merged by jenkins-bot:
[mediawiki/php/luasandbox@master] PECL packaging

https://gerrit.wikimedia.org/r/464758

Ricordisamoa subscribed.Aug 26 2019, 8:35 PM
Krinkle added a project: Platform Engineering.Apr 27 2020, 4:31 PM
Krinkle added a comment.Apr 27 2020, 4:33 PM

It looks like this was done!

Is there something left to do?

gerritbot added a comment.Apr 27 2020, 4:41 PM

Change 592706 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[integration/config@master] Enable 'publish' pipeline job for luasandbox

https://gerrit.wikimedia.org/r/592706

gerritbot added a comment.Apr 27 2020, 4:43 PM

Change 592706 merged by jenkins-bot:
[integration/config@master] Enable 'publish' pipeline job for luasandbox

https://gerrit.wikimedia.org/r/592706

Stashbot added a comment.Apr 27 2020, 4:58 PM

Mentioned in SAL (#wikimedia-releng) [2020-04-27T16:58:53Z] <Krinkle> krinkle@contint1001$ Replay zuul event for luasandbox@3.0.3 tag to publish docs at https://doc.wikimedia.org/mediawiki-php-luasandbox/3.0.3/ - T186302

gerritbot added a comment.Apr 28 2020, 12:52 AM

Change 592796 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[integration/docroot@master] doc: Add more luasandbox links

https://gerrit.wikimedia.org/r/592796

daniel moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Apr 28 2020, 11:59 AM
gerritbot added a comment.Apr 28 2020, 4:24 PM

Change 592796 merged by jenkins-bot:
[integration/docroot@master] doc: Add more luasandbox links

https://gerrit.wikimedia.org/r/592796

• eprodromou triaged this task as Medium priority.Apr 28 2020, 8:13 PM
• eprodromou moved this task from Triage Meeting Inbox to Tracking/Watching on the Platform Engineering board.
• eprodromou subscribed.

This seems to be complete. @tstarling please close this if it's resolved.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:02 PM
Pppery removed a project: Patch-For-Review.Mar 31 2023, 12:21 AM
Pppery subscribed.

Almost 3 years later, can this be closed as resolved?

Legoktm closed this task as Resolved.Jul 6 2023, 6:33 AM

A blog post would be nice but we can do that with this closed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits