This is a side effect of T52769 which fixed the template-generated ref list being completely static in all cases.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Render reference list from originalDomElements until modified | mediawiki/extensions/Cite | master | +19 -0 |
Related Objects
Related Objects
- Mentioned In
- T52769: Adding or updating a reference in VisualEditor does not update fake references blocks inside templates
- Mentioned Here
- T198477: [he.wiki] Reference list is emptied when adding a new reference on a wiki that uses template generated references (not <ref> tags)
T30980: parser tags such as <ref>, <poem>, <timeline> etc. cannot be localized
T52769: Adding or updating a reference in VisualEditor does not update fake references blocks inside templates
Event Timeline
Comment Actions
Working on the assumption that the root cause isn't going to be fixed anytime soon, I will first attempt to have reference list nodes use their Parsoid-provided references until the ref list has changed. This should result in a performance boost for other users too, as they won't need to re-render the ref list on load.
If this doesn't work I'll create a feature flag to disable T52769 so he.wiki can disable it.
Comment Actions
Change 411101 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Cite@master] Render reference list from originalDomElements until modified
Comment Actions
In local tests, [[Barrack Obama]] spends about 1200ms rendering the root node (the whole doc) of which 700ms is spent on the ref list. After this patch the ref list takes 150ms.
Comment Actions
By the way, I saw such generated references in other wikis too. Ruwiki, and even enwiki, something with CS1.
Comment Actions
This bug means that when you read https://en.wikipedia.org/wiki/Breast_cancer_awareness#Notes you see 93 entries, but when you edit that page, you see only one in that list, because 92 of them are generated by {{sfn}}, which the visual editor has never supported.
Previously, when you edited that page, you saw all 93 of them, but the list never changed, even if you blanked most of the article or added dozens of new refs.
Neither of these are particularly desirable situations, but other than "don't use {{sfn}}", I don't think we have very many viable options right now.
Comment Actions
Oh Boy. Hewiki uses only such references, because of direction problem. Can't fix just the part of previous edits, and drop the ability to see the new ones, created by such templates?
Comment Actions
This team is good and consistent in flagging items for Tech News consideration.
Next time, please add the relevant tag to the task, or suggest that is added, so that they are also aware and can help with wording, in case. TY!
Comment Actions
Of course, no problem. I did this just because Johan somehow believes I'm a part of Tech News team, with three more people. So, what was wrong?
Comment Actions
If there's really something unclear in my message (your comment doesn't really relate much to what I wrote), you can move this conversation to my Meta talk page or wherever you see fit.
Comment Actions
Change 411101 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Render reference list from originalDomElements until modified
Comment Actions
Hi, @Deskana, are you sure it's resolved? It's better than before, but still does not work well.
Comment Actions
I can't reproduce your problem. When editing the San Francisco Chronicle article on the Hebrew Wikipedia (https://he.wikipedia.org/wiki/סן_פרנסיסקו_כרוניקל) the references, which are generated by a template, are still visible; see the bottom right of the screenshot below.
Please do not reopen tasks simply saying that things "still do not work" without screenshots and reproduction steps.
Comment Actions
I can't reproduce your problem. When editing the San Francisco Chronicle article on the Hebrew Wikipedia (https://he.wikipedia.org/wiki/סן_פרנסיסקו_כרוניקל) the references, which are generated by a template, are still visible; see the bottom right of the screenshot below.
Please do not reopen tasks simply saying that things "still do not work" without screenshots and reproduction steps.
Hi, @Deskana. I am very surprised that you could not reproduce the problem - the feature simply does not work. The steps are just the usage of these refs. But very well, here you are again:
- Open some page, for example this one.
- Start VE editing.
- Add a ref, using, for example, cite-manual-basic form.
- Check the references section.
Could you reopen the task, please? Thank you.
Comment Actions
"Check the references section" for what exactly? What do you expect to see, and what do you actually see? Please provide screenshots.
Could you reopen the task, please? Thank you.
Provide clear reproduction steps, and then we'll see what the best course of action is.
Comment Actions
I expect to see refs, but I do not see them. I'll bring you the screenshots, @Deskana, in five minutes.
Comment Actions
I think that Step 3, in which you click the Cite button, is the key point. While you're doing non-ref-related editing, or even editing existing ref-mimicking templates, everything's fine. The refs don't disappear until you try to insert a new one.
Comment Actions
Hello, everyone. Now, when I proved ten times that the problem still exist, and at least @Whatamidoing-WMF saw this, can somebody reopen the task? Please!!!
Comment Actions
@IKhitron For the record, there were a few things you could've done here to have helped things move along. Saying "It's better than before, but still does not work well." is not a helpful bug report: you need to provide a specific description of the problem you're having, with detailed reproduction steps. When I asked for steps, you provided more detail, but you still didn't actually describe what the problem was, ending your steps with "Check the references section." with no screenshots. After I asked again, you finally provided the necessary information and screenshots. In the future, please provide specific details of what you did, what you expect to see, and what you actually see, preferably with screenshots; if you'd done this (like I just did in T198477), we could've skipped all this back-and-forth.
Anyway, I've put all the steps and such in T198477; the work will happen in that task, as it's better practice to track work in smaller actionable tasks rather than huge tasks that are repeatedly opened and closed.