Page MenuHomePhabricator

Saved filters empty state needs adjustment
Closed, ResolvedPublic


After the update on icons and default text sizes, the empty state of the Saved filters menu needs some adjustments.

Currently the title is not aligned vertically with the icon, there is too much separation with the information below it, and such information text has too little separation between lines. Below is an example of the current issues and the proposed adjustments:

Screen Shot 2018-04-05 at 16.38.06.png (266×398 px, 26 KB)
Screen Shot 2018-04-05 at 16.52.33.png (266×398 px, 23 KB)

The changes proposed are:

  • Adjust the "No filters saved" top margin to be 3px. Since the text font-size is 14px tall and the icon is 20px tall, this 3px should center the text.
  • Adjust the "No filters saved" bottom margin to be 7px (3x to keep it centered as mentioned above + 4px separation)
  • Adjust the explanation text to use the standard 1.5em line height.

Event Timeline

Change 440072 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[mediawiki/core@master] Adjust layout for saved filters empty state

Change 440072 merged by jenkins-bot:
[mediawiki/core@master] Adjust layout for saved filters empty state

Etonkovidova subscribed.

Checked in betalabs - the layout looks according to the specs:

Screen Shot 2018-06-21 at 9.23.46 AM.png (272×365 px, 31 KB)