Page MenuHomePhabricator
Create Task
Maniphest T191988

[Regression pre-wmf.30] Giant checkmarks appearing in link inspector
Closed, ResolvedPublic
Actions

Description

image.png (589×423 px, 21 KB)

Details

SubjectRepoBranchLines +/-
Remove checkIcon from TitleOptionWidgetmediawiki/coremaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Apr 11 2018, 3:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2018, 3:22 PM
Esanders triaged this task as Unbreak Now! priority.Apr 11 2018, 3:31 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 11 2018, 3:31 PM
Ryasmeen subscribed.Apr 11 2018, 6:33 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Apr 11 2018, 9:18 PM
gerritbot subscribed.Apr 11 2018, 9:22 PM

Change 425714 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Remove checkIcon from TitleOptionWidget

https://gerrit.wikimedia.org/r/425714

gerritbot added a project: Patch-For-Review.Apr 11 2018, 9:22 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Apr 11 2018, 9:25 PM
Jdforrester-WMF added projects: OOUI, Contributors-Team.Apr 11 2018, 9:32 PM
Jdforrester-WMF subscribed.
matmarex mentioned this in T191474: Hard-coded checkmarks need to be replaced by IconWidget.Apr 12 2018, 3:27 PM
matmarex removed a project: OOUI.
matmarex added subscribers: • Petar.petkovic, KartikMistry.
gerritbot added a comment.Apr 12 2018, 3:50 PM

Change 425714 merged by jenkins-bot:
[mediawiki/core@master] Remove checkIcon from TitleOptionWidget

https://gerrit.wikimedia.org/r/425714

Jdforrester-WMF added a comment.Apr 12 2018, 4:53 PM

@Volker_E, given you said "I've got a feeling that the checkIcons should be opt in by default", should we move that to a different OOUI -specific task now that @matmarex has untagged this one?

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 12 2018, 5:00 PM
matmarex added a comment.Apr 12 2018, 5:19 PM

They already are "opt-in". However, when MenuOptionWidget opts in (on Apex theme), there is no way to have its subclasses like TitleOptionWidget automatically opt out. I don't think there is anything to do in OOUI here.

They should have never been visible in WikimediaUI theme, but they appeared here because it just so happens that TitleOptionWidget has some CSS for its own icons which accidentally unhid them.

Jdforrester-WMF assigned this task to Esanders.Apr 12 2018, 5:50 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.
Jdforrester-WMF removed a project: Patch-For-Review.

Very well.

Ryasmeen added a project: Verified.Apr 12 2018, 10:00 PM
Jdforrester-WMF renamed this task from Giant checkmarks appearing in link inspector (OOUI regression) to [Regression pre-wmf.30] Giant checkmarks appearing in link inspector.Apr 12 2018, 11:17 PM
• Deskana closed this task as Resolved.Apr 16 2018, 2:05 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 16 2018, 2:05 PM
Liuxinyu970226 unsubscribed.Apr 20 2018, 1:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL