Page MenuHomePhabricator

[Regression pre-wmf.30] Giant checkmarks appearing in link inspector
Closed, ResolvedPublic

Description

Event Timeline

Esanders triaged this task as Unbreak Now! priority.Apr 11 2018, 3:31 PM

Change 425714 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Remove checkIcon from TitleOptionWidget

https://gerrit.wikimedia.org/r/425714

Change 425714 merged by jenkins-bot:
[mediawiki/core@master] Remove checkIcon from TitleOptionWidget

https://gerrit.wikimedia.org/r/425714

@Volker_E, given you said "I've got a feeling that the checkIcons should be opt in by default", should we move that to a different OOUI -specific task now that @matmarex has untagged this one?

They already are "opt-in". However, when MenuOptionWidget opts in (on Apex theme), there is no way to have its subclasses like TitleOptionWidget automatically opt out. I don't think there is anything to do in OOUI here.

They should have never been visible in WikimediaUI theme, but they appeared here because it just so happens that TitleOptionWidget has some CSS for its own icons which accidentally unhid them.

Jdforrester-WMF renamed this task from Giant checkmarks appearing in link inspector (OOUI regression) to [Regression pre-wmf.30] Giant checkmarks appearing in link inspector.Apr 12 2018, 11:17 PM