Maniphest T192545

Error loading table with broken wikitext syntax
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This was observed while "Mam talent!" article is loaded in CX2 to be translated from English to Spanish (can be other language as well). Page seems to load correctly, but while article is being loaded into CX2, following Javascript error is thrown:

Uncaught TypeError: Cannot read property 'getOwner' of null
    at ve.ce.MWTableNode.js?7d2d0:129
    at Array.map (<anonymous>)
    at VeCeMWTableNode.ve.ce.MWTableNode.getTablesorterHeaderCells (ve.ce.MWTableNode.js?7d2d0:128)
    at VeCeMWTableNode.ve.ce.MWTableNode.updateSortableHeaders (ve.ce.MWTableNode.js?7d2d0:93)
    at later (core.js:237)

cx2-mam-talent-en-to-es-js-error.png (143×698 px, 19 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Sortable table header: Account for null entries in table matrix	mediawiki/extensions/VisualEditor	master	+2 -2

Customize query in gerrit

Event Timeline

• Petar.petkovic created this task.Apr 19 2018, 12:20 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 19 2018, 12:20 PM

The root cause is broken table syntax (defining the row twice). Ideally VE should be able to handle that.

Esanders renamed this task from ve.ce.MWTableNode#getTablesorterHeaderCells throws Javascript error to Error loading table with broken wikitext syntax.Apr 19 2018, 1:05 PM

Minimal test case:

{| class="wikitable sortable"
!Foo
|-
|-
|Bar
|-
|}

Change 427656 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Sortable table header: Account for null entries in table matrix

https://gerrit.wikimedia.org/r/427656

gerritbot added a project: Patch-For-Review.Apr 19 2018, 1:28 PM

Change 427656 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Sortable table header: Account for null entries in table matrix

https://gerrit.wikimedia.org/r/427656

Jdforrester-WMF assigned this task to Esanders.Apr 19 2018, 4:12 PM

Jdforrester-WMF edited projects, added VisualEditor (Current work); removed Patch-For-Review, VisualEditor.

Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 19 2018, 5:00 PM

• Deskana closed this task as Resolved.Apr 20 2018, 9:48 AM

• Deskana set the point value for this task to 1.

Ryasmeen added a project: Verified.May 3 2018, 9:25 PM

	F17126507: cx2-mam-talent-en-to-es-js-error.png
	Apr 19 2018, 12:20 PM

Error loading table with broken wikitext syntaxClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

Error loading table with broken wikitext syntax
Closed, ResolvedPublic1 Estimated Story Points
Actions