Maniphest T195513

Load map file in non-strict mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pnorman
	May 24 2018, 5:52 PM

Description

We shouldn't be loading the map file in strict mode, because this causes errors with fonts. The cause is the same as https://github.com/gravitystorm/openstreetmap-carto/issues/3086 and the fix is https://github.com/gravitystorm/openstreetmap-carto/pull/3089

We should be calling [Map.fromString](http://mapnik.org/documentation/node-mapnik/3.6/#Map.fromString) somewhere from within the bowels of our code, and need to pass strict : false as part of the options.

Searching through node_modules, this is called by one of mapnik-pool, tilelive-vector, or tilelive-bridge

Details

	Subject	Repo	Branch	Lines +/-
	Don't load maps in strict mode in tilelive-vector	mediawiki/services/kartotherian	mapnik-3.1	+6 -0

Customize query in gerrit

Related Objects

Mentioned In: rMSKA4f256e492a43: Don't load maps in strict mode in tilelive-vector
T213077: Migrate Kartotherian to node-mapnik >v4.2.1 to support libmapnik >3.1.x
T200594: Add client identifier to requests sent from Kartotherian to WDQS
T195635: Trim brighmed font list to match Debian jessie
Mentioned Here: T200594: Add client identifier to requests sent from Kartotherian to WDQS

Event Timeline

Pnorman created this task.May 24 2018, 5:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2018, 5:53 PM

I'm going to trim down the brighmed font list to match what we have. We should still be in non-strict mode, but this is a quicker way to get to working.

Pnorman mentioned this in T195635: Trim brighmed font list to match Debian jessie.May 25 2018, 10:30 PM

Strict mode is on by default in tilelive-vector as of 0.4.0. Rather than being configurable as a query parameter, it's intended to be toggled module-wide as a mutable export: https://github.com/mapbox/tilelive-vector/blob/1e6a7487b5f4938d7e307b70f1b8d1935aefda0a/index.js#L30

To force it via [tilelive-modules](https://github.com/mojodna/tilelive-modules):

diff --git i/loader.js w/loader.js
index 2920730..013bb1f 100644
--- i/loader.js
+++ w/loader.js
@@ -19,6 +19,9 @@ module.exports = function(tilelive, options) {
     }
 
     try {
+      if (name === "tilelive-vector") {
+        mod.strict = false;
+      }
       if (typeof(mod.registerProtocols) === "function") {
         mod.registerProtocols(tilelive);
       } else {

• Mholloway subscribed.Jun 1 2018, 11:17 AM

JTannerWMF removed a project: Collaboration-Team-Triage (Collab-Team-This-Quarter).Jun 13 2018, 2:38 PM

• Vvjjkkii renamed this task from Load map file in non-strict mode to eccaaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from eccaaaaaaa to Load map file in non-strict mode.Jul 2 2018, 3:50 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Pnorman triaged this task as Medium priority.Jul 3 2018, 4:14 PM

• Mholloway moved this task from Backlog to To-do on the Maps-Sprint board.Jul 3 2018, 4:56 PM

• Mholloway added a project: Maps (Kartotherian).Jul 24 2018, 9:37 PM

LGoto added a project: Product-Infrastructure-Team-Backlog-Deprecated.Jul 25 2018, 3:45 PM

• Jhernandez moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.Aug 1 2018, 3:36 PM

• Mholloway claimed this task.Sep 24 2018, 6:54 AM

https://github.com/kartotherian/tilelive-vector/pull/3

• Mholloway moved this task from To-do to Needs review on the Maps-Sprint board.Sep 24 2018, 8:13 AM

• Mholloway edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.Sep 24 2018, 8:16 AM

• Mholloway moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

MSantos removed a project: Maps-Sprint.Sep 25 2018, 7:25 PM

• Mholloway moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 27 2018, 5:19 AM

I suppose I should keep this open until we can deploy to prod.

• Mholloway moved this task from To Deploy to Blocked on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 27 2018, 7:36 AM

Mentioned in SAL (#wikimedia-releng) [2018-09-27T07:38:16Z] <mdholloway> deployment-maps04 updated tilerator and kartotherian node modules (T195513, T200594)