Page MenuHomePhabricator

Graphoid service git master is in a broken, untestable state
Open, LowPublic

Description

For some reason, probably due to some recent graphoid activity, it is now in a broken state in git. Try running npm run docker-test. I'm not sure why jenkins didn't catch that before.

Event Timeline

Yurik created this task.May 30 2018, 7:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2018, 7:09 PM
mobrovac lowered the priority of this task from High to Low.May 31 2018, 11:47 AM

Vega now depends on packages which depend on Node 8, so we had to add npm-shrinkwrap.json in order to be able to build and deploy it.

Yurik added a comment.May 31 2018, 3:17 PM

@mobrovac how is npm shrinkwrap related to this issue? Graphoid depends on two very old versions of Vega - 1.5 and 2.0. I think they should be published independently as npm modules (i'll work on that). The error message shown by jenkins is about the server.js missing shutdown - which is clearly not part of Vega code at all. Please double check.

hashar removed a subscriber: hashar.Jun 4 2018, 8:25 AM

Any chance of this making any progress? It would be a major loss if the 'Graph' maps got left out of the internationalized names.

Vvjjkkii renamed this task from Graphoid service git master is in a broken, untestable state to uybaaaaaaa.Jul 1 2018, 1:07 AM
Vvjjkkii raised the priority of this task from Low to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
mobrovac renamed this task from uybaaaaaaa to Graphoid service git master is in a broken, untestable state.Jul 1 2018, 11:07 AM
mobrovac lowered the priority of this task from High to Low.
mobrovac updated the task description. (Show Details)