Page MenuHomePhabricator
Create Task
Maniphest T196835

Add a link to the Code of Conduct to the footer of Gerrit
Closed, ResolvedPublic
Actions

Description

Like Phabricator, there should be a footer link to the CoC in Gerrit: https://www.mediawiki.org/wiki/Special:MyLanguage/Code_of_Conduct

Details

SubjectRepoBranchLines +/-
Gerrit: Add CoC and privacy policy to footeroperations/puppetproduction+36 -0
Revert "Gerrit: Add missing resource /var/lib/gerrit2/review_site"operations/puppetproduction+1 -9
Gerrit: Add CoC and Privacy Policy to old UIoperations/puppetproduction+10 -0
Gerrit: Add footer link for CoC and Privacy Policyoperations/puppetproduction+27 -0
Replace "wikimedia-polygerrit-style" plugin with gerrit-themeoperations/puppetproduction+18 -0
Link to gerrit-theme.html in scap repooperations/puppetproduction+6 -0
Add gerrit-theme.html and also add footer linksoperations/software/gerritdeploy/wmf/stable-2.15+45 -0
Customize query in gerrit

Related Objects

Event Timeline

greg created this task.Jun 10 2018, 7:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2018, 7:05 AM
greg moved this task from Bugs & stuff to WMF customizations on the Gerrit board.Jun 10 2018, 7:05 AM
greg added a subscriber: Paladox.

@Paladox can you help outline what's needed here?

Legoktm updated the task description. (Show Details)Jun 10 2018, 7:12 AM
MarcoAurelio awarded a token.Jun 10 2018, 11:17 AM
MarcoAurelio subscribed.
Paladox added a comment.Jun 10 2018, 11:28 AM

Yep I can, just need to find the config that does the footer.

gerritbot subscribed.Jun 10 2018, 2:06 PM

Change 439483 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Gerrit: Add CoC and privacy policy to footer

https://gerrit.wikimedia.org/r/439483

gerritbot added a project: Patch-For-Review.Jun 10 2018, 2:06 PM
Paladox added a comment.Jun 10 2018, 2:08 PM

^^ that does it for gwtui only for now, need to figure out how to do it for PolyGerrit.

Paladox added a comment.Jun 10 2018, 2:21 PM

This is what it looks like in gwtui:

Screen Shot 2018-06-10 at 15.20.44.png (1×2 px, 300 KB)

Legoktm subscribed.Jun 10 2018, 5:04 PM

Is it not possible to have it in the same "Powered by Gerrit..." line?

Paladox added a comment.Jun 10 2018, 5:06 PM

apparently upstream hacked there deployed prod version (i coulden't find a hook to hook into).

I am guessing they possibly used js or modified there version.

the same applys to polymer.

gerritbot added a comment.Jun 10 2018, 7:59 PM

Change 439503 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/software/gerrit@deploy/wmf/stable-2.15] Rename wikimedia-polygerrit-style.html to gerrit-theme.html and also add footer links

https://gerrit.wikimedia.org/r/439503

gerritbot added a comment.Jun 10 2018, 8:00 PM

Change 439504 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Rename wikimedia-polygerrit-style.html to gerrit-theme.html

https://gerrit.wikimedia.org/r/439504

Paladox added a comment.Jun 10 2018, 8:04 PM

this is what the polygerrit change looks like

Screen Shot 2018-06-10 at 21.04.13.png (1×2 px, 283 KB)

Paladox added a comment.Jun 10 2018, 8:33 PM

@Legoktm actually i can do what i did for polygerrit using javascript!

greg added a comment.Jun 10 2018, 8:44 PM
In T196835#4270594, @Paladox wrote:

@Legoktm actually i can do what i did for polygerrit using javascript!

inb4: "if i don't have JS enabled am I bound by the CoC?" :P

Paladox added a comment.Jun 10 2018, 8:46 PM

hmm, gerrit should not even load if you have javascript disabled :).

Expecially for polygerrit which is built manly around javascript and html.

Paladox added a comment.Jun 10 2018, 8:51 PM

@greg just tested and gerrit gwtui throws

"Gerrit requires a JavaScript enabled browser.".

and polygerrit has a whitescreen.

Paladox added a comment.Jun 11 2018, 9:20 PM

Apparently in gwtui it loads the js file to early to be able to find the dom like polygerrit, anyways we are switching polygerrit to be the default ui for new users (and existing users that have not switched to the new ui and back to the old one thus having a ui cookie) see T196812 (next monday).

Paladox mentioned this in rGERRITDEPLOY508fe51d2461: Add gerrit-theme.html and also add footer links.Jun 11 2018, 10:59 PM
Paladox mentioned this in rGERRITDEPLOY94e8165abf79: Add gerrit-theme.html and also add footer links.
Paladox mentioned this in rGERRITDEPLOY2094225a09cb: Add gerrit-theme.html and also add footer links.Jun 11 2018, 11:49 PM
• Vvjjkkii renamed this task from Add a link to the Code of Conduct to the footer of Gerrit to obbaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, MarcoAurelio, Aklapper.
CommunityTechBot renamed this task from obbaaaaaaa to Add a link to the Code of Conduct to the footer of Gerrit.Jul 2 2018, 2:58 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, MarcoAurelio, Aklapper.
Paladox mentioned this in rGERRITDEPLOY82ae006c2540: Add gerrit-theme.html and also add footer links.Jul 26 2018, 7:36 PM
greg triaged this task as Medium priority.Aug 8 2018, 5:46 PM

Let's get these patches merged. Even with the double footer bars I think they are just fine. Thanks for your work here @Paladox

Paladox mentioned this in rGERRITDEPLOY8de4ff40960c: Add gerrit-theme.html and also add footer links.Aug 15 2018, 2:04 PM
greg raised the priority of this task from Medium to High.Sep 4 2018, 9:35 PM
greg merged a task: T203512: Where did the Privacy Policy/Code of Conduct go on gerrit?.

We need this out sooner than later.

thcipriani subscribed.Sep 6 2018, 3:21 PM
gerritbot added a comment.Sep 6 2018, 3:44 PM

Change 458523 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Replace "wikimedia-polygerrit-style" plugin with gerrit-theme

https://gerrit.wikimedia.org/r/458523

gerritbot added a comment.Sep 6 2018, 3:49 PM

Change 439503 abandoned by Paladox:
Add gerrit-theme.html and also add footer links

Reason:
per ^^

https://gerrit.wikimedia.org/r/439503

gerritbot added a comment.Sep 6 2018, 3:49 PM

Change 439504 abandoned by Paladox:
Link to gerrit-theme.html in scap repo

https://gerrit.wikimedia.org/r/439504

gerritbot added a comment.Sep 7 2018, 3:39 PM

Change 458833 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Gerrit: Add footer link for CoC and Privacy Policy

https://gerrit.wikimedia.org/r/458833

gerritbot added a comment.Sep 17 2018, 2:42 PM

Change 460914 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/puppet@production] Gerrit: Add CoC and Privacy Policy to old UI

https://gerrit.wikimedia.org/r/460914

gerritbot added a comment.Sep 25 2018, 4:08 PM

Change 458523 merged by Giuseppe Lavagetto:
[operations/puppet@production] Replace "wikimedia-polygerrit-style" plugin with gerrit-theme

https://gerrit.wikimedia.org/r/458523

gerritbot added a comment.Sep 25 2018, 4:18 PM

Change 458833 merged by Giuseppe Lavagetto:
[operations/puppet@production] Gerrit: Add footer link for CoC and Privacy Policy

https://gerrit.wikimedia.org/r/458833

gerritbot added a comment.Sep 25 2018, 4:27 PM

Change 460914 merged by Giuseppe Lavagetto:
[operations/puppet@production] Gerrit: Add CoC and Privacy Policy to old UI

https://gerrit.wikimedia.org/r/460914

gerritbot added a comment.Sep 25 2018, 5:01 PM

Change 462770 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/puppet@production] Revert "Gerrit: Add missing resource /var/lib/gerrit2/review_site"

https://gerrit.wikimedia.org/r/462770

gerritbot added a comment.Oct 3 2018, 7:02 PM

Change 462770 merged by Dzahn:
[operations/puppet@production] Revert "Gerrit: Add missing resource /var/lib/gerrit2/review_site"

https://gerrit.wikimedia.org/r/462770

Paladox closed this task as Resolved.Oct 3 2018, 7:07 PM

The footer works both in GWTUI and polygerrit now! (showing the privacy notice and CoC)

gerritbot added a comment.Oct 4 2018, 6:28 PM

Change 439483 abandoned by Paladox:
Gerrit: Add CoC and privacy policy to footer

https://gerrit.wikimedia.org/r/439483

hashar mentioned this in T319378: Move Gerrit Javascript plugins from gerrit-theme.js to standalone files in the deploy repository.Oct 5 2022, 8:27 AM
Aklapper mentioned this in T340372: Custom Gerrit footer not displayed.Jun 24 2023, 10:28 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 24 2023, 10:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL