Live @ https://github.com/wikimedia/resource-modules
Do we want Gerrit repos and standard NPM CI jobs or stick with GitHub?
I'd suggest we use Github for the time being. Given its tooling, there's little benefit for MediaWiki CI and we can use Travis as and when necessary.
I've invited https://www.npmjs.com/~joakin as a member of the Wikimedia org on npmjs.com. Once accepted, it should be possible to add the packages at https://www.npmjs.com/settings/wikimedia/teams/team/developers/access
I can't transfer the repos to the wikimedia organization on github since I can't create repositories there (insufficient permissions). Who do I ask about this?
Re: npm, I am on the wikimedia team but I'm not sure how I add the project to the team or the team to the project. In the project admin section I can add collaborators manually. Any ideas?
I can't transfer the repos to the wikimedia organization on github since I can't create repositories there (insufficient permissions). Who do I ask about this?
I've created a new repo, mw-node-qunit, under my account, niedzielski, and did the following:
git clone https://github.com/joakin/mw-node-qunit.git cd mw-node-qunit/ git remote add niedzielski https://github.com/niedzielski/mw-node-qunit.git git push niedzielski master
This appears to create a complete copy of the repo that is not marked as a fork. Does anyone have any objections if I just do this under wikimedia/ since I have permissions to create repos there?
NPM
I am guessing I can just publish an @wikimedia/mw-node-qunit package like any other NPM package once we get the repo sorted.
Change 442992 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: upgrade resource-modules linter
Change 442994 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/Popups@master] Hygiene: update mw-node-qunit dependency package
We had to work on it in a hurry because of a critical bug in a resource-modules dependency. Here's what I did:
@Jhernandez, please update the readmes in these repos to point to their new home!
Sure. I wanted to properly transfer repos and ownership of the existing packages but whatever. Transfer done then :)
Change 442994 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Hygiene: update mw-node-qunit dependency package
Change 442992 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: upgrade resource-modules linter
https://www.npmjs.com/package/resource-modules is still linking to Joaquin's github. Can we fix that?
@Jdlrobson, @Jhernandez updated the readmes for the repos so anyone who follows the source ink will see their new homes.
Sure but let's update the repo url in https://github.com/wikimedia/resource-modules/blob/master/package.json
@Jhernandez, would you mind updating the package.json file in each repo and cutting a new version? The repos are archived so I can't submit a PR and I don't have publish rights to your npmjs.com packages.
@Niedzielski I think @Jdlrobson means that the repository key on the @wikimedia package.json should point to the wikimedia github:
https://github.com/wikimedia/resource-modules/blob/master/package.json#L34-L37
That way https://www.npmjs.com/package/@wikimedia/resource-modules when clicking on Github it will link to the wikimedia repo and not the other one.
Change 445610 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/Popups@master] Fix: mw-node-qunit package reference
Change 445610 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix: mw-node-qunit package reference