| RHo | |
| Jun 20 2018, 4:14 PM |
| F25242799: image.png | |
| Aug 22 2018, 8:57 PM |
| F25242698: image.png | |
| Aug 22 2018, 8:57 PM |
| F24768638: ER 07 - exploded view 2 tabs open.png | |
| Aug 10 2018, 2:19 PM |
| F24643072: image.png | |
| Aug 7 2018, 5:41 PM |
| F18744735: image.png | |
| Jul 17 2018, 12:20 AM |
Splitting up the article view as a subtask to do the following:
See mocks at details in context on the main ticket.
Article overflow
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T195264 [EPIC] Improve app and article navigation | |||
| Resolved | Dbrant | T196372 Create a prototype to test an "Explicit reading mode" app and article navigation concept | |||
| Resolved | cooltey | T197808 Update the article view in the Explicit reading mode" prototype | |||
| Invalid | Dbrant | T199722 Animations for nav bars |
As I mentioned in T197814#4421265, how should this UI handle the Content issues and Similar pages options that were in the overflow menu?
Change 446209 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@unified_activity] [WIP] Update the article view in the Explicit reading mode" prototype
Change 446895 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@unified_activity] Update the article view in the Explicit reading mode" prototype
Change 446209 abandoned by Sharvaniharan:
Update the article view in the Explicit reading mode" prototype
Reason:
New patch in place
hi @cooltey - reposting visual bug on the exploded tabs in Article view in the Explicit reading prototype below:
Actual tabs view from Prototype 2:
- Fake shadow exposed in the tab stack – seen in the top left and right corners of tab stack, and the fact that there is no shadow cast on the left and right of the tabs
- cut-off app bar shown in the top most tab (Empire State Building article)
Change 451088 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@unified_activity] [WIP] Minor UI fixes : Tab list
@RHo I have fixed them here : https://gerrit.wikimedia.org/r/#/c/apps/android/wikipedia/+/451088/ Please let me know if it looks ok.
hi @Sharvaniharan - thanks for removing the dark corners on the top left and right and fixing the cut-app app bar being shown. Actual looks like this:
However, can we get the shadow around the tab stack as per expected?
hi @Sharvaniharan - just running through the script and realized that the article top toolbar is actually incomplete:
Expected  | Actual:  |
Also also @Sharvaniharan - can the prototype be updated here please: https://releases.wikimedia.org/mobile/android/wikipedia/scratch/app-alpha-prototype_2.apk ? The current linked app does not have your recent fixed to the tab bar implemented.
Change 454707 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@unified_activity] [WIP] : UI Tweaks
@RHo The shadow around the tab list is a bit hard to do with the current set-up we have, so we have decided to wait until we re-architect the tabslist. Other changes are done
