Page MenuHomePhabricator

Transcluded section edit links are broken in Minerva
Open, LowPublic5 Story Points

Description

Background

I don't know whether this is new.
In desktop you can click edit at a section transcluded from another page. You will then edit the right section on the other page. This doesn't happen in mobile. It was reported at https://en.wikipedia.org/wiki/Talk:Main_Page#Cannot_edit_ITN_from_mobile?

Example:
https://en.wikipedia.org/wiki/Talk:Main_Page#Main_Page_error_reports transcludes https://en.wikipedia.org/wiki/Wikipedia:Main_Page/Errors which has the section "Errors in In the news". In desktop the section edit link at https://en.wikipedia.org/wiki/Talk:Main_Page#Errors_in_In_the_news correctly goes to https://en.wikipedia.org/w/index.php?title=Wikipedia:Main_Page/Errors&action=edit&section=T-4 which edits the section.

But in mobile at https://en.m.wikipedia.org/wiki/Talk:Main_Page the link goes to https://en.m.wikipedia.org/w/index.php?title=Talk:Main_Page&action=edit&section=T-4 or https://en.m.wikipedia.org/wiki/Talk:Main_Page#/editor/T-4 and does nothing.
On the transcluded page https://en.m.wikipedia.org/wiki/Wikipedia:Main_Page/Errors the link correctly goes to https://en.m.wikipedia.org/w/index.php?title=Wikipedia:Main_Page/Errors&action=edit&section=4 or https://en.m.wikipedia.org/wiki/Wikipedia:Main_Page/Errors#/editor/4 and works.

Tested in Firefox on a Windows computer and on an iPad with iOS.

acceptance criteria

  • When visitinghttps://en.m.wikipedia.beta.wmflabs.org/wiki/Transcluded_page clicking "Yo from Transcluded page" edit icon takes the user is able to edit section 1 of "Wikipedia:Transcluded_page"
  • When visiting https://en.m.wikipedia.beta.wmflabs.org/wiki/Transcluded_page clicking edit icon in page actions opens #/editor/0 (or #/editor/1 equivalent)

Developer notes

I learned something new today.

{{Wikipedia:Transcluded_page}}

We'll need to update Skin::doEditSectionLink to use the $title passed as a parameter to the method rather than using "$this->getTitle()"
The JavaScript will also need to deal with this case. To keep things simple, we could not load the JavaScript editor and instead redirect to the page, however it would be useful to allow editing of that page with out leaving! We should discuss the trade offs in an estimation.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2018, 2:24 PM
DePiep added a subscriber: DePiep.Jun 23 2018, 8:36 PM

I am the editor who posted the original report (first link in Description).
I note that since the *edit*-link does not react, one could consider & test whether just opening the page (i.e., read instead of edit opening) would be acceptable, skipping the bug.

Jdlrobson renamed this task from Transcluded section edit links are broken in mobile to Transcluded section edit links are broken in Minerva.Jun 27 2018, 8:55 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson edited projects, added MinervaNeue; removed MobileFrontend.
ovasileva triaged this task as Normal priority.Jun 29 2018, 11:42 AM
Vvjjkkii renamed this task from Transcluded section edit links are broken in Minerva to 0eaaaaaaaa.Jul 1 2018, 1:02 AM
Vvjjkkii raised the priority of this task from Normal to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
JJMC89 renamed this task from 0eaaaaaaaa to Transcluded section edit links are broken in Minerva.Jul 1 2018, 3:58 AM
JJMC89 lowered the priority of this task from High to Normal.
JJMC89 updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Jul 3 2018, 11:11 PM
ovasileva updated the task description. (Show Details)Jul 4 2018, 4:31 PM

We pointed this at a 5 but we're not quite sure what the client-side JavaScript changes will be needed.

Niedzielski set the point value for this task to 5.Jul 4 2018, 4:37 PM
Jdlrobson lowered the priority of this task from Normal to Low.Apr 9 2019, 4:32 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptApr 9 2019, 4:32 PM