In Special:NewPagesFeed, creations by autopatrolled users are not marked as autopatrolled. For example, the article Casper Motor Company-Natrona Motor Company on Wikipedia says that it is unreviewed despite being created by an autopatrolled user. The creations still appear without an exclamation point in recent changes, and without yellow highlighting in Special:NewPages.
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
This might have a similar cause to T198449: Rollback from autopatrolled user was marked as not patrolled.
Comment Actions
This might be us: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/436472/25/includes/Hooks.php#257 (deployed with wmf.10)
Comment Actions
Change 443127 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/extensions/PageTriage@master] Fix setting of reviewed state based on autopatrol permission
Comment Actions
We realized that this problem was accidentally caused by Community Tech's work on this project to expand and improve the New Pages Feed. I'm sorry about this -- it's definitely frustrating that extra work is being caused for New Page Reviewers.
The team is working on the fix now, tests to go along with the fix, and doing code review. Because of the time it will take to do this right, we'll likely deploy a fix on Monday morning.
I'll give another update in a few hours.
Comment Actions
Change 443127 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Fix setting of reviewed state based on autopatrol permission
Comment Actions
The fix has been written, as well as additional tests. It has been code reviewed, and now needs to be tested in a testing wiki. We expect to deploy on Monday morning.
Comment Actions
The reviewing community brought up the question of whether the fix will mark the pages that should have been autopatrolled as such, and remove them from the feed. @MusikAnimal wrote that he's thinking about a script to do this.
Comment Actions
Change 443446 had a related patch set uploaded (by Niharika29; owner: MusikAnimal):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.10] Fix setting of reviewed state based on autopatrol permission
Comment Actions
Change 443446 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.10] Fix setting of reviewed state based on autopatrol permission
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-07-02T18:16:04Z] <niharika29@deploy1001> Synchronized php-1.32.0-wmf.10/extensions/PageTriage/: Fix setting of reviewed state based on autopatrol permission T198497 (duration: 00m 52s)
Comment Actions
Deployed! Existing pages created by autopatrolled users are also now all marked as reviewed https://en.wikipedia.org/w/index.php?title=Special%3ALog&type=pagetriage-curation&user=MusikAnimal&offset=20180702184000
Comment Actions
Thanks @MusikAnimal. For anyone following along, we now consider this bug fixed and all pages to have the correct review status. Please let us know if you see any problems.