Maniphest T198449

Rollback from autopatrolled user was marked as not patrolled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Urbanecm
	Jun 29 2018, 6:48 AM

Description

Hello,

I have rollbacked an edit that was made by anonymous contributor on cs.wikipedia (I have autopatrol rights there, in fact I have sysop bit there) and the rollbacking edit was marked as non-patrolled and had to be patrolled manually.

The rollbacking edit: https://cs.wikipedia.org/w/index.php?title=Borsk%C3%BD_Mikul%C3%A1%C5%A1&diff=16205272&oldid=16205271
Edit that was rollbacked: https://cs.wikipedia.org/w/index.php?title=Borsk%C3%BD_Mikul%C3%A1%C5%A1&diff=16205271&oldid=16202566

Patrolling protocol: https://cs.wikipedia.org/w/index.php?title=Speci%C3%A1ln%C3%AD:Protokolovac%C3%AD_z%C3%A1znamy&page=Borsk%C3%BD+Mikul%C3%A1%C5%A1&hide_patrol_log=0

There seems to be a regression bug in the patrolling system.

Best,

Martin Urbanec

Details

Subject	Repo	Branch	Lines +/-
Mark rollbacking revision as patrolled	mediawiki/core	wmf/1.32.0-wmf.10	+7 -0
Mark rollbacking revision as patrolled	mediawiki/core	wmf/1.32.0-wmf.10	+7 -0
Mark rollbacking revision as patrolled	mediawiki/core	master	+7 -0
Regression test for autopatrolling rollbacks	mediawiki/core	master	+15 -51

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dduvall	T191056 1.32.0-wmf.10 deployment blockers
		Resolved		matej_suchanek	T198449 Rollback from autopatrolled user was marked as not patrolled

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

• Urbanecm merged a task: T198450: The rollback is not marked as a patrolled edit, and undo and rollback tags are added.Jun 29 2018, 7:07 AM

matej_suchanek added a subscriber: daniel.Jun 29 2018, 7:11 AM

Change 443031 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/core@master] Mark rollbacking revision as patrolled

https://gerrit.wikimedia.org/r/443031

gerritbot added a project: Patch-For-Review.Jun 29 2018, 7:21 AM

IKhitron subscribed.Jun 29 2018, 8:30 AM

Change 443063 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Regression test for autopatrolling rollbacks

https://gerrit.wikimedia.org/r/443063

• Urbanecm merged a task: T198463: Patrolled edits bug: some revocations by trusted users are not marked as patrolled anymore since yesterday.Jun 29 2018, 10:03 AM

• Urbanecm added a subscriber: JackPotte.

Assigning to Matěj as he has created the fixing patch. Thank you Matěj!

• Urbanecm moved this task from Backlog to Watching on the User-Urbanecm board.Jun 29 2018, 10:21 AM

Change 443031 merged by jenkins-bot:
[mediawiki/core@master] Mark rollbacking revision as patrolled

https://gerrit.wikimedia.org/r/443031

Change 443063 merged by jenkins-bot:
[mediawiki/core@master] Regression test for autopatrolling rollbacks

https://gerrit.wikimedia.org/r/443063

Stryn merged a task: T198476: Some edits are not automatically marked as patrolled.Jun 29 2018, 1:35 PM

Stryn added subscribers: Yann, PlyrStar93, Stryn.

Stryn merged a task: T198478: Reverted changes appear in recentchanges like the ones to be verified.Jun 29 2018, 1:37 PM

Stryn added a subscriber: Andyrom75.

Ymblanter subscribed.Jun 29 2018, 2:26 PM

Mea culpa.

Yes, needed to be fixed. Please, look at my recent changes patrol in Meta (https://meta.wikimedia.org/w/index.php?title=Special:Log/Marshmallych&hide_patrol_log=0). Some of patrolled by me changes are made by sysops.

And the tagging with 'Undo' and 'Rollback' (https://meta.wikimedia.org/w/index.php?title=User_talk:WhitePhosphorus&oldid=18164336&diff=prev) was too in March (https://meta.wikimedia.org/w/index.php?title=User_talk:Krassotkin&diff=prev&oldid=17870980).

JJMC89 mentioned this in T198497: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed.Jun 29 2018, 4:33 PM

daniel added a project: Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1).Jun 29 2018, 5:50 PM

matmarex merged a task: T198512: Problem with automatic auto patrol.Jun 29 2018, 8:00 PM

matmarex added a subscriber: EditorD.S.

matmarex added a parent task: T191056: 1.32.0-wmf.10 deployment blockers.Jun 29 2018, 8:10 PM

matmarex subscribed.

The bug has been fixed, but the fix still needs to be deployed to Wikimedia wikis. Usually deployments are not done on Fridays (so that we will not have to call up people on the weekend if anything new breaks). Judging by the number of reports, it definitely seems like a noticeable problem, is this causing major issues for users/administrators, or could you folks live with it until Monday? @greg It might be worth making an exception.

In T198449#4326334, @matmarex wrote:

The bug has been fixed, but the fix still needs to be deployed to Wikimedia wikis. Usually deployments are not done on Fridays (so that we will not have to call up people on the weekend if anything new breaks). Judging by the number of reports, it definitely seems like a noticeable problem, is this causing major issues for users/administrators, or could you folks live with it until Monday? @greg It might be worth making an exception.

I'm totally fine waiting for the deployment. Just curious if the double tag (both the Rollback + Undo tags applied to a rollback) issue is also fixed with this one.

In T198449#4326346, @PlyrStar93 wrote:

In T198449#4326334, @matmarex wrote:

Just curious if the double tag (both the Rollback + Undo tags applied to a rollback) issue is also fixed with this one.

That is a separate issue, see T190374: Rollback gets both "mw-rollback" and "mw-undo" tags. It seems there isn't a fix for it yet, but folks figured out the cause, so the fix should be easy to do.

Change 443195 had a related patch set uploaded (by Thcipriani; owner: Matěj Suchánek):
[mediawiki/core@wmf/1.32.0-wmf.10] Mark rollbacking revision as patrolled

https://gerrit.wikimedia.org/r/443195

In T198449#4326334, @matmarex wrote:

The bug has been fixed, but the fix still needs to be deployed to Wikimedia wikis. Usually deployments are not done on Fridays (so that we will not have to call up people on the weekend if anything new breaks). Judging by the number of reports, it definitely seems like a noticeable problem, is this causing major issues for users/administrators, or could you folks live with it until Monday? @greg It might be worth making an exception.

I have created a quick bot marking all rollbacks as patrolled, so they will disappear automatically after some time from recentchanges. But having this fixed today and before Monday will be VERY GOOD!

Change 443195 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.10] Mark rollbacking revision as patrolled

https://gerrit.wikimedia.org/r/443195

Epidosis subscribed.Jun 29 2018, 9:59 PM

Made an attempt to deploy the fix that was merged in master today; however, when testing the change on mwdebug1002, @matmarex hit an exception. I pasted the stacktrace for the exception into P7318.

Given that I didn't know how to proceed, I decided to revert for the time being. This exception is very possibly unrelated, but I didn't feel comfortable rolling forward with so few people around should this breakage be related to the patch.

(For reference, I was making this change when testing: https://test.wikipedia.org/w/index.php?title=T198449&diff=prev&oldid=357685. The rollback actually went through, and it was correctly autopatrolled, but I got an exception instead of a success page.)

Ltrlg subscribed.Jun 30 2018, 10:07 AM

Maybe this should be in the tech news.

Unassigning myself, I'm not sure what should be done next, looks like a deadlock to me.

He7d3r subscribed.Jun 30 2018, 5:02 PM

Framawiki subscribed.Jun 30 2018, 5:03 PM

Lydia_Pintscher subscribed.Jun 30 2018, 5:50 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 30 2018, 8:01 PM

daniel added a project: User-Daniel.Jun 30 2018, 8:36 PM

revi subscribed.Jul 1 2018, 3:11 PM

Reported at nowiki too, I'll post a note that the bug is tracked.

Nsaa subscribed.Jul 1 2018, 7:49 PM

Jeff_G mentioned this in T198581: Rollbacks by users with autopatrol right on Commons are not being autopatrolled.Jul 1 2018, 11:37 PM

This has been happening on Commons, too. This edit by Bsadowski 1, who has Local user-groups Image reviewers, File movers, Rollbackers and Autoconfirmed users and Global user-group Stewards, appears unpatrolled in my watchlist. As a member of Image reviewers, that user should inherit the Autopatrolled group rights. https://commons.wikimedia.org/wiki/Special:ListGroupRights confirms that five groups have the right "Have one's own edits automatically marked as patrolled (autopatrol)": Image reviewers, Autopatrollers; Bots; Patrollers; and Administrators. See also https://commons.wikimedia.org/wiki/COM:VP#Unpatrolled rollbacks.

Asav subscribed.Jul 2 2018, 12:58 AM

zhuyifei1999 merged a task: T198581: Rollbacks by users with autopatrol right on Commons are not being autopatrolled.Jul 2 2018, 5:57 AM

Fiox is mon master, will go out with the regular train deployment.

The exception that @thcipriani saw seems unrelated. At least I can't think of a way for @matej_suchanek to cause this issue.

Liuxinyu970226 awarded a token.Jul 2 2018, 12:20 PM

Liuxinyu970226 subscribed.

srwiki have this problem same

BethNaught subscribed.Jul 2 2018, 1:54 PM

Please avoid adding further "my wiki too!" comments. Thank you everybody!

Automatik subscribed.Jul 2 2018, 2:21 PM

Change 443471 had a related patch set uploaded (by Bartosz Dziewoński; owner: Matěj Suchánek):
[mediawiki/core@wmf/1.32.0-wmf.10] Mark rollbacking revision as patrolled

https://gerrit.wikimedia.org/r/443471

Change 443471 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.10] Mark rollbacking revision as patrolled

https://gerrit.wikimedia.org/r/443471

Mentioned in SAL (#wikimedia-operations) [2018-07-02T19:00:36Z] <niharika29@deploy1001> Synchronized php-1.32.0-wmf.10/includes/page/WikiPage.php: Mark rollbacking revision as patrolled T198449; WikiPage: Do not set undid revision ID for rollbacks T190374 (duration: 00m 50s)