Page MenuHomePhabricator
Create Task
Maniphest T199174

Special:BlockList gives faulty results after an admin changes another admin's block
Closed, ResolvedPublic
Actions

Description

See this thread at Village Pump (technical) where examples are given and the problem confirmed for other users.

If a second admin comes along and modifies an already existing block, Special:BlockList creates a false record with combined details from both admins' blocks. Looks to have become broken in 2014 after the software was updated.

Details

SubjectRepoBranchLines +/-
Update performer when block settings are changedmediawiki/coremaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Berean_Hunter created this task.Jul 10 2018, 1:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2018, 1:15 AM
SQL subscribed.Jul 10 2018, 1:48 AM
JJMC89 edited projects, added MediaWiki-User-management; removed MediaWiki-General.Jul 10 2018, 4:03 AM
JJMC89 subscribed.EditedJul 10 2018, 4:08 AM
• TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.Aug 17 2018, 6:45 PM
Umherirrender merged a task: T203274: Entries in Block list are not accurate.Aug 31 2018, 7:47 PM
Umherirrender added a subscriber: Automatik.
JJMC89 merged a task: T173636: Defect: Special:BlockList incorrectly reports blocking admin on autoblock where block was changed by another admin.Aug 31 2018, 7:49 PM
JJMC89 added a subscriber: Deskbanana.
Ammarpad merged a task: T223401: $1 on Blocked user interface messages show wrong when block is edited by another admin.May 15 2019, 8:17 PM
Ammarpad added subscribers: RhinosF1, Sario528.
JJMC89 merged a task: T228571: The blocking admin is not updated in BlockList for users whose block have been extended.Jul 20 2019, 5:40 PM
JJMC89 added a subscriber: Stryn.
Anomie merged a task: T234210: API should return the username of the reblocking admin.Sep 30 2019, 1:39 PM
Anomie mentioned this in T234210: API should return the username of the reblocking admin.
Anomie added a subscriber: Sakretsu.
Sakretsu added a comment.EditedOct 25 2019, 3:15 PM

Isn't just $currentBlock->setBlocker( $performer ); missing in SpecialBlock.php?

gerritbot added a comment.Oct 27 2019, 11:58 AM

Change 546360 had a related patch set uploaded (by Sakretsu; owner: Sakretsu):
[mediawiki/core@master] Update performer when block settings are changed

https://gerrit.wikimedia.org/r/546360

gerritbot added a project: Patch-For-Review.Oct 27 2019, 11:58 AM
dmaza added subscribers: Niharika, dmaza.Oct 28 2019, 1:42 PM
In T199174#5606683, @Sakretsu wrote:

Isn't just $currentBlock->setBlocker( $performer ); missing in SpecialBlock.php?

I believe so.

@Niharika can you confirm that it is Ok to override the original blocker?

Niharika added a comment.Oct 30 2019, 2:59 PM
In T199174#5611402, @dmaza wrote:
In T199174#5606683, @Sakretsu wrote:

Isn't just $currentBlock->setBlocker( $performer ); missing in SpecialBlock.php?

I believe so.

@Niharika can you confirm that it is Ok to override the original blocker?

Ideally this should go through a mini-consensus on the wiki(s) but given that this is a bug as of right now, let's roll with it. If there's pushback, we can rethink this.

gerritbot added a comment.Oct 30 2019, 3:15 PM

Change 546360 merged by jenkins-bot:
[mediawiki/core@master] Update performer when block settings are changed

https://gerrit.wikimedia.org/r/546360

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2019, 4:11 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Oct 30 2019, 5:00 PM
DannyS712 edited projects, added MediaWiki-Blocks; removed MediaWiki-User-management.Apr 25 2020, 12:10 AM
Restricted Application added a project: MediaWiki-User-management. · View Herald TranscriptApr 25 2020, 12:10 AM
Aklapper removed a project: MediaWiki-User-management.Apr 25 2020, 12:23 PM
TheresNoTime removed a subscriber: RhinosF1.Dec 15 2022, 11:36 PM
Umherirrender closed this task as Resolved.Jan 18 2023, 8:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits