Page MenuHomePhabricator

Checkboxes for local overrides added by GlobalPrefs extension are not indented as expected with OOUI
Closed, ResolvedPublic0.5 Estimated Story Points

Description

ExampleWithout OOUIWith OOUI
1
image.png (392ร—1 px, 127 KB)
image.png (448ร—908 px, 120 KB)
2
image.png (404ร—918 px, 78 KB)
image.png (476ร—956 px, 81 KB)

Problem: The checkboxes are no longer indented with OOUI as they are previously. This makes it confusing to see which option they relate to.
Expected behavior: Checkboxes are indented with OOUI, as they are without it.

Event Timeline

@Volker_E I don't see indents being used anywhere in the new UI. Is there a general aversion towards indents?

Mooeypoo set the point value for this task to 0.5.
Mooeypoo edited projects, added Community-Tech-Sprint; removed Community-Tech.

Change 446968 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/GlobalPreferences@master] GlobalPreferences OOUI: Indent local override checkbox

https://gerrit.wikimedia.org/r/446968

Change 446968 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] GlobalPreferences OOUI: Indent local override checkbox

https://gerrit.wikimedia.org/r/446968

Niharika moved this task from QA to Q1 2018-19 on the Community-Tech-Sprint board.