Page MenuHomePhabricator
Create Task
Maniphest T200251

CX2: Reduce duplicate code between trackers for issues and content modifications
Closed, ResolvedPublic
Actions

Description

Content Translation keeps track of information about the paragraphs of the translation. This includes the percentage of modified machine translation (T190279), and the issues (errors and warnings) that may be associate with a paragraph (T189488).

As these pieces were developed, several opportunities to reduce code duplication were identified. The current ticket is to perform the refactoring needed to reduce such duplication. This will facilitate the development of future tickets to support new kinds of issues.

As the refactoring is done, we may want to account for future functionality that may have an impact on how the code is organized such as:

Details

SubjectRepoBranchLines +/-
Refactor save tracker and merge with translation trackermediawiki/extensions/ContentTranslationmaster+275 -207
Show issue cards when they are relevantmediawiki/extensions/ContentTranslationmaster+861 -557
Customize query in gerrit

Related Objects

Event Timeline

Pginer-WMF created this task.Jul 24 2018, 8:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2018, 8:55 AM
Pginer-WMF triaged this task as High priority.Jul 24 2018, 8:55 AM
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-July-September board.
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF updated the task description. (Show Details)Jul 30 2018, 12:15 PM
• santhosh mentioned this in T200503: CX2: User modified content is saved as original machine translation.Jul 31 2018, 12:31 PM
gerritbot subscribed.Aug 1 2018, 11:17 AM

Change 449500 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Refactor save tracker and merge with translation tracker

https://gerrit.wikimedia.org/r/449500

gerritbot added a project: Patch-For-Review.Aug 1 2018, 11:17 AM
• santhosh moved this task from Priority backlog to In Progress on the Language-2018-July-September board.Aug 1 2018, 11:27 AM
• santhosh added subscribers: • Petar.petkovic, • santhosh.Aug 1 2018, 11:30 AM

https://gerrit.wikimedia.org/r/449500 does not address the whole ticket. It refactored the save tracker alone. Remaining opportunities to unify the trackers:

  1. The data we save in between MT changes, trackd in ve.init.CXTarget class(contentSourceCache)
  2. Issue tracker(WIP in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/445042 by @Petar.petkovic )
• Petar.petkovic moved this task from In Progress to In Review on the Language-2018-July-September board.Aug 1 2018, 11:31 AM
gerritbot added a comment.Aug 4 2018, 12:26 PM

Change 445042 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Show issue cards when they are relevant

https://gerrit.wikimedia.org/r/445042

gerritbot added a comment.Aug 7 2018, 7:18 AM

Change 445042 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Show issue cards when they are relevant

https://gerrit.wikimedia.org/r/445042

• santhosh claimed this task.Aug 7 2018, 7:23 AM
gerritbot added a comment.Aug 31 2018, 8:55 AM

Change 449500 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Refactor save tracker and merge with translation tracker

https://gerrit.wikimedia.org/r/449500

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 31 2018, 9:00 AM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-July-September board.Aug 31 2018, 9:15 AM
• Petar.petkovic removed a project: Patch-For-Review.
• Petar.petkovic removed a subscriber: gerritbot.
KartikMistry subscribed.Sep 7 2018, 6:05 AM

Nothing else to test. Code is also deployed in production.

KartikMistry moved this task from QA to Done on the Language-2018-July-September board.Sep 7 2018, 6:05 AM
• Petar.petkovic closed this task as Resolved.Sep 7 2018, 6:10 AM
In T200251#4565089, @KartikMistry wrote:

Nothing else to test. Code is also deployed in production.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL