Page MenuHomePhabricator
Create Task
Maniphest T200921

[betalabs] NPP - "Uncaught TypeError: Cannot read property 'stats' of undefined" and "Cannot read property 'pages' of undefined"
Closed, ResolvedPublic
Actions

Description

  1. In betalabs on Special:NewPagesFeed - mark all filters that you can select. Click on 'Set filters'.

The some results will be displayed.

  1. Un-check one of the filters and click 'Set filters' - the spinning icon appears on the side of 'Refresh list' button at the bottom of the result panel.

The spinning action never ends and if additional filters get un-checked, the multiple spinning icons will be displayed. Clicking on 'Refresh list' icons adds more spinning icons.

Screen Shot 2018-08-01 at 9.38.16 AM.png (457×1 px, 93 KB)

Screen Shot 2018-08-01 at 9.45.46 AM.png (85×418 px, 11 KB)

The Console display the following:

Uncaught TypeError: Cannot read property 'stats' of undefined
Uncaught TypeError: Cannot read property 'pages' of undefined

Details

SubjectRepoBranchLines +/-
Only add ORES condition when there is onemediawiki/extensions/PageTriagemaster+8 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Aug 1 2018, 5:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2018, 5:00 PM
Etonkovidova updated the task description. (Show Details)Aug 1 2018, 5:02 PM
Aklapper added a project: PageTriage.Aug 1 2018, 5:36 PM
Etonkovidova added a comment.Aug 1 2018, 8:02 PM

Note for testing after the fix: in testwiki (wmf.15) - multiple clicks on 'Refresh list' produce multiple spinning icons.

MMiller_WMF added a parent task: T195924: New Pages Feed: filter to draft states (1.2).Aug 1 2018, 8:58 PM
SBisson claimed this task.Aug 2 2018, 4:47 PM
SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
SBisson moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot subscribed.Aug 2 2018, 4:48 PM

Change 450058 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Only add ORES condition when there is one

https://gerrit.wikimedia.org/r/450058

gerritbot added a project: Patch-For-Review.Aug 2 2018, 4:48 PM
SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 2 2018, 4:48 PM
Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 6 2018, 5:54 PM
gerritbot added a comment.Aug 6 2018, 6:10 PM

Change 450058 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Only add ORES condition when there is one

https://gerrit.wikimedia.org/r/450058

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 6 2018, 7:00 PM
Etonkovidova closed this task as Resolved.Aug 6 2018, 11:57 PM

Checked the fix in betalabs.

Etonkovidova mentioned this in T201554: NPP - multiple-click on 'Refresh list' displays multiple spinning icons.Aug 8 2018, 8:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL