There are some code paths in Wikibase that are only run when Math extension is enabled. Running tests with the extension enabled could spot some issues, see e.g. failure mentioned in https://phabricator.wikimedia.org/T173949#4485102
As per considerations @hashar mentioned in T200976, probably just adding Math as the dependency extension to the Quibble job might not be the best idea. So probably this is going to be stalled until T200976 and/or T199939 see some progress/resolution.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Run Math tests for every change in Wikibase | integration/config | master | +1 -0 |
as mentioned in the description, this might not be immediately actionable, but will let @hashar decide on the order of things when he's back from his well deserved vacation.
I am not sure if that's the way to go. Neither the Math extension depends on Wikibase nor the other way round. For the CI math depends on wikibase. This is good for WMF applications. However, for private wikis that use Math but not wikibase this is not optimal since unintended dependencies on from math to wikibase would not be discovered. The same holds for the VisualEditor.
I would be more radical and suggest a kind of integration test with all WMF deployed extensions enabled as part of the gate and submit pipeline. Moreover, for this particular incident, the root of the problem seems to be a missing hook (see daniels comment).
I would be more radical and suggest a kind of integration test with all WMF deployed extensions enabled as part of the gate and submit pipeline.
Definitely. And eventually that will be achievable via the jobs prefixed with wmf-quibble which replace the old mediawiki-extensions jobs. In a nutshell we would run integration tests for wmf deployed extensions, and also tests for the extension with the just the dependencies it defines.
Slightly related, 204252 is about having dependencies added for all currently gated extensions. Though Math is not a dependency of any gated extension.
T243122: Math master is currently broken due to a Wikibase change would also have been caught by this.
Yes. Almost certainly. Especially in the beginning of the weekend it is sometimes frustrating if you start to realize that wikibase became incompatible to the math extension 🤔
Change 570941 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] Run Math tests for every change in Wikibase
We do not oppose to the change (i.e. "OK").
I personally find this a bit the other way around "logically", but given there is no structured way for depending extensions to check if "upstream" changes didn't break them, same as for an extension to ensure it is in sync with the mediawiki "core" version, this is nothing more than ranting I guess.
Change 570941 merged by jenkins-bot:
[integration/config@master] Run Math tests for every change in Wikibase
Mentioned in SAL (#wikimedia-releng) [2020-03-18T16:47:54Z] <James_F> Zuul: Run Math tests for every change in Wikibase T201496
Yeah, you're right that the model is inverted, because the system design has the objective of maintaining compatibility between each of the repos, not alerting that things need to change. Something I'm considering as part of the new CI work.