Page MenuHomePhabricator

Wikibase CI: Quibble job should possibly include Math extension
Open, NormalPublic

Description

There are some code paths in Wikibase that are only run when Math extension is enabled. Running tests with the extension enabled could spot some issues, see e.g. failure mentioned in https://phabricator.wikimedia.org/T173949#4485102

As per considerations @hashar mentioned in T200976, probably just adding Math as the dependency extension to the Quibble job might not be the best idea. So probably this is going to be stalled until T200976 and/or T199939 see some progress/resolution.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2018, 10:18 AM
WMDE-leszek triaged this task as Normal priority.Aug 8 2018, 10:19 AM

as mentioned in the description, this might not be immediately actionable, but will let @hashar decide on the order of things when he's back from his well deserved vacation.

as mentioned in the description, this might not be immediately actionable, but will let @hashar decide on the order of things when he's back from his well deserved vacation.

I guess we want to try to finish T200508 before trying to add Math to the mix

I am not sure if that's the way to go. Neither the Math extension depends on Wikibase nor the other way round. For the CI math depends on wikibase. This is good for WMF applications. However, for private wikis that use Math but not wikibase this is not optimal since unintended dependencies on from math to wikibase would not be discovered. The same holds for the VisualEditor.

I would be more radical and suggest a kind of integration test with all WMF deployed extensions enabled as part of the gate and submit pipeline. Moreover, for this particular incident, the root of the problem seems to be a missing hook (see daniels comment).

I would be more radical and suggest a kind of integration test with all WMF deployed extensions enabled as part of the gate and submit pipeline.

Definitely. And eventually that will be achievable via the jobs prefixed with wmf-quibble which replace the old mediawiki-extensions jobs. In a nutshell we would run integration tests for wmf deployed extensions, and also tests for the extension with the just the dependencies it defines.

hashar added a comment.EditedSep 13 2018, 3:34 PM

Slightly related, 204252 is about having dependencies added for all currently gated extensions. Though Math is not a dependency of any gated extension.